Loop help


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Loop help
# 1  
Old 07-23-2018
Loop help

Hi friends,

I have a program below where I need to input keyspace name so that program executing correctly, but I want to pass multiple values in keyspace in same time so that in single go, it should complete all keyspaces names that I pass to program.
Code:
#!/bin/bash

keyspace=$1
bkp_name="bkp-$$"
data_dir="/var/lib/data/"

if [ -z "${keyspace}" ]; then
    echo "Usage export.sh [keyspace]"
    exit 1
fi

echo "Create snapshot named: ${bkp_name}"
nodetool snapshot "${keyspace}" -t "${bkp_name}"

echo "Preparing backup file"
for name in $(find  "${data_dir}/${keyspace}/"*"/snapshots/${bkp_name}" -type f); do
        new=$(echo "$name" | sed -e "s#${data_dir}/##g" -e "s#\([^/]\+\)/\([^-]\+\).\+/snapshots/${bkp_name}/\([^/]\+\)\$#\1/\2/\3#g")
        mkdir -p "${bkp_name}/$(dirname $new)"
        cp "$name" "${bkp_name}/$new"
done

echo "Remove snapshot named: ${bkp_name}"
nodetool clearsnapshot -t "${bkp_name}" "${keyspace}"

echo "Dump keyspace and table creation instruction"
cqlsh -e "desc \"${keyspace}\";" > "${bkp_name}/${keyspace}.sql"

echo "Create tar file: ${keyspace}.tar.gz"
cd "${bkp_name}"
tar -czf "../${keyspace}.tar.gz" .
cd -

echo "Remove temporary files"
rm -rf "${bkp_name}"

------ Post updated at 08:41 AM ------

tried to use first two line
for arg; do
keyspace=$1

but its keep looping...
# 2  
Old 07-23-2018
This
Code:
#!/bin/bash
echo "arg count = $#"

while [ $# -gt 0 ]
do
    echo $1
    shift
done

reads through the parameters passed to the script, making each parameter be the first one using the shift keyword

So if you wrap your script -- yourscript.sh in my example - with the little script above:

Code:
#!/bin/bash
echo "arg count = $#"

while [ $# -gt 0 ]
do
    echo $1
    shift
    /path/to/yourscript.sh "$1"
done

you use your new script (example: new.sh)
Code:
#!/bin/bash

/path/to/new.sh  keyspace1 keyspace2  # go on to [ ....  keyspace9999 ]
exit

When you create the new script be sure to make it executable:
Code:
chmod +x new.sh

I went into a lot of extra detail because I think that you do not know shell scripting very well and other newbies may have similar questions.
This User Gave Thanks to jim mcnamara For This Post:
# 3  
Old 07-23-2018
Hi Thank you for reply.

Thank you for detailed explanation.

I tried with your solution wrapping my code in your code...

However its taking only one arugement
Code:
#!/bin/bash
echo "arg count = $#"

while [ $# -gt 0 ]
do
    echo $1
    shift
    /abexportcp.sh "$1"
done

and running this progream as

$> sh abexportcp.sh system_traces system -- here these are two keyspace names

when i see log on screen..it s saying argument is 2 but taking only one for doing backu
$ >sh new.sh system_traces system
arg count = 2
system_traces
Create snapshot named: bkp-130259
Requested creating snapshot(s) for [system] with snapshot name [bkp-130259] and options {skipFlush=false}
Snapshot directory: bkp-130259
Preparing backup file
Remove snapshot named: bkp-130259
Requested clearing snapshot(s) for [system] with snapshot name [bkp-130259]

Ideally, it has to work upon system_traces is first keyspace name , second keyspace name is system...

any suggestions

Last edited by Corona688; 07-23-2018 at 03:20 PM..
# 4  
Old 07-23-2018
Please use code tags.

You got one bit backwards, so your program ends up throwing away the first argument before you use it. Try reversing these two lines.

Code:
#!/bin/bash
echo "arg count = $#"

while [ $# -gt 0 ]
do
    echo $1
    /abexportcp.sh "$1"
    shift # Eliminates an argument, so put it after abexport
done

This User Gave Thanks to Corona688 For This Post:
# 5  
Old 07-24-2018
A for loop cycles over the script arguments by default:
Code:
bkp_name="bkp-$$"
data_dir="/var/lib/data/"
for keyspace
do
  echo do something with "$keyspace"
done

Replace the echo command with the remainder of your script!
This User Gave Thanks to MadeInGermany For This Post:
# 6  
Old 07-24-2018
@Corona688,

Wow that works, just moving the shift does work..Thank you

@ MadeInGermany

I tried your suggestion, but takes only first arugement twice..I liked this method as i dont need to put another script..however its not working ..here the tried code

Code:
#!/bin/bash

keyspace=$1
bkp_name="bkp-$$"
data_dir="/var/lib/data/"
for keyspace
do
if [ -z "${keyspace}" ]; then
    echo "Usage export.sh [keyspace]"
    exit 1
fi

echo "Create snapshot named: ${bkp_name}"
nodetool snapshot "${keyspace}" -t "${bkp_name}"

echo "Preparing backup file"
for name in $(find  "${data_dir}/${keyspace}/"*"/snapshots/${bkp_name}" -type f); do
        new=$(echo "$name" | sed -e "s#${data_dir}/##g" -e "s#\([^/]\+\)/\([^-]\+\).\+/snapshots/${bkp_name}/\([^/]\+\)\$#\1/\2/\3#g")
        mkdir -p "${bkp_name}/$(dirname $new)"
        cp "$name" "${bkp_name}/$new"
done

echo "Remove snapshot named: ${bkp_name}"
nodetool clearsnapshot -t "${bkp_name}" "${keyspace}"

echo "Dump keyspace and table creation instruction"
cqlsh 172.20.24.21 -e "desc \"${keyspace}\";" > "${bkp_name}/${keyspace}.sql"

echo "Create tar file: ${keyspace}.tar.gz"
cd "${bkp_name}"
tar -czf "../${keyspace}.tar.gz" .
cd -

echo "Remove temporary files"
rm -rf "${bkp_name}"
done

When I run
Code:
[root]# sh abexportcptest.sh system_traces system
Create snapshot named: bkp-8119
Requested creating snapshot(s) for [system_traces] with snapshot name [bkp-8119]                                                                                                              and options {skipFlush=false}
Snapshot directory: bkp-8119
Preparing backup file
Remove snapshot named: bkp-8119
Requested clearing snapshot(s) for [system_traces] with snapshot name [bkp-8119]
Dump keyspace and table creation instruction
Create tar file: system_traces.tar.gz
/home
Remove temporary files
Create snapshot named: bkp-8119
Requested creating snapshot(s) for [system_traces] with snapshot name [bkp-8119]                                                                                                              and options {skipFlush=false}
Snapshot directory: bkp-8119
Preparing backup file
Remove snapshot named: bkp-8119
Requested clearing snapshot(s) for [system_traces] with snapshot name [bkp-8119]
Dump keyspace and table creation instruction
Create tar file: system_traces.tar.gz
/home
Remove temporary files

Its creating system-trace twice.

Apologies for my poor knowledge if at all i did any mistake here..

------ Post updated at 01:08 AM ------

@ MadeInGermany

My apologies, there is typo in program...it did not pickup the loop Now your method too work Smilie thank you

------ Post updated at 01:09 AM ------

@ MadeInGermany

it works now..I mistyped keyspace as keysacpe ... so it did not pickup loop

Thank you very much

Last edited by onenessboy; 07-24-2018 at 03:03 AM..
# 7  
Old 07-24-2018
The following won't work as expected:
Code:
if [ -z "${keyspace}" ]; then
    echo "Usage export.sh [keyspace]"
    exit 1
fi

Move this before the for loop and test $1 (or [ $# -eq 0 ])
Code:
if [ -z "$1" ]; then
    echo "Usage export.sh [keyspace]"
    exit 1
fi
for keyspace
do
...

Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

For loop or while loop from a text file

Hi all, i developed a script to measure the uptime of a process in a Solaris 10/11 environments. All is well, but i came across a situation where there are multiple processes of the same name. Basically i have the following result file: beVWARS 13357 19592122 beVWARS 14329 19591910... (4 Replies)
Discussion started by: nms
4 Replies

2. Shell Programming and Scripting

awk loop using array:wish to store array values from loop for use outside loop

Here's my code: awk -F '' 'NR==FNR { if (/time/ && $5>10) A=$2" "$3":"$4":"($5-01) else if (/time/ && $5<01) A=$2" "$3":"$4-01":"(59-$5) else if (/time/ && $5<=10) A=$2" "$3":"$4":0"($5-01) else if (/close/) { B=0 n1=n2; ... (2 Replies)
Discussion started by: klane
2 Replies

3. Shell Programming and Scripting

Reset while loop to loop same file multiple times

Hi, I want to read file multiple times. Right now i am using while loop but that is not working. ex. While read line do while read line2 do echo stmt1 #processing some data based on data., done < file2.txt done < file1.txt # This will have 10... (4 Replies)
Discussion started by: tmalik79
4 Replies

4. Shell Programming and Scripting

Array Variable being Assigned Values in Loop, But Gone when Loop Completes???

Hello All, Maybe I'm Missing something here but I have NOOO idea what the heck is going on with this....? I have a Variable that contains a PATTERN of what I'm considering "Illegal Characters". So what I'm doing is looping through a string containing some of these "Illegal Characters". Now... (5 Replies)
Discussion started by: mrm5102
5 Replies

5. Shell Programming and Scripting

My for loop decides to become an infinite loop?

Hi, I was debating if I should put this in the dummies or scripts section, I apologize in advance if I chose poorly. Fairly new to Unix and BASH scripting but I thought I made it fairly well given my limited understanding. However, the output indicates that it's looping and I'm ending up with a... (5 Replies)
Discussion started by: gotreef
5 Replies

6. Shell Programming and Scripting

S# in a for loop - concatenate $(loop counter)

Hi, hope I am posting in the right section. My problem is that I have 2 or more arguments passed and I want to check if the arguments passed exists or not. The first argument should not exist and the remaining others should exist. example: ./shells.sh argument1 argument2 argument3 ... (5 Replies)
Discussion started by: fight4love
5 Replies

7. Shell Programming and Scripting

BASH loop inside a loop question

Hi all Sorry for the basic question, but i am writing a shell script to get around a slightly flaky binary that ships with one of our servers. This particular utility randomly generates the correct information and could work first time or may work on the 12th or 100th attempt etc !.... (4 Replies)
Discussion started by: rethink
4 Replies

8. Shell Programming and Scripting

Null Handling in Until loop. . .loop won't stop

Hi Im running this script, which is supposed to find the max value build some tables and then stop running once all the tables are built. Thing is , it keeps assigning a null value to $h and then $g is null so it keep building tables i.e. testupdateNUL. How can I stop this? Here is what I have: ... (4 Replies)
Discussion started by: brandono66
4 Replies

9. Shell Programming and Scripting

Using variables created sequentially in a loop while still inside of the loop [bash]

I'm trying to understand if it's possible to create a set of variables that are numbered based on another variable (using eval) in a loop, and then call on it before the loop ends. As an example I've written a script called question (The fist command is to show what is the contents of the... (2 Replies)
Discussion started by: DeCoTwc
2 Replies

10. Shell Programming and Scripting

Is there a better way I could have run this loop. (For loop with two variables)

Sorry for such a dreadful title, but I'm not sure how to be more descriptive. I'm hoping some of the more gurutastic out there can take a look at a solution I came up with to a problem, and advice if there are better ways to have gone about it. To make a long story short around 20K pieces of... (2 Replies)
Discussion started by: DeCoTwc
2 Replies
Login or Register to Ask a Question