Shell Programming and Scripting

It would appear the author intended the script to be used in ways other than just how it's called from the cronjob. If you remove that from the script, can you guarantee it will not impact something else (e.g. where else is the script called from, and how is it called)?

I will convert several scripts to Perl and we will move them to different server. So there is no impact on others.

Thank you for your advise. I appreciate it.

I understand the part about reimplementing it, so my point about not using getopts is moot. The script not getting any arguments, though, is a keen assumption on your part: it might be that the script if called from cron doesn't get any arguments, but it might be called somewhere else (and with arguments, for that matter). You might want to give this thought some consideration, maybe by calling:

Code:

find / -type f -exec /usr/local/bin/checkforscript {} <yourscriptname> \; 2>/dev/null

Where /usr/local/bin/checkforscript looks like:

Code:

#! /bin/ksh

if file "$1" | grep -qi script ; then
     grep "$2" /dev/null "$1"
fi

exit 0

Notice that the added /dev/null in the grep-call makes grep display the filename of the files in which hits are found.

I hope this helps.

bakunin

I am doing it now.

Thank you