Login or Register to Ask a Question and Join Our Community


Shell Programming and Scripting

Getopts help

Login to Discuss or Reply to this Discussion in Our Community

 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Getopts help
# 1  
Old 10-26-2016
Getopts help
Hi All,

I am writing a script to pass the getopts argument to the function which I have. But it as soon as I execute the script, the argument is taking it as blank. I tried using multiple way to check but its not working.

Can someone please let me know what wrong in this code.

Code:
function1()
{
processing details 
wget -i $base_dir/$APPNAME.txt --directory-prefix=downloads --http-user=$SVN_USR --http-password=$SVN_PASS -o $base_dir/$APPNAME.log
}

while getopts ":ackpsuv" OPT; do
        case "$OPT" in
                a) APPNAME=$OPTARG;;
                c)
                echo ;;
                k) KEYSTOREPSSWD="$OPTARG;;
                p) SVN_PASS="$OPTARG;;
                s)
                uploadSVN
                ;;
                u) SVN_USR=$OPTARG;;
                v) KEYSTORE=$OPTARG;;
        *) echo "Internal error!" ; exit 1 ;;
    esac
done

if [ -z "${APPNAME}" ] && [ -z "${SVN_USR}" ] && [ -z "${SVN_PASS}" ] 
then

function1 ${APPNAME} ${SVN_USR} ${SVN_PASS}

else
        echo "Check usage"
fi

As you can see, none of the variables are being taken by the function.

execution output
Code:
$ksh -x test.ksh -a "appname" -u "user" -p "pass" 
+ getopts :ackpsuv OPT
+ APPNAME=''
+ getopts :ackpsuv OPT
+ [ -z '' ]
+ [ -z '' ]
+ [ -z '' ]
+ [ -z '' ]
+ echo 'Downloading the required perevious year files from SVN Repo..'
+ wget -i ./.txt --directory-prefix=downloads --http-user= --http-password= -o ./.log
+ grep 'Authorization failed.' ./.log
+ wc -l
+ error=0
+ [[ 0 -ne 0 ]]
+ tail -1 ./.log
+ cut '-d ' -f2
+ completed=URLs
+ [[ URLs -ne 6 ]]
+ echo 'All the required files not downloaded! Please check.'
All the required files not downloaded! Please check.
+ exit 3

Please can someone help me in this case?

Regards
Sid


Moderator's Comments:
Mod Comment You should be familiar with code tags, so please use them.
Last edited by zaxxon; 10-26-2016 at 11:52 AM..
# 2  
Old 10-26-2016
You seem to have at least four errors in your script:
- You have a colon preceding ALL option chars. man ksh:
Quote:
If a letter is followed by a :, that option is expected to have an argument.
- Two of your $OPTARG expansions have leading unpaired double quotes making the "p" case part of a string.
- Your -z test is wrong - don't test for zero but for non-zero.
- "processing" is NOT a valid command.
This User Gave Thanks to RudiC For This Post:
sidh_arth85
# 3  
Old 10-26-2016
Thank you very much for your quick response on this.

Apologies for the earlier code, that was just a typo while I was editing and I have accidentally deleted the double quotes.

I am passing (-a "appname") as a mandatory argument when I am executing and the rest are optional. But when I am assigning each OPTARG to the respective variable then those variables become null when I am passing the variable values in the function arguments.

I am removed the -z option and tried with the following code and now I got blank.

Is it something I am doing it wrongly? Please kindly advise. Thanks

Code:
if [ "${APPNAME}" != "" ] && [ "${SVN_USR}" != "" ] && [ "${SVN_PASS}" != "" ] && [ "${KEYSTOREPSSWD}" != "" ]
then
downloadfiles ${APPNAME} ${SVN_USR} ${SVN_PASS}
else
        echo "Check usage"
fi

Code:
$ ksh -x test.ksh -a "appname" -u "user" -p "pass" 
+ APPNAME=''
+ SVN_USR=''
+ SVN_PASS=''
+ KEYSTOREPSSWD=''
+ getopts :ackpsuv OPT
+ APPNAME=''
+ getopts :ackpsuv OPT
+ [ '' != '' ]
+ echo 'Check usage'
Check usage
+ [ '' != '' ]
+ echo 'Check usage'
Check usage
+ exit 1



Moderator's Comments:
Mod Comment Please use CODE tags as required by forum rules!
Last edited by RudiC; 10-26-2016 at 12:53 PM.. Reason: Added/ CODE tags.
# 4  
Old 10-26-2016
The option character should be FOLLOWED by a colon, NOT preceded!
This User Gave Thanks to RudiC For This Post:
sidh_arth85
# 5  
Old 10-26-2016
Thank you RudiC,

It worked fine after I shift the colon. Much appreciated.

RegardsSmilie
Sid
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Using getopts

Hi. Can somebody please show me an example of how to use getopts to assign a variable if it's been passed into the script but to set a default if no value has been passed in? And also how to handle a param with multiple values ... so a sub parse (can I use a function for this?)? Here's my code... (1 Reply)
Discussion started by: user052009
1 Replies

2. UNIX for Dummies Questions & Answers

Getopts

while getopts v OPTION do case $OPTION in v) echo "Hello" ;; *) exit 1;; esac done Suppose I have script tmp.sh Whose Signature is tmp.sh <fixed_argument> When I run the script with tmp.sh -v "file", it echoes a hello but, when I try the other way i.e, tmp.sh... (1 Reply)
Discussion started by: Devendra Hupri
1 Replies

3. Shell Programming and Scripting

Using getopts. Need help

Hi all... I have been looking on here for the past few days for an answer and Im gonna have to break down and ask. I just learned about the getopts command last week so have been trying to utilize it in my scripts. Below, I am trying to set up a case structure for options using getopts.... (1 Reply)
Discussion started by: losingit
1 Replies

4. Shell Programming and Scripting

getopts help

First off, I apologize for my lack of knowledge. I realize my problem will probably seem pretty basic to everyone, but I've been at this for several hours now and I've gotten nowhere. I would contact my professor, but it is too late for that. Anyway, I'm trying to write a function called... (1 Reply)
Discussion started by: Unknown50862
1 Replies

5. UNIX for Dummies Questions & Answers

Getopts

Hey, i need help with the use of getopts in shell script. tried reading a lot online, but found incomplete examples (maybe complete but cudn't make out). PLzz help...explain in deatil plzzz, i am a newbie:confused: (3 Replies)
Discussion started by: SasankaBITS
3 Replies

6. Shell Programming and Scripting

using getopts

Hi, I have a program where I want to use getopts. I want to use "-i" option and then optionally supply arguments. If user dosent supply arguments, then also it should work. Please tell me how to proceed. Here is some code, this is not right code btw but a sample to understand what I want to... (1 Reply)
Discussion started by: som.nitk
1 Replies

7. Shell Programming and Scripting

Using getopts

I am having some trouble/questions with getopts that I can't find any solid info on with google I need it to parse things of the syntax of: -r # # # -f -c with as many repeats as possible, and it should catch erroneous commands also, but continue going... my first question is, -r... (3 Replies)
Discussion started by: TurboArkhan
3 Replies

8. HP-UX

using getopts

Is there a restriction on levels of using 'getopts' ? I have several scripts, each of which requires an option as the first parameter . If I call one prg separately it works fine, but when one prg calls another prg and passes the option on the called prg, then the called prg seems not to process... (3 Replies)
Discussion started by: vslewis
3 Replies

9. Shell Programming and Scripting

Help in getopts

Hi, My script will take a input file as a parameter(which is not mandatory) and also an option. ksh my_script.sh <inputfile> The option -n I have given is no way related to the input file. Now the problem here is when i execute the script specifying the input file and the option(the way... (4 Replies)
Discussion started by: chella
4 Replies

10. Shell Programming and Scripting

getopts

I have a script that facillitates NDM (Connect::\Direct) transfer to remote hosts. This script uses getopts to parse through the parameters passed to it and to set appropriate variables based upon what was passed in. Kickoff="mv $PATH/$FILE1 $PATH/$FILE2" ndm_shell.ksh -p $Node -s $Source -d... (3 Replies)
Discussion started by: google
3 Replies
Login or Register to Ask a Question