Shell Programming and Scripting

hi made in germany,

thank you and i am trying your code right now. but can you check my script at post #26?. what went wrong or what is my mistake? super thank you so much for the help.

The directories you are searching, the strings you are matching, the names of the files you are processing in the directories you are searching, and the shell you are using seems to change with every post you make. We can't keep up with all of the changes you are making and we still do not have a clear description of what you are trying to do. (Especially whether some of the pathnames you are supplying are the names of files to be processed or the names of directories [AKA folders] containing files to be processed.)

But some problems with your code in post #26:

Code:

#list all folders for FTR
folderFTR="/files05/home/chgtpst/GT/outb/CHTR/FTR/9/archive_ia
/files05/home/chgtpst/GT/outb/CHTR/FTR/9/send_ia
/files05/home/chgtpst/GT/outb/CHTR/FTR/9/send"

#list all folders for VRZ
folderVRZ="/files05/home/chgtpst/GT/outb/CHTR/VRZ/9/archive_ia
/files05/home/chgtpst/GT/outb/CHTR/VRZ/9/send
/files05/home/chgtpst/GT/outb/CHTR/VRZ/9/send_ia/success"


#Main program for FTR
for f in $folderFTR
do
    if [ 'grep FTRORD -l "$f"' ]
    then
        echo "invalid file in $f" >> /home/abainzd/logfile.txt

    else
       exit 1 
    fi
done


#Main program for VRZ
for f in $folderVRZ
do
    if [ 'grep CHTRVRZPRD -l "$f"' ]
    then
        echo "Invalid file in $f" >> /home/abainzd/logfile.txt

    else
       exit 1 
    fi
done

include (but might not be limited to):I apologize for not noticing that you used /bin/sh when you ran my script instead of /bin/ksh) after you had told us at least three times that you were using the Korn shell.

I apologize for not mentioning that you would have to use /usr/xpg4/bin/grep instead of /usr/bin/grep to use the -q option.

I have absolutely no explanation for why you modified the script I suggested in post #21 to process the four files you described in post #20:

Code:

cd home/solaris/unix/samplefiles/ && \
for file in *.txt
do	if ! grep -q davehandsome "$file"
	then	printf 'File "%s" does not contain the string "davehandsome"\n' "$file"
	fi
done

to:

Code:

cd $EDI_ROOT/GT/outb/CHTR/VRZ/9/send && \
for file in *.edi
do      if ! /usr/xpg4/bin/grep  -q CHTRVRZPRD "$file"
        then    printf 'File "%s" does not contain the string "CHTRVRZPRD"\n' "$
file"
        fi
done

and ran it in a directory where there are no filenames that end with the string .edi when you said you wanted to look for a different string in one of four existing files in a different directory.

If you had told us that some of the directories you want to search do not contain any files, we would have suggested different code, perhaps something more like:

Code:

#!/bin/ksh
EDI_ROOT="/absolute/path/to/directory"
# The absolute pathname of the directory named by EDI_ROOT must contain a
# subdirectory accessible by the relative pathname "BT/outb/CHTR/VRZ/9/send".

cd $EDI_ROOT/GT/outb/CHTR/VRZ/9/send && \
for file in *.edi
do      if [ -f "$file" ] && ! /usr/xpg4/bin/grep  -q CHTRVRZPRD "$file"
        then    printf 'File "%s" does not contain "CHTRVRZPRD"\n' "$file"
        fi
done

Note that case matters in Solaris and other UNIX systems. The string "UNIX" and the string "unix" are NOT the same. (Case matters!)

If you were asked (as an EE) to create a circuit that is given +5V DC power and instead of +5V DC power the user connected it to 120V AC power, should we be disappointed if your circuit exploded? If you tell us you want to search for a string in a bunch of files that match a certain filename matching patter in a directory, don't be surprised if a grep command that we suggest doesn't do what you want if you ask it to process files matching a pattern that does not match any files in that directory. If you tell us you want to search for a string in a bunch of files in a directory, don't be surprised if a grep command that we suggest doesn't do what you want if you give it the name of a directory to process instead of a list of one or more files in that directory to process.

Computers can do some things very quickly. They usually do exactly what you ask them to do even if what you ask them to do is dangerous. In CS we have a frequently referenced acronym: GIGO (Garbage In, Garbage Out). If your specifications are not clear (GI), the results you get from running code written to meet what the programmer guesses you meant are likely to give you GO.

Please help us help you!

hi don,

i understand and im refelcting all of the things right now.. and im so sorry.. for all the change of post and directories and variable and all.. thanks a lot for your help.

Thank you for the much clearer specification. But, there are still a few things missing in your specification:With the assumptions stated above, the following script should do what you have requested on a Solaris system (although I did take a few liberties with the messages written to your log file). I assume that you will be able to adjust the text in the printf statements if you don't like the text I used.:

Code:

#!/bin/ksh
bad_found=0
dir='/files05/home/chgtprd/MXS/inb/CHTR/FTR/9/'
log='/files05/home/chgtprd/logfile.txt'

cd "$dir" && for file in *
do	if [ -f "$file" ] && ! /usr/xpg4/bin/grep -q FTRORD "$file"
	then	printf 'Invalid file "%s" in "%s"\n' "$file" "$dir"
		bad_found=1
	fi
done > "$log"
if [ $bad_found -eq 0 ]
then	printf 'There are no invalid files in "%s"\n' "$dir" > "$log"
fi

hi don,

1) sorry i forgot to mention that the log file should be created in

Code:

/home/abainzd

thank you

Sorry,
Although it won't affect the operation of the script, the last two lines in your script should not be indented.

I had a copy and paste error that dropped the last line of the script (which has now been corrected in post #32). Either add the line:

Code:

fi

to the end of the script, or change the last two lines of the script from:

Code:

if [ $bad_found -eq 0 ]
then    printf 'There are no invalid files in "%s"\n' "$dir" > "$log"

to:

Code:

[ $bad_found -eq 0 ] && printf 'There are no invalid files in "%s"\n' "$dir" > "$log"

Hi don,,

i added

Code:

fi

on the last line and it works perfecrtly.. tahnk you so much..