Login or Register to Ask a Question and Join Our Community


Shell Programming and Scripting

Need a help on the below shell script

Login to Discuss or Reply to this Discussion in Our Community

 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Need a help on the below shell script
# 1  
Old 11-07-2014
Need a help on the below shell script
I have changed the code to zip and sent to the users as exhange has a maximum send/ receive limit of 20 MB
Code:
REPORT_FILE=$(ls $new_mdatfile_cat.csv)
REPORT_FILE_SIZE=$(ls -ltr $new_mdatfile_cat.csv | awk '{print $5}')
if [[ -f $REPORT_FILE ]]; then
# Check the file size, if its greater than 20 MB then zip the file,else dont
if [[ $REPORT_FILE_SIZE > 20971520 ]];then
ZIP_FILE_NAME=$(ls $new_mdatfile_cat.csv | awk -F '.' '{print $1}')
zip $ZIP_FILE_NAME.zip $new_mdatfile_cat.csv || error_func "The Report file cannot be zipped"
#Send the zipped file to the NOTIFY
echo " Report for:
Histroy category: $old_mdatfile_cat, current category: $new_mdatfile_cat
" | mimemail -s "Zipped Report" -t -b $ZIP_FILE_NAME.zip
 
move_to_history_area_func $new_mdatfile_cat.$WEEK || \
error_func "Failed to move current to history area: $new_mdatfile_cat.$WEEK"
else
echo "Report for:
Histroy category: $old_mdatfile_cat, current category: $new_mdatfile_cat
" | mimemail -s " Report" -t -a $QC_REPORT_FILE
 
move_to_history_area_func $new_mdatfile_cat.$WEEK || \
error_func "Failed to move current to history area: $new_mdatfile_cat.$WEEK"
fi
else
error_func "Error while creating report in perl script"
fi
 
 
move_to_history_area_func()
{
tar_file=${1}.tar
for ifile in ${FILES}
do
[[ -f $ifile ]] || return 1 # return error if input file is missing
done
tar -cvf $tar_file ${FILES} || return 1
[[ -f $HISTORY_AREA/$tar_file ]] && rm -f $HISTORY_AREA/$tar_file
mv $tar_file $HISTORY_AREA/$tar_file || return 1
}

I could see the files are moved to the destination correctly. eventhough error function occurs stating that "Failed to move current infomart to history area".

Please let me know what I did wrong,
Last edited by k.keerthi2005; 11-07-2014 at 02:34 AM.. Reason: cleaned out all FONT tags, introduced CODE tags...
# 2  
Old 11-07-2014
Can you please run your script with -x option and see what actually is happening and post here if there are any anomallies?
# 3  
Old 11-07-2014
Thanks for using code tags in your first post!

What's the value of ${FILES} in move_to_history_area_func()?

Some comments:
Good indentation improves readability and comprehensibility for everyone including yourself
Typing in (nearly) identical code twice is cumbersome and error prone. Identify the differences, handle them in the if ... then ... else ... fi construct, and then go on with one version of the residual code.
# 4  
Old 11-10-2014
Code:
+ move_to_history_area_func Q35097C.W1834
+ tar_file=Q35097C.W1834.tar
+ [[ -f Q35097C.CNT ]]
+ [[ -f Q35097C.DIC ]]
+ [[ -f Q35097C.DIM ]]
+ [[ -f Q35097C.FOR ]]
+ [[ -f Q35097C.HIE ]]
+ [[ -f Q35097C.LVL ]]
+ [[ -f Q35097C.MEA ]]
+ [[ -f Q35097C.MET ]]
+ [[ -f Q35097C.VAR ]]
+ [[ -f Q35097C.001 ]]
+ tar -cvf Q35097C.W1834.tar Q35097C.CNT Q35097C.DIC Q35097C.DIM Q35097C.FOR Q35097C.HIE Q35097C.LVL Q35097C.MEA Q35097C.MET Q35097C.VAR Q35097C.001
a Q35097C.CNT 5 blocks
a Q35097C.DIC 1167 blocks
a Q35097C.DIM 4 blocks
a Q35097C.FOR 19 blocks
a Q35097C.HIE 1 blocks
a Q35097C.LVL 5 blocks
a Q35097C.MEA 2 blocks
a Q35097C.MET 5 blocks
a Q35097C.VAR 1 blocks
a Q35097C.001 7272 blocks
+ [[ -f /ss/files/QC/Q35097C.W1834.tar ]]
+ mv Q35097C.W1834.tar /ss/files/QCRepository/Q35097C.W1834.tar
+ error_func Failed to move current infomart to history area: Q35097C.W1834
+ [[ -n Failed to move current to history area: Q35097C.W1834 ]]
+ echo ERROR: Failed to move current to history area: Q35097C.W1834
+ mailx -s QC report error: /ss/files/qc.Q35097/.qc.Q35097 
+ exit 1
ERROR: file_qc.sh Q35097C.CNT Q35097C.DIC Q35097C.DIM Q35097C.FOR Q35097C.HIE Q35097C.LVL Q35097C.MEA Q35097C.MET Q35097C.VAR Q35097C.001 failed

Last edited by Scott; 11-11-2014 at 06:36 AM.. Reason: Code tags
# 5  
Old 11-10-2014
try to move test files with manuel and what about of result ?
if you want to a solution you must paste the full script code and because of there is no error handlers in your code and move function is not correct position
# 6  
Old 11-11-2014
thanks
Last edited by k.keerthi2005; 11-11-2014 at 03:04 AM..
# 7  
Old 11-11-2014
What puzzles me is
- No error msg between these two commands (yet move_to_history_area_func() must return 1):
Code:
+ mv Q35097C.W1834.tar /ss/files/QCRepository/Q35097C.W1834.tar
+ error_func Failed to move current infomart to history area: Q35097C.W1834

- The "infomart" in above call to error_func is NOT mentioned in the script

Try to
- echo something at the end of move_to_history_area_func()
- put the error_func call into the same line as the move... call, i.e. no continuation "\" in both places.
- show us the location of the "infomart" word.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

Shell script newbie- how to generate service log from shell script

Hi, I am totally a newbie to any programming languages and I just started an entry level job in an IT company. One of my recent tasks is to create a script that is able to show the log file of linux service (i.e. ntpd service) lets say, if I run my script ./test.sh, the output should be... (3 Replies)
Discussion started by: xiaogeji
3 Replies

2. Shell Programming and Scripting

Pass C shell array to another C shell script(csh) and shell(sh)

Dear Friends, Please help me on this my script name is send.csh In this i have written the statement like this set args = ( city state country price ) I want to pass this array to another c shell called receiver.csh. and i want to use it in this c shell or how to pass to... (2 Replies)
Discussion started by: SA_Palani
2 Replies

3. Shell Programming and Scripting

How to write config shell script to pass variables in master shell script?

Dear Unix gurus, We have a config shell script file which has 30 variables which needs to be passed to master unix shell script that invokes oracle database sessions. So those 30 variables need to go through the database sessions (They are inputs) via a shell script. one of the variable name... (1 Reply)
Discussion started by: dba1981
1 Replies

4. UNIX for Dummies Questions & Answers

How to write Config shell script to pass variables in master shell script?

Dear Unix gurus, We have a config shell script file which has 30 variables which needs to be passed to master unix shell script that invokes oracle database sessions. So those 30 variables need to go through the database sessions (They are inputs) via a shell script. one of the variable name... (1 Reply)
Discussion started by: dba1981
1 Replies

5. Shell Programming and Scripting

Unable to pass shell script variable to awk command in same shell script

I have a shell script (.sh) and I want to pass a parameter value to the awk command but I am getting exception, please assist. diff=$1$2.diff id=$2 new=new_$diff echo "My id is $1" echo "I want to sync for user account $id" ##awk command I am using is as below cat $diff | awk... (2 Replies)
Discussion started by: Ashunayak
2 Replies

6. Shell Programming and Scripting

Correct shell script to Call One shell script from another shell script

Hi All, I have new for shell scripting. Problem : I have one scrip at serv1 and path of server is /apps/dev/provimage/scripts and script name:extract_ancillary.bat. I need to call this script at server2(my working server) and execute at server2 . Please let me know how to build the... (5 Replies)
Discussion started by: Vineeta Nigam
5 Replies

7. Shell Programming and Scripting

call another shell script and pass parameters to that shell script

Hi, I basically have 2 shell scripts. One is a shell script will get the variable value from the user. The variable is nothing but the IP of the remote system. Another shell script is a script that does the job of connecting to the remote system using ssh. This uses a expect utility in turn. ... (2 Replies)
Discussion started by: sunrexstar
2 Replies

8. Shell Programming and Scripting

How to use ssh execute other shell script on other host (shell script include nohup)?

i want use ssh on the host01 to execute autoexec.sh on the host02 like following : host01> ssh host02 autoexec.sh autoexec.sh include nohup command like follwing : nohup /home/jack/deletedata.sh & after i execute ssh host02 autoexec.sh one the host01. i can't found deletedata.sh... (1 Reply)
Discussion started by: orablue
1 Replies

9. Shell Programming and Scripting

invoking a shell script inside cgi shell script

Hi, I have an HTML form through which I get some text as input. i need to run a shell script say script.sh inside a perl-cgi script named main_cgi.sh on the form input. I want to write the contents of the form in a file and then perform some command line operations like grep, cat on the text... (2 Replies)
Discussion started by: smriti_shridhar
2 Replies

10. Shell Programming and Scripting

How to Run a shell script from Perl script in Parent shell?

Hi Perl/UNIX experts, I have a problem in running a shell script from my perl script (auto.pl). I run the perl script using perl auto.pl from the shell prompt The shell script picks the files in "input" folder and procesess it. The shell script blue.sh has this code. export... (16 Replies)
Discussion started by: hifake
16 Replies
Login or Register to Ask a Question