Shell Programming and Scripting

It is producing multiple "the file is not correct" messages because that's what you have asked it to do.

Your inner loop ask it to consider every file with for f in `ls *.txt` This could be shortened to just for f in *.txt for a starter, but if you have 30 .txt files, you will get up to 30 the file is not correct messages displayed for that directory.

You then have a bit of an open loop with for i in * which will then drive the for f in loop again and again and again. What happens with any files in the current directory (i.e. not directories in themselves)? I expect that they will error on the cd and then carry on with the for f loop in the current directory.

What is the actual requirement of this part of your code? Maybe I'm missing the point, but you are collecting current date and then the same time for the previous three days and then compare this value to the file names that end .txt in a format I don't understand. Can you explain:-

Code:

if [ ! "$file" = "$DATEN" ] &&  .........

Is this an "If the value $file is not like the value of $DATEN" or something?

Apologies if I've not learned this syntax yet and it is correct.



Robin

Yes. I am trying to compare file to DATEN. I want to get only one printout that says "file not there" and not a printout of "file not there" for each file in each directory. So I want one message per directory.
I'll check out your suggestions as well -- thanks.

If you are trying to check if two variables match, the syntax would be like this:-

Code:

if [ "$file" != "$DATEN" ] .........

Robin

That works as well, but I still get multiple messages for each file that does not match the criteria. How do I get one "the file is not there"? I want it to say that the file is not there once for each directory no matter how many files do not match the criteria. I've tried everything and can not figure it out.

Could you change you code so that you keep the outer loop through the list of directories (considering my earlier comment about what happens when for i in * finds a file that it can't cd to)

Inside each directory, you could simply test if the files exist:-

Code:

if [ -f "$DATEN" ] && [ -f "$DATE2" ] && ........

.... which takes out the inner loop and will probably run faster too.

Does this help?




Robin

This is how it looks since yesterday (sorry I did not update it earlier). I believe that the -f DATEN and -f DATE2 does not work because I need to compare what truss outputs to the DATEN and DATE2

All I want to do is have it print "file not found: for each directory in which it does not find any matching date. So far it will print that message when any file in any directory does not match the date, so I will get 10 -15 prints in each directory of the message

Code:

DATEN=$(perl -e 'print scalar(localtime(time -  0 * 24 * 60 * 60)), "\n";' |awk '{print $2,$3,$5}')
DATE2=$(perl -e 'print scalar(localtime(time - 2 * 24 * 60 * 60)), "\n";' |awk '{print $2,$3,$5}')


]for i in * ; do (cd $i; echo $i; for f in `ls *.txt`;
do
file=$(truss -vlstat -tlstat ls -l $f 2>&1 |awk 'NR==4'|gawk '{print $3, $4, $7}')
if [ -f "$DATEN" ] && [ -f "$DATE2" ];
then echo "$file" >/dev/null
else echo "YES"
fi
done)
done[

---------- Post updated at 09:58 AM ---------- Previous update was at 09:47 AM ----------

Also, it would help if I could search on "does the file match the date". would this be

Code:

 [  "$file" = "$DATEN" ] || [  "$file" = "$DATE2" ]

would that mean if the file matchies date 1 or if it matches date2?

---------- Post updated at 10:17 AM ---------- Previous update was at 09:58 AM ----------

Is there a way to echo a message just once and send the rest to /dev/null ?
So that there would be just one message printed for each directory?

---------- Post updated at 11:03 AM ---------- Previous update was at 10:17 AM ----------

also the previous post you made appears to work somewhat:

Code:

for i in * do    echo $i    for f in "$Z" "$Z1" "$Z2" "$Z3" "$Z4" "$Z5" "$Z6"    do       if [ -f "$i/$f" ]       then           echo "it is there"           continue 2       fi     done     echo "NO" done

but it echos yes for everything even though there are no matching files, this
is because I am trying to compare what is in truss command not "do the files exist or not"

Yes, you can print one message per directory. But, only if your code only prints one message per directory. Your code prints one message per file.

Code:

[  "$file" = "$DATEN" ] || [  "$file" = "$DATE2" ]

exits with a zero exit status if the string to which $file expands is identical to the string to which $DATEN expands OR the string to which $file expands is identical to the string to which $DATE2 expands.

Please take a few steps backwards here. We understand that you want to print one message per directory indicating whether or not some condition is met by the files in that directory. What is the condition? Please explain in English what you are trying to determine!

Are you looking for a file whose name is the same as the date on which that file was last modified? (It seems EXTREMELY unlikely that the date on which a file was modified is going to end with the four characters .txt!)

For those of us who don't have truss on our system, what is the output from the command:

Code:

truss -vlstat -tlstat ls -l $f 2>&1

when f is set to the name of a text file in the current directory?