Shell Programming and Scripting

So, I have a series of ASCII files, all named something like mrkxxxxz.tmp (say, mrk1001z.tmp, mrk1002z.tmp, mrk1003z.tmp,...) -- these are .tmp files created by a large simulation program, and each different .tmp file represents a different parameter space used in the simulation). The simulations were originally run on a Cray, and on said platform, I would run the following shell script (which I call simbatch) to process them, and send them off to a FORTRAN application called 'mark':

Code:

# construct the mark command to run a set of mrkxxxxz.tmp files
echo $@
for i in $@ do
   #echo $i
   out=`echo $i | sed 's/z\./y\./'`
   #echo $out
   res=`echo $i | sed 's/z\./x\./'`
   #echo $res
   vc=`echo $i | sed 's/z\./v\./'`
   #echo $vc
   tmp=`echo $i | sed 's/z\./s\./'`
   #echo $tmp
   echo `date` >>'$tmp'
   nohup mark i='$i' o='$out' r='$res' v='$vc' >&'$tmp' &
done

Now, this works fine on the Cray, but under Linux, nada. I get all sorts of errors:

Code:

'/simbatch: line 5: syntax error near unexpected token `out=`echo $i | sed 's/z\./y\./'`

I'm *guessing* this is a problem with 'quoting' things, but I'll be darned if I've hit on the right combination.

Pointers to the obvious?

Thanks in advance!

Hi, the problem is here:

Code:

for i in $@ do

Which should be

Code:

for i in "$@"; do

or

Code:

for i in "$@"
do

Your old shell (on the Cray) may have happened to accept it, but it is not correct.

--
Also note that because of the single quotes, the variables will not be expanded:

Code:

nohup mark i='$i' o='$out' r='$res' v='$vc' >&'$tmp' &

If you need them expanded, use double quotes instead of single quotes...


--
Since "$@" is the default you can also just omit it:

Code:

for i do

or

Code:

for i
do

This:

Code:

for i ; do

is officially not allowed in the Posix specification, but most modern shells do not have a problem with it, unlike earlier Bourne Shells.

Perfect -- thanks *very* much. I had guessed my way through things and by brute force had gotten some things working, but your reply cleared everything up perfectly.