Shell Programming and Scripting

Hi Friends,
I want to copy my .mp4 files from a file of my mobile to my pc using the programm adb (Android Development Bridge).

My Script:
./copyfiletopc /sdcard/Playtube ~/musik/PlayTube \.mp4

Code:

#!/bin/bash
# $1 = from dir
# $2 = to dir
# $3 = search
  
# adb is the AndroidDevelopmentBridge
# adb shell [command] executes the command
# on the smartphone.

adb shell ls $1 | grep -i $3 > filenames.txt
  
    for i in `cat filenames.txt`
    do
  # adb pull [source] (target) copies the requested files
  # from smartphone to pc
  
  # Parameter:
   # $1/$i = /sdcard/PathSmartphone/CurrentFilename.mp4
   # $2/$i = ~/PcPath/CurrentFilename.mp4
  adb pull "$1/$i $2/$i"
done

First the script starts with

Code:

 adb shell ls $1 | grep -i $3 > filenames.txt 

which saves all .mp4 files to the file filenames.txt.

The file looks like this:
0nrmWz3RVQA.mp4
5AyJyoiH5-k.mp4
...

After that the script should read every line in the file after each other and copy all files whith this comand
adb pull "$1/$i $2/$i"

but however after the variable $i the rest ($2/$i) is automatically placed in front of the parameters, so that "$1/$i $2/$i" doesn't display the two parameters:
[source] (target)
/sdcard/PlayTube/0nrmWz3RVQA.mp4 root/musik/PlayTube/0nrmWz3RVQA.mp4

but:
/root/musik/PlayTube/0nrmWz3RVQA.mp4
/root/musik/PlayTube/5AyJyoiH5-k.mp4

and the result of testing

Code:

 echo "$1/$i bla"

in the for loop is:
blaard/PlayTube/0nrmWz3RVQA.mp4
blaard/PlayTube/5AyJyoiH5-k.mp4
and not:
sdcard/PlayTube/0nrmWz3RVQA.mp4 bla
sdcard/PlayTube/5AyJyoiH5-k.mp4 bla

And I don't know why?

Sorry for my bad English
Thanks in advance

Did you try writing to a file and check instead of echoing

Code:

 echo "$1/$i bla"

?

Does your filenames.txt look clean without any <CR> at the end of the line ?

1. Try to write what to a file?
2. <CR> ??


---------- Post updated 08-04-13 at 05:16 AM ---------- Previous update was 08-03-13 at 04:37 PM ----------

Ahhh
Now I know what <CR> means, and if I remove the <CR> with an texteditor manually, it works.
But is it possible, that the command ls does this automatically?
Or do you know an alternative maybe?

Thanks in advance
Marco