Login or Register to Ask a Question and Join Our Community


Shell Programming and Scripting

My script failed and can't fix it ?

Login to Discuss or Reply to this Discussion in Our Community

 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting My script failed and can't fix it ?
# 8  
Old 04-20-2013
Why are the loops nested??
The find loop obscures the outer loop by moving files away.
Also the find loop finds the already moved files.
Untested propopsal:
Code:
for file in ?????????*
do
if [ -f "$file" ]
 then
  dir=$(echo "$dir" | cut -c1-8)
  mkdir -p "$dir"
  mv "$file" "$dir"
 fi
done

This User Gave Thanks to MadeInGermany For This Post:
arm
# 9  
Old 04-20-2013
I think the issue with this loop as you claimed but below line must be changed from $dir to $file , I will test it soon :

Code:
dir=$(echo "$file" | cut -c1-8)

Last edited by arm; 04-20-2013 at 03:16 PM..
This User Gave Thanks to arm For This Post:
MadeInGermany
# 10  
Old 04-20-2013
Quote:
Originally Posted by arm
I think the issue with this loop as you claimed but below line must be changed from $dir to $file , I will test it soon :

Code:
dir=$(echo "$file" | cut -c1-8)

Yes you corrected it well.
# 11  
Old 04-22-2013
The same issue I can not run it , I'd like to draw your attention if I test every block individually it works but as I mentioned I want to combine 2 blocks in one script ( block 1 is to get the files and block 2 is to organized the files into directories ) ...
# 12  
Old 04-22-2013
Repost in this thread the script as you have it, with any corrections you have done. That way we can see the current situation. Smilie
# 13  
Old 04-23-2013
Dear Hanson44
Code:
#!/bin/sh ddir=/dest      sdir=/src/user/      [ -d $sdir ] || mkdir -p  $sdir echo  "$0 started: $(date)" ftp -in x,x,x,x  << ENDFTP user username password cd $ddir lcd $sdir bin prompt mget *.text bye ENDFTP echo  "$0 finished: $(date)" cd $sdir for dir in $( ls -1  | cut -c1-8 | sort -u ) ; do     [ -d $dir ] || mkdir  -p $dir           for file in $( find $dir  -type f ) ; do           echo "Move $file  to  $dir"           mv  $file  $dir               done done

# 14  
Old 04-23-2013
See post #5. And: your post #13 is unreadable.
This User Gave Thanks to RudiC For This Post:
arm
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Fix script to get missing information

Gents, Can you please help me to fix the following script in order to get complete data as desired. I am missing some data in output. the complete input file is attached. The script I am using is awk '{\ status=substr($0,91,2)\ ind=substr($0,26,1);\ ... (10 Replies)
Discussion started by: jiam912
10 Replies

2. UNIX for Dummies Questions & Answers

How to fix Python path for some script/app?

Hello, i have: # python -V Python 2.7.6 But original for my CentOS is 2.3 or 2.4 my python folder: /root/python2.7.6 (inside are folders like lib, include, bin, share) I launched app iotop: # iotop -od 6 Traceback (most recent call last): File "/usr/bin/iotop", line 16, in... (3 Replies)
Discussion started by: postcd
3 Replies

3. Shell Programming and Scripting

How to fix my IMDB Script

Hello, I am using IMDB bot file for my movie site.. But I get this message like this---Parse error: syntax error, unexpected end of file, expecting variable (T_VARIABLE) or ${ (T_DOLLAR_OPEN_CURLY_BRACES) or {$ (T_CURLY_OPEN) in... (2 Replies)
Discussion started by: lg2013
2 Replies

4. UNIX for Dummies Questions & Answers

Please help to fix awk script

Good morning, fellows. I would need to ask for your help in editing my awk script. Here is the original version: BEGIN { printf ("CRYST1 200.000 200.000 200.000 90.00 90.00 90.00 P 1 1\n") maxatoms=1000 natom=0 found_struct = 0 found_bond = 0 } { if( NF == 5 ) { foundff=0 natom++... (9 Replies)
Discussion started by: snysmumrik
9 Replies

5. Windows & DOS: Issues & Discussions

Fix script error (%%n)

Hi, I'm currently tinkering with a script that uses the for command to process all *.gif files in the current folder. I marked the spot where it exits out with an error by adding a "pause" The error message given is: convert.exe: unable to open image `%x': No such file or directory @... (2 Replies)
Discussion started by: pasc
2 Replies

6. Shell Programming and Scripting

ksh script failed while using -x

Hi, I have a Kshell script that is failed if i am using the -x option. $ cat ListOfFiles.lst \+DATA_DM01/pudwh/datafile/dw_billing_tts_1 \+DATA_DM01/pudwh/datafile/dw_billing_tts_2 ... (2 Replies)
Discussion started by: yoavbe
2 Replies

7. Shell Programming and Scripting

AWK script getting failed

Hi All, Below is my code , In the code below the "If" condition is getting failed. I dont know what is getting wrong here , may be i can not use may logical operator at once or something else OR brackets under If condition are to be organised . Please help!! if ($11 == "0" &&... (1 Reply)
Discussion started by: unknown123
1 Replies

8. Shell Programming and Scripting

script for failed processes

I want to write a script that log all the failed processes and start the same process. For that I have already write a script that gives all the PID #!/bin/ksh pid= `ps -ef |grep "ov" |grep -v "grep"| awk '{print $2}'` echo $pid if ; then echo "process is running" else echo... (4 Replies)
Discussion started by: kumarabhi84
4 Replies

9. Shell Programming and Scripting

how to fix this awk script?

i have a log file while looks like this ++ user_a blabla blabla nas_b blabla user_d this is a user_a junk line another junk line user_c nas_m blabla ++ basically most of the lines contain a "user" keywords, and the rest of the lines do not have "user" at all. So I have the... (17 Replies)
Discussion started by: fedora
17 Replies

10. Shell Programming and Scripting

fix a problem in this script

z=9 i=0 h=02 min=55 while do cat /home/barmecha/test | grep $h:$min >> /home/barmecha/file1 min=`expr $min + 1` if ; then h=`expr $h + 1` fi i=`expr $i + 1` done i have a log file with time wise log in it, this script help me to pull out logs of the give time interval...but the... (8 Replies)
Discussion started by: abhishek27
8 Replies
Login or Register to Ask a Question