Shell Programming and Scripting

Environment:

BASH version: GNU bash, version 3.2.51(1)-release (sparc-sun-solaris2.10)
Copyright (C) 2007 Free Software Foundation, Inc.

OS: Oracle Solaris 10 9/10 s10s_u9wos_14a SPARC
Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved.
Assembled 11 August 2010

Script:

Code:

#!/usr/bin/bash

#-------------------------------------------------
# This sftp's the files to the remote server
#
#load global variables
#----------------------------------------------------------

Code:

DATE=`date +"%d%b%y,%T-"`
NEWER=/users/ACCOUNT/.newer
LOG=/users/ACCOUNT/aly_sftp.log
HOSTIS=`hostname`
EMAIL=account@email.com
SENT=0

#If hostname = production server then use one #account, if it equals anything else use the test account

Code:

if [ $HOSTIS = 'hostname' ]; then
  TOHOST='account@regular.host.com'
 else
 TOHOST='account@test.host.com'
fi

#grab the account used for the transfer and load just the domain name for logging later

Code:

TODOMAIN=`echo $TOHOST|cut -d @ -f2`

#check to see if there are any files named *.txt in the /transfer directory
#see if they are newer that the ~/.newer file and if they are send them via SFTP to $HOSTIS

Code:

for i in `find /transfer -name '*.txt' -newer $NEWER -print`
        do

#sftp any files found, if none found or all sent goto RESULT

Code:

sftp $TOHOST <<RESULT
                cd /inbound/
                lcd /transfer
                put $i
                bye

#make a log entry with a datetime stamp that each file was transmitted

Code:

echo $DATE$i "transmitted to "$TODOMAIN >>$LOG

#for each file sent increment $SENT by 1

Code:

 SENT=$((SENT+1))
RESULT

#If any files are sent email the user that the files were successfully sent else die.

Code:

if [ $SENT != 0 ]
then
        mailx -s "SFTP completed successfully" $EMAIL<$LOG
        echo $DATE"email for SFTP completed successfully sent">>$LOG
        touch -a -m $NEWER
        SENT=0
else
        touch -a -m $NEWER
        echo $DATE$NEWER "touched">>$LOG
fi
done

So this has been giving me fits and I just can't figure it out. I am sure it's a rookie mistake but I have been staring at it too long and can't find it. The bit I am having trouble with is the SENT variable increment and using to determine which part of the if statement to execute.

Doesn't matter how I change it SENT=0 when it gets to the second if statement and it always executes the first condition rather than the second.

It has something to do with global vs local variables I think but I can't figure out how to correctly configure it.

Any teaching would be appreciated.

Hi,

Code:

echo $DATE$i "transmitted to "$TODOMAIN >>$LOG
SENT=$((SENT+1))

is inside the here-document. It should be after the closing RESULT label


--
It also helps if the indenting is done correctly. BTW..

Given my edit, does your comment still hold true?

if so, wouldn't $SENT always increment by 1 even if there were no files sent?

If that's the case, how would I code for that condition, basically what I am trying to do is keep track of whether files were sent and then send an email to the user notifying them of such else die.

and I'd welcome an example of "proper indention"

Thanks for the input.

Yes my comment still holds true. Right now, $SENT will never be incremented, It needs to be placed outside the here document, and you would need to test if it can be incremented..

so after YOU got $SENT incrementing, it still wouldn't send. Turns out the problem was the conditional was incorrectly stated for some reason rather than -eq or == I had to use !=.

also in this iteration it will send an email for EACH file. How could I set it up for sending only one file for all files at the end of the loop?

thanks again.