need help on "if else" issue


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting need help on "if else" issue
# 1  
Old 10-08-2012
need help on "if else" issue

Hi,
I am trying to read lines from a file and check if the length is correct. But the test condition in if has some issues and I am not able to figure out, what the problem is?
Kindly help me with this issue.

I am using bash shell.
Code:
 while read line
  do
   len=${#line}

  if[ [ "$len" -ne 53 ] ];then
     echo "wrong"
     exit 1
   else
     echo "Perfect"
   fi
  done <"$filename"

# 2  
Old 10-08-2012
Quote:
Originally Posted by babom

Code:
 while read line
  do
   len=${#line}

  if [[ "$len" -ne 53 ]];then
     echo "wrong"
     exit 1
   else
     echo "Perfect"
   fi
  done <"$filename"

Space not required between square brackets..
try now..
# 3  
Old 10-08-2012
I still have issues even after the spaces where removed.
# 4  
Old 10-08-2012
Try this :

Code:
$: cat text.txt | while read line
> do
> len=${#line}
> if [ "$len" -ne 53 ]; then
> echo "wrong"
> exit 1
> else
> echo "Perfect"
> fi
> done
wrong
$:

It surely works. In your original code you may have 2 mistakes :
1) you do not need double square brackets "[["
2) you need a space between "if" and "["

However it would be useful to post also the error you encounter.
Obviously text.txt will be replaced with your file (and its respective absolute path if necessary)
This User Gave Thanks to black_fender For This Post:
# 5  
Old 10-08-2012
It worked after I added a space after if.

Thanks a lot.
# 6  
Old 10-08-2012
Quote:
Originally Posted by babom
I still have issues even after the spaces where removed.
Actually in my previous post itself i have already edited your code and posted there. But i think you have not tried that. See post 2. Copy and then execute the code.Smilie
Login or Register to Ask a Question

Previous Thread | Next Thread

9 More Discussions You Might Find Interesting

1. AIX

Apache 2.4 directory cannot display "Last modified" "Size" "Description"

Hi 2 all, i have had AIX 7.2 :/# /usr/IBMAHS/bin/apachectl -v Server version: Apache/2.4.12 (Unix) Server built: May 25 2015 04:58:27 :/#:/# /usr/IBMAHS/bin/apachectl -M Loaded Modules: core_module (static) so_module (static) http_module (static) mpm_worker_module (static) ... (3 Replies)
Discussion started by: penchev
3 Replies

2. Shell Programming and Scripting

Bash script - Print an ascii file using specific font "Latin Modern Mono 12" "regular" "9"

Hello. System : opensuse leap 42.3 I have a bash script that build a text file. I would like the last command doing : print_cmd -o page-left=43 -o page-right=22 -o page-top=28 -o page-bottom=43 -o font=LatinModernMono12:regular:9 some_file.txt where : print_cmd ::= some printing... (1 Reply)
Discussion started by: jcdole
1 Replies

3. UNIX for Dummies Questions & Answers

Using "mailx" command to read "to" and "cc" email addreses from input file

How to use "mailx" command to do e-mail reading the input file containing email address, where column 1 has name and column 2 containing “To” e-mail address and column 3 contains “cc” e-mail address to include with same email. Sample input file, email.txt Below is an sample code where... (2 Replies)
Discussion started by: asjaiswal
2 Replies

4. Solaris

The slices "usr", "opt", "tmp" disappeared!!! Help please.

The system don't boot. on the screen appears following: press enter to maintenance (or type CTRL-D to continue)...I checked with format command. ... the slices "0-root","1-swap","2-backup" exist. ...the slises "3-var","6-usr" -unassigned. :( (16 Replies)
Discussion started by: wolfgang
16 Replies

5. Shell Programming and Scripting

""Help Me!""Beginner awk learning issue

Hi All, I have just now started learning awk from the source - Awk - A Tutorial and Introduction - by Bruce Barnett and the bad part is that I am stuck on the very first example for running the awk script. The script is as - #!/bin/sh # Linux users have to change $8 to $9 awk ' BEGIN ... (6 Replies)
Discussion started by: csrohit
6 Replies

6. Shell Programming and Scripting

how to use "cut" or "awk" or "sed" to remove a string

logs: "/home/abc/public_html/index.php" "/home/abc/public_html/index.php" "/home/xyz/public_html/index.php" "/home/xyz/public_html/index.php" "/home/xyz/public_html/index.php" how to use "cut" or "awk" or "sed" to get the following result: abc abc xyz xyz xyz (8 Replies)
Discussion started by: timmywong
8 Replies

7. Shell Programming and Scripting

awk command to replace ";" with "|" and ""|" at diferent places in line of file

Hi, I have line in input file as below: 3G_CENTRAL;INDONESIA_(M)_TELKOMSEL;SPECIAL_WORLD_GRP_7_FA_2_TELKOMSEL My expected output for line in the file must be : "1-Radon1-cMOC_deg"|"LDIndex"|"3G_CENTRAL|INDONESIA_(M)_TELKOMSEL"|LAST|"SPECIAL_WORLD_GRP_7_FA_2_TELKOMSEL" Can someone... (7 Replies)
Discussion started by: shis100
7 Replies

8. Shell Programming and Scripting

cat $como_file | awk /^~/'{print $1","$2","$3","$4}' | sed -e 's/~//g'

hi All, cat file_name | awk /^~/'{print $1","$2","$3","$4}' | sed -e 's/~//g' Can this be done by using sed or awk alone (4 Replies)
Discussion started by: harshakusam
4 Replies

9. UNIX for Dummies Questions & Answers

Explain the line "mn_code=`env|grep "..mn"|awk -F"=" '{print $2}'`"

Hi Friends, Can any of you explain me about the below line of code? mn_code=`env|grep "..mn"|awk -F"=" '{print $2}'` Im not able to understand, what exactly it is doing :confused: Any help would be useful for me. Lokesha (4 Replies)
Discussion started by: Lokesha
4 Replies
Login or Register to Ask a Question