Shell Programming and Scripting

This still produces 0

Post the shell and os you are using.

And also the exact script you are running.

Just to alert you

the quotes in

L=`expr $L + 1`

are backticks. The one found above the TAB key on your keyboard.

Vino

@pixelbeat: correct! There is a difference between "$l" (lowercase L) and "$L" (uppercase L) the OP seems not to be aware of.

Another error is the line:

Code:

 L='expr $1 + 1'

Apart from the fact that "expr" shouldn't be used any more and that it should be replaced by "(( .... ))" "L" is set to some value given at the commandline (the "$1") increased by 1. Since the value of the commandline doesn't change it gets set to the same value over and over again

bakunin

#!/bin/sh

L=0

while read line
do

L=`expr $L + 1`
echo $L

done < dinseh.sql

echo $L

I think pixelbeat is right.
In this case, most of shell folks a subshell to run the loop block.
try ksh.

Another distant possibility

Code:

--dinseh.sql is empty--

What does

Code:

wc -l <dinseh.sql

give ?

Vino

At least you last version should be working.

Still there are some things to say about:

/switches ranting, style-aficionado mode on

Don't use the backticks any more, this is outdated style and not necessary in the Korn shell. If you want to execute a command, then put the output of that command into a variable instead of

Code:

 x=`command`

use

Code:

 x="$(command)"

Second, instead of "expr" or "let" you should use the "(( .. ))" construct, which is easier to read and encouraged by David Korn. Instead of

Code:

 x=$(expr $x + 1)
and
let x=1

better write:

Code:

 (( x = x + 1)) or (( x+= 1 ))
and
(( x = 1  ))

Yes, I already know i can be a PITA, no neeed to point that out. ;-))

/switches ranting mode off, reverting back to a humble person

bakunin