Shell Programming and Scripting

The problem is that ftp is not well suited for batch use.

IMHO there are two possible options you have: instead of directly feeding the answers to ftp create a .netrc file and put the filenames, hostname, etc. there. Only then call ftp <hostname> and ftp will proceed from there. The .netrc file could be created by the script prior to the call of ftp.

The other (IMHO more elegant) solution is to use rcp (or its securified pendant scp) instead of ftp. rcp comes in two variations, kerberized and not kerberized, so be careful what you use. Additionally I'd like to recommend scp since it communication can't be traced. (The same is true for ssh as a replacement for telnet/rlogin.) The drawback is you have to install the system once and exchange keys between the machines every once in a while.

Hope this helps

bakunin

OK. I have revised the script using the "co-process" technique I got from this forum. I tried this one on our test
environment and it work on multiple files. My questions are
1. Using the exec 4>&1, will this not affect other parts of the script that calls this script?
2. This sub script is called from multiple scripts that runs every hour (to download ORD file to the other system (WMS).
3. Is this code OK to use? I am new in Unix scripting and not sure if it is ok......

Thanks a lot!

#!/bin/ksh
# =============================================================================================
# Script name : ftpcheck.ksh
# Description : This script will be called from release.ksh and wmsupld.ksh and other
# WMS script to ftp ORD file from ERP to WMS and then check if
# the ftp was successfull or not. Also, check if the header count of ORD
# file (HD record) matches with the total file count (wc -l)
#==============================================================================================
. /glo71sw/pro4bin/crondevl716
DIRSCRIPT=$PRODATA/scripts
cd $PRODATA
ORDDOWNLD=`ls ORD????.DLD`
# use test data....
ORDDOWNLD='ORD8705.DLD ORD8706.DLD ORD8707.DLD'
export ORDDOWNLD
echo $ORDDOWNLD

# ftp information
HOST_FTP=host
USER_FTP=admin
PASSWD_FTP=pass

exec 4>&1
ftp -nv >&4 2>&4 |&

print -p open $HOST_FTP
print -p user $USER_FTP $PASSWD_FTP
print -p ascii

for i in $ORDDOWNLD
do
# transfer ORD files one by one......
print -p put $i
print -p get $i J$i
done
print -p bye
wait

# Verify if ORD files processed are OK.

for i in $ORDDOWNLD
do

# after getting the file, make sure header count is correct.
TOT_CNT=`cat J$i | wc -l`
TOT_HD=`cat J$i | grep "HD" | cut -c17-25`
# Compare total lines with total count in HD record
echo "J$i : Total Rec Count = $TOT_CNT Total HD count = $TOT_HD" >> jgo.log
if [ $TOT_CNT -eq $TOT_HD ]
then
echo "J$i has equal record count and HD count" | elm -s"Record check - J$i
" email
else
echo "J$i has incorrect HD count" | elm -s"Incorrect HD count - J$i" email
fi

# Compare if the HD transferred is the same.....
diff -h X$i J$i > J$i.out

# "-s" checks if the file is existing and size is greater than 0. So
# a true status would mean there are differences between the files...

if [ -s J$i.out ]
then
cat J$i.out | elm -s"WMS file - $i - NOT EQUAL" email
else
cat J$i.out | elm -s"WMS file - $i - EQUAL" email
fi
rm J$i.out
done
# ================enf of script ftpcheck.ksh===========================

It will not affect the calling script. Not sure what you mean by ok to use. I wrote the script you copied and placed it in the public domain. So it's free to use if that's what you mean.

Thanks Perderabo!

What I meant about my code, if it is ok, is, if I coded it correctly. or there is a better way of coding it. A friend of mine suggested to use perl but if this code is ok, why use perl (i am not familiar with perl )