Shell Programming and Scripting

Hi all

I am inserting record in oracle database using shell script. When the sql part is directly written in the shell script the record is getting inserted. But when the same piece of code is added into a function, I am getting an error while execution "line 45: syntax error: unexpected end of file".

The file is containing only 44 lines of code.

The function which is called from a main function in which the code for insert is written is as follows. When the entire SQL section is removed from the function the program executes properly.

Any suggestions/inputs would be great help.

TIA

Code:

add () 
{
                    sqlplus -s "custom/custom"<<EOF
insert into name_list values ('$f_name','$l_name');
exit
EOF
 
if [ $? -ne 0 ]; then 
echo "Error in insertion"
add;
             else 
echo -e "\nRecord added successfully... Do you wish to add more(y/n) \c"
read choice
 
if [ $choice == "y" ]; then
add ;
else 
clear
main ;
fi
fi
}

Misread, sorry, ignore the post.

When you get an error message, please post the error message verbatim.

That error message type usually means that there are extra characters (e.g. space characters) on the same line as the terminating EOF, or if that string EOF is in any way indented.
It can be caused if the script has been edited with a Microsoft editor such as notepad which introduces spurious carriage-return characters.

The script segment as posted is sort of sound but the logic and structure is dubious because the functions can call themselves. We need to see the whole script.

The error message i have written is precise. As i stated the same section of code (sqlplus ... << EOF to EOF) when used as an independent script is inserting values and if this is section is removed from the script the execution is successful.

Following is the entire script

add ()
{

sqlplus -s "custom/custom"<<EOF
insert into name_list values ('$f_name','$l_name');
exit
EOF

if [ $? -ne 0 ]; then

echo "Error in insertion"
add;

else

echo -e "\nRecord added successfully... Do you wish to add more(y/n) \c"
read choice

if [ $choice == "y" ]; then

add ;

else

clear
main ;

fi

fi

}

function main
{

echo -e "\t----------- database"
echo -e "\t****************"
echo -e "\n"
echo -e "1) Add"
echo -e "2) View"
echo -e "3) Delete"
echo -e "4) Exit"
echo -e "\nEnter your choice: \c"
read choice
case $choice in
1) add ;;
*) echo "awaited" ;;
esac

}
main ;

The "EOF" ending your here document should be at the very front of the line. I suspect the shell never finds the end of your here document as a result of it being indented.

P.S. consider using the "select" construct for creating a menu. Also I don't think you are gaining anything by putting main into a function. If your intention is to put it in a while loop eventually to repeat the menu, have a look here it may help you:
https://www.unix.com/unix-dummies-que...#post302606268

Remove the whitespace before 'EOF'.

Thanks... The whitespaces before EOF were the problem.