Shell Programming and Scripting

what error message you are getting ?

---------- Post updated at 08:03 PM ---------- Previous update was at 07:58 PM ----------

make sure, your file should have only the servername

Thanks itkamaraj for the help!

It works partially, i see only the first server with the details in the output file.

The hosts.list file has servers listed in one column like below:

server1
server2
server3
...and so on

Right now, its showing me only the server1 details with the uptime. Can you please help where i can see all 50 servers? Thanks in advance!

Code:

SERVERS=$(cat /tmp/hosts.list)
for i in $SERVERS;
do 
uptime=$(ssh $i uptime)
echo "$i $uptime" >> output.txt
done

This looks like an DNS issue. You can add an entry of the servers that you are trying to ssh in the /etc/hosts.

My suggestion was not a skeleton or pseudocode, I expected it to work as-is and you didn't need to modify it to add extra loops. It already had a loop which read servers from your server file one by one and fed them into ssh individually. Did you try my original, unmodified code?

$server_list is a file, therefore, 'for x in $server_list' makes no sense. You read from files.

Code:

server_list='/tmp/hosts.list'

while read SERVER
do
    /usr/local/bin/ssh "$SERVER" printf "${SERVER} : " ';' uptime
done < $server_list

Thanks itkamaraj for the help! I made little changes to the script where the contents of the output.txt are being to my email address. So far everything works perfectly.

Code:

TODAY=`date "+%Y%m%d"`
export TODAY

SERVERS=$(cat /tmp/hosts.list)
for i in $SERVERS;
do 
uptime=$(ssh $i uptime | cut -f1 -d",")
echo "$i $uptime" >> uptimes_${TODAY}.txt
done

cat uptimes_${TODAY}.txt | mailx -s "Uptimes for `date`" myemail@email.com

I am also trying to think of implementing the following.
If i run the script through crontab on Monday morning, i would like the script to print only the servers who have been up for more than one day, this way only the servers that didnt get rebooted will be mailed to my email address. Any thoughts on how i should be handling? Really appreciate all your help so far.
Cheers!