Login or Register to Ask a Question and Join Our Community


Shell Programming and Scripting

Can someone please help me optimize my code (script searches subdirectories)?

Login to Discuss or Reply to this Discussion in Our Community

 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Can someone please help me optimize my code (script searches subdirectories)?
# 8  
Old 03-15-2012
Perhaps you can try if this works instead of the grep -r:
Code:
find /path/to/files -type f -exec grep -Filwf input.txt {} \; > output.txt

# 9  
Old 03-15-2012
Quote:
Originally Posted by Scrutinizer
Perhaps you can try if this works instead of the grep -r:
Code:
find /path/to/files -type f -exec grep -Filwf input.txt {} \; > output.txt

this sort of works. The input file contains phrases found in multiple files under multiple directories. So with your code, I'd just get one large file with just the output and wouldn't know where one entry finishes and another starts. Guess I could modify it a bit.
# 10  
Old 03-15-2012
Quote:
Originally Posted by jl487
this sort of works. The input file contains phrases found in multiple files under multiple directories. So with your code, I'd just get one large file with just the output and wouldn't know where one entry finishes and another starts. Guess I could modify it a bit.
That is how I interpreted the first post:
Quote:
Originally Posted by jl487
[..]The output is a file (output.txt) that shows only the file names that contains the searched keyword.[..]
Can you specify what you are after?
# 11  
Old 03-15-2012
right now, my script works, but it takes roughly 3 hours to run. I'd like to feed in an input files containng a list of phrases. Those phrases are found in several files in multiple directories. Right now, my output looks like the following:

"SEARCHED TERM" is linked to the following:
/path/to/file1.txt
/different/path/to/file2.txt
/another/path/to/file2.txt
# 12  
Old 03-15-2012
Does your grep have a -o option? What OS are you using?
# 13  
Old 03-15-2012
-o switch is not avaiable. I am running on an AIX machine.
# 14  
Old 03-15-2012
Which version ? Do you have a -H option?
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Help Optimize the Script Further

Hi All, I have written a new script to check for DB space and size of dump log file before it can be imported into a Oracle DB. I'm relatively new to shell scripting. Please help me optimize this script further. (0 Replies)
Discussion started by: narayanv
0 Replies

2. Shell Programming and Scripting

Optimize awk code

sample data.file: 0,mfrh_green_screen,1454687485,383934,/PROD/G/cicsmrch/sys/unikixmain.log,37M,mfrh_green_screen,28961345,0,382962--383934 0,mfrh_green_screen,1454687785,386190,/PROD/G/cicsmrch/sys/unikixmain.log,37M,mfrh_green_screen,29139568,0,383934--386190... (7 Replies)
Discussion started by: SkySmart
7 Replies

3. Shell Programming and Scripting

Looking to optimize code

Hi guys, I feel a bit comfortable now doing bash scripting but I am worried that the way I do it is not optimized and I can do much better as to how I code. e.g. I have a whole line in a file from which I want to extract some values. Right now what I am doing is : STATE=`cat... (5 Replies)
Discussion started by: Junaid Subhani
5 Replies

4. Shell Programming and Scripting

Optimize my mv script

Hello, I'm wondering if there is a quicker way of doing this. Here is my mv script. d=/conversion/program/out cd $d ls $d > /home/tempuser/$$tmp while read line ; do a=`echo $line|cut -c1-5|sed "s/_//g"` b=`echo $line|cut -c16-21` if ;then mkdir... (13 Replies)
Discussion started by: whegra
13 Replies

5. Shell Programming and Scripting

pl help me to Optimize the given code

Pl help to me to write the below code in a simple way ... i suupose to use this code 3 to 4 places in my makefile(gnu) .. **************************************** @for i in $(LIST_A); do \ for j in $(LIST_B); do\ if ;then\ echo "Need to sign"\ echo "List A = $$i , List B =$$j"\ ... (2 Replies)
Discussion started by: pk_arun
2 Replies

6. Shell Programming and Scripting

Optimize shell code

#!/usr/bin/perl use strict; use warnings; use Date::Manip; my $date_converted = UnixDate(ParseDate("3 days ago"),"%e/%h/%Y"); open FILE,">$ARGV"; while(<DATA>){ my @tab_delimited_array = split(/\t/,$_); $tab_delimited_array =~ s/^\ =~ s/^\-//; my $converted_date =... (2 Replies)
Discussion started by: sandy1028
2 Replies

7. Shell Programming and Scripting

Optimize and Speedup the script

Hi All, There is a script (test.sh) which is taking more CPU usage. I am attaching the script in this thread. Could anybody please help me out to optimize the script in a better way. Thanks, Gobinath (6 Replies)
Discussion started by: ntgobinath
6 Replies

8. UNIX for Dummies Questions & Answers

Can we optimize this simple script ?

Hi All , I am just a new bie in Unix/Linux . With help of tips from 'here and there' , I just created a simple script to 1. declare one array and some global variables 2. read the schema names from user (user input) and want2proceed flag 3. if user want to proceed , keep reading user... (8 Replies)
Discussion started by: rajavu
8 Replies

9. Shell Programming and Scripting

optimize the script

Hi, I have this following script below. Its searching a log file for 2 string and if found then write the strings to success.txt and If not found write strings to failed.txt . if one found and not other...then write found to success.txt and not found to failed.txt. I want to optimize this... (3 Replies)
Discussion started by: amitrajvarma
3 Replies

10. News, Links, Events and Announcements

New Tool Searches and Replaces SCO Code

See this article: http://story.news.yahoo.com/news?tmpl=story&cid=74&ncid=738&e=9&u=/cmp/20030809/tc_cmp/13000487 (3 Replies)
Discussion started by: Neo
3 Replies
Login or Register to Ask a Question