Help with KSH script:


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Help with KSH script:
# 1  
Old 01-19-2012
Help with KSH script:

i have the following script:

Code:
# Get user pid
UserPID=$($REMSH $Machine "ps -ef | grep $UserID | grep txrx | grep -v 'grep'" | awk '{print $2}')
if [[ $UserPID = "" ]]
then
	clear 
	print ""
	print "   User $UserID on host $Machine was not in Debtor's Enquiry"
	print ""
	print "   No action taken"
	print ""
	print "   Check that you have entered the users details correctly "    
	print ""
	print "   Check with the user - they may not now be stuck in Debtor's enquiry"
	print "Specified user and host not in Debtors" >>  /home/killdebt/kd.log
	exit 1
fi

ShellPID=$($REMSH $Machine "ps -futxrx | grep $UserPID | grep 'sh -c' | grep -v 'grep'" | awk '{print $2}')
KSHLine=$($REMSH $Machine "ps -ef | grep $ShellPID | grep txrx | grep ksh |grep getslacc |grep viewpoint| grep -v 'grep'")
if [[ $KSHLine = "" ]]
then
        clear
        print ""
        print "   Program error - in kill debtors - ring Michael Crofts x4591"
        print ""
	print "   Process to be killed did not look a Debtor's Enquiry process"   
        print ""
	print "   Process to be killed did not look a Debtor's Enquiry process" >>  /home/killdebt/kd.log
        print ""
        print "KSHLine equels null!" >> /home/killdebt/kd.log
	exit 1
fi

KSHPID=$(print $KSHLine | awk '{print $2}')
$REMSH $Machine "kill -9 $KSHPID"

this is called from a users .profile by the following command:

Code:
su  txrx -c "/home/killdebt/kd $Machine $UserID"

however i get the following output on my screen? can anyone explain the reason why?

Code:
sh: 4755: not found
sh: 77: not found
sh: 4771: not found
sh: 4774: not found
sh: 4756: not found
sh: 4775: not found
sh: kill: no such process


Many Thanks in advance!
# 2  
Old 01-19-2012
There is a lot wrong with this script. The running theme is that you must get into the habit of putting double quotes round string variables whether or not you think you need them.

Please can you show some sample lines from your "ps" command (with headings) showing example processes which you want to kill.
Please post your Operating System and version.


The main visible coding error is illustrated with this one-line script:
Code:
#!/bin/ksh
myvar=1 2 3 4

./myscript
./myscript[2]: 2:  not found

There are a lot more miscellaneous problems. This line (and another line like it) will give a fatal syntax error if $KSHline is blank.
Quote:
if [[ $KSHLine = "" ]]
Try
Code:
if [[ "${KSHLine}""X" = "X" ]]


Assuming $REMSH contains "remsh", each of the lines should have the syntax:
Code:
remsh "${Machine}" -n "commands"

i.e. The "-n" switch was missing. This switch will save you all sorts of hassle when scripting "remsh".


The script itself has design errors which can no doubt be mitigated with better use of the "ps" command (when we know what version of "ps" we have here).

Last edited by methyl; 01-19-2012 at 02:09 PM..
# 3  
Old 01-20-2012
Great, thanks for your reply i will post further details tommorow once i have access again to the script, posting this from home so dont currently have access.

Many Thanks

---------- Post updated 20-01-12 at 07:44 AM ---------- Previous update was 19-01-12 at 10:10 PM ----------

Hi,

we are using Solaris 10,

here are some example outputs from the individual PS commands,

Code:
REMSH $Machine "ps -ef | grep $UserID | grep txrx | grep -v 'grep'" | awk '{print $2}'

remsh moon-2 "ps -ef | grep aljt | grep txrx | grep -v 'grep'" | awk '{print $2}'

(I have substituted values where necessary)

the results are as follows - Please ignore the fact i am allready on moon-2 as this is a test box and i do not have another one that i can easily remsh too...

Code:
moon-2 $ remsh moon-2 "ps -ef | grep aljt | grep txrx | grep -v 'grep'"

which results in:
Code:
aljt 16058 13019   0 07:21:53 pts/2       0:00 /bin/sh -c su txrx -c "/home/db31/scripts/getslacc viewpoint 7023R02"

then

Code:
$REMSH $Machine "ps -futxrx | grep $UserPID | grep 'sh -c' | grep -v 'grep'" | awk '{print $2}'

remsh moon-2 "ps -futxrx | grep 16058 | grep 'sh -c' | grep -v 'grep'"

which results in:

Code:
    txrx 13085 13084   0 07:21:53 pts/2       0:00 sh -c /home/db31/scripts/getslacc viewpoint 7023R02

i then do the last PS command as follows:

Code:
$REMSH $Machine "ps -ef | grep $ShellPID | grep txrx | grep ksh |grep getslacc |grep viewpoint| grep -v 'grep'"

remsh moon-2 "ps -ef | grep 16060 | grep txrx | grep perl | grep getslacc | grep viewpoint | grep -v 'grep'"

which produces the following line:

Code:
txrx 16061 16060   0 07:31:30 pts/2       0:00 /usr/local/bin/perl /home/db31/scripts/getslacc viewpoint 7023R02


i will also revise the whole code now to what you suggested.

a link to the full script is as follows:

http://jt-sol.co.uk/kd.txt
# 4  
Old 01-23-2012
Any further with this mate??
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Script to replace lines in ksh Script

Hi All, I am novice to Unix and I need your expert advice for the below task. There is a KSH script file in which I need to replace few line as per the below expectations. So my file look like as # Host Setup Command: Line 1 Line 2 Line 3 Line 4 Line Any... (6 Replies)
Discussion started by: rupid0609
6 Replies

2. Shell Programming and Scripting

Deploy ksh script to file from other script

Hi all, I need to deploy two scripts on around ~100 machines and have only OPSware. Opsware have the option to execute a script, so I am trying to write a script which dose cat > script.ksh <<EOF script to be deployed EOF However the script between the two EOFs gets also executed which... (0 Replies)
Discussion started by: click
0 Replies

3. Shell Programming and Scripting

Help Create dynamic ksh script from a script

I am currently running 2 scripts to gather data for a 3rd script and would like to combine the 2 scripts into one. Having issues with the final output format. Note cannot post URL so replaced the http stuff with (name) in the examples All scripts contain #!/bin/ksh OS = Red Hat Enterprise... (0 Replies)
Discussion started by: pcpinkerton
0 Replies

4. Shell Programming and Scripting

KSH script to run other ksh scripts and output it to a file and/or email

Hi I am new to this Scripting process and would like to know How can i write a ksh script that will call other ksh scripts and write the output to a file and/or email. For example ------- Script ABC ------- a.ksh b.ksh c.ksh I need to call all three scripts execute them and... (2 Replies)
Discussion started by: pacifican
2 Replies

5. Shell Programming and Scripting

passing a variables value from the called script to calling script using ksh

How do i get the value of the variable from the called script(script2) to the calling script(script1) in ksh ? I've given portion of the script here to explain the problem. Portion of Script 1 ============= ----- ----- tmp=`a.ksh p1 p2 p3` if then # error processing fi -----... (10 Replies)
Discussion started by: rajarkumar
10 Replies

6. Shell Programming and Scripting

import var and function from ksh script to another ksh script

Ih all, i have multiples ksh scripts for crontab's unix jobs they all have same variables declarations and some similar functions i would have a only single script file to declare my variables, like: var1= "aaa" var2= "bbb" var3= "ccc" ... function ab { ...} function bc { ... }... (2 Replies)
Discussion started by: wolfhurt
2 Replies

7. Shell Programming and Scripting

tracing a ksh script within a ksh script

I normally trace a script with the ksh -x <script name> and redirect strderr to file. But if you have a script like the examble below...... vi hairy bear=`grep bear animals` if then ksh more_animals fi If I ksh -x hairy it won't trace "more_animals" unless I put a -x in it. Is... (1 Reply)
Discussion started by: shorty
1 Replies

8. Shell Programming and Scripting

how to convert unix .ksh script to windows .batch script

I am using awk in my .ksh script but when I am trying to run in windows its not recognising awk part of the ksh script , even when I changed it to gawk it does not work, this is how my .ksh and .bat files look like. thanx. #!/bin/ksh egrep -v "Rpt 038|PM$|Parameters:|Begin |Date: |End... (1 Reply)
Discussion started by: 2.5lt V8
1 Replies

9. Shell Programming and Scripting

executing a ksh script from another ksh script

Hi, I'm new to unix scripting.How can i call a script from another script. I have a.ksh and b.ksh .I have to call b.ksh from a.ksh after it is successfully exceuted. I tried using #!/bin/ksh -x in a.ksh and at the end i have used /path/b.ksh My problem is it is executing only a.ksh.it... (6 Replies)
Discussion started by: ammu
6 Replies

10. UNIX for Dummies Questions & Answers

SQL Script run in KSH Script

I've got a SQL script that is executed through a UNIX ksh script. It is working fine, but I wanted to add a line to put a date/time stamp in the log file that it generates. This is more of a SQL question, but I'm hoping someone can help me get the date/time...I've changed the script with the... (2 Replies)
Discussion started by: dstinsman
2 Replies
Login or Register to Ask a Question