Shell Programming and Scripting

I am developing a script to maintain 'n' number of versions of a file. The script will take a filename as a parameter and the number of versions to maintain. This basically does something like a FIFO. Here is what I developed. But something is not right. I have attached the script. Can u pls help here?

why not use logrotate?

As jeffsaxton stated logrotate does this (and lots more). So if it's available on your system it's worth learning how to configure and use it.

However, if it's not available and you cant get it installed, ive had a quick look at your script and identified these issues:

1) function fDisplayHelp is missing, this should probably print usage information (or help when $1=h) and exit.
2) No test for script being is called without -s or -n parameters, which have no defaults and so should be required options.
3) Script requires the service that writes to the log files to be stopped (as you cant move logs out from underneath a running process)

For 2) - Add following test after getopts processing:

Code:

[ -z "${sLogCnt}" ] && print -u2 "Option -n <cnt> is required" && fDisplayHelp "u"
[ -z "${sScpt}" ] && print -u2 "Option -s <script> is required" && fDisplayHelp "u"

For 3) - This is most likley what you mean by "something is not right".
Ensure you stop the service before calling your rotate script (and restart it after the script has moved the files).