Yes, as mentioned by scottn, please do ask a question. Give us some more information to work on. What do you expect to happen? What is in fact happening?
I will just answer some random questions, maybe I hit the target by shooting in the dark :-)
From the script below what I notice:
I would run the script in ksh, particularly for the cat $FILE | read X construct. You should also google "uuoc".
And regarding the use of "test", Unless you plan on porting the script to some other strange shell, rather use [ $? = 0 ]
In terms of general coding, I could suggest that when piping inside a loop of if-else structure, then you could also do it outside, as in this case
Code:
while read HOST
do
command | grep | whatever
done
can be done as
Code:
while read HOST
do
command
done | grep | whatever
The same with the if
Code:
if XXX
then
command | tee XYZ
else
othercommand | tee XYZ
fi
could be done as
Code:
if XXX
then
command
else
othercommand
fi | tee XYZ
If you want to simplify the script, you can combine the grep and the awk, eg
In stead of using "more" in a script and piping it to another command, use "cat", and instead of using cat, use <$FILE (google uuoc again)
Some of this is just about simplifying the script. Some of it is about coding habits. Some of it is about efficiency. All of these things together makes it easier to pinpoint why scripts fail, even when they don't directly solve the problem!
Hello,
I have the following script that just archives and clears some log files.
#!/bin/bash
# script: archive_logs_and_clear
# add date to logfile names and copy archive directory
# clear logs
# change to script directory
cd ... (4 Replies)
Hi,
I am running below script using autosys.
Though the script is running fine, it fails the workflow but the autosys job shows success.
Can you please let me know where can i make change to script:-
#!/bin/ksh
#to test mail from directory
set -x
frequency=$1
param_file=/local/test... (4 Replies)
I developed a script to group by 1st column and sum few of the column which are required, but while executing sum of 2nd column which has decimals in place is not getting correct sum. below is the script
awk -F, '{a+=$2;b+=$33;c+=$58;d+=$11;e+=$50;}END{for(i in a)printf... (2 Replies)
I am trying to run a script which ftp the files from one server to another.
Below is the script -
#!/bin/bash
echo "Please enter no : "
read variable
echo "You entered: $input_variable"
host=xxxxx
USER=xxx
PASSWORD=xxx
ftp -inv $HOST <<EOF
user $USER $PASSWORD
cd... (4 Replies)
Hi,
I have a script which when i run in manually it runs properly, but when i run the same script using UC4 scheduler it dose not run properly.
Below is the code i am using. i am not sure what is happening when i run this through UC4 the files are not generated. but when i run this manually it... (1 Reply)
Hi Folks,
I am going through a sample script which is not working.
Also i want to understand the certain syntaxes
#!/bin/sh
clear
x="y"
echo "enter ur 1st no."
read n1
echo "enter ur 2nd no."
read n2
while
do
clear
echo "1.sum"
echo "2.subtraction"
echo "3.product"... (3 Replies)
Hello All,
I am ruuning the below script.
userchecking.sh
###########################
#! /bin/ksh
NIS_SCRIPT_HOME="/mot/systems/NIS_SCRIPT_NEW"
. $NIS_SCRIPT_HOME/common.env
WORK_DIR="/mot/systems/scripts/"
#WORK_DIR="/mot/b36376/myscripts/nis_user_automation"... (1 Reply)
#!/bin/ksh
set -x
SQLSTR="LOGIN/PASSWORD"
sqlplus -s ${SQLSTR} @<<EOF
set pagesize 0 feedback off verify off heading off echo off;
UPDATE TABLE NAME
SET VALUE = VALUE + 1
where VALUE2 = 'ABCDE';
exit;
COMMIT;
EOF
i am not able to update the column and not able to exit from sqlplus. ... (7 Replies)
I am working on a script that checks two arguments at the command line. The first argument is a search pattern, the second can be a file or a directory, if it is a file a second script is called that checks it for the search pattern. If the second argument is a directory, it checks for the search... (5 Replies)
09-26-2011
Script Issue