Login or Register to Ask a Question and Join Our Community


Shell Programming and Scripting

script help Undefined /illegal variable using cat

Login to Discuss or Reply to this Discussion in Our Community

 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting script help Undefined /illegal variable using cat
# 1  
Old 06-20-2011
script help Undefined /illegal variable using cat
Hello group,

Still fairly new at the whole scripting thing so be gentle. I'm trying to write a simple script that archives my log files into a master log broken into weeks of the year.

My script runs fine up till the "cat" lines which I get a undefined or illegal variable name error. But using the same format earlier in the script it has no problem with the makedir or touch lines with the dates in them.

I have fiddled with it & had no luck, can someone eyeball this and tell me what I have done wrong? This is on a freenas system using a version of freebsd which is why I have the kooky copy lines instead of just echoing "" to the logs, which seemed to break syslog.

TIA
DP

Code:
#/bin/bash
#by DP run as ROOT!
#
#  make directory in format week number-year.month-year-logs
#
mkdir /var/log/archives/'week-'$(date +%U'.'%B'-20'%y'-logs')
#
# touch new archived logs
touch /var/log/archives/'week-'$(date +%U'.'%B'-20'%y'-logs')/sshd.log
touch /var/log/archives/'week-'$(date +%U'.'%B'-20'%y'-logs')/system.log
#
#stop syslogd deamon
/etc/rc.d/syslogd stop
#
#copy sshd & system log to monthly directory
cat /var/log/sshd.log >> /var/log/archives/'week-'$(date +%U'.'%B'-20'%y'-logs')/sshd.log
cat /var/log/system.log >> /var/log/archives/'week-'$(date +%U'.'%B'-20'%y'-logs')/system.log
#
#copy clean sshd & system log file to clear logs
cp /var/log/clean/sshd.clean.log /var/log/sshd.log
cp /var/log/clean/system.clean.log /var/log/system.log
#
#
#restart syslogd
/etc/rc.d/syslogd start
#
# log results
logger SYSTEM "Daily rotation of SSH & System logs was successful stored in /var/log/week-"$(date +%U'.'%B'-20'%y'-logs')
#
# EOF

Last edited by pludi; 06-20-2011 at 05:42 PM..
# 2  
Old 06-20-2011
Hi, the shebang is missing a !
Code:
#!/bin/bash

So your script may fail if bash is not your default shell
# 3  
Old 06-20-2011
Thanks A lot. That did it!
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Dummies Questions & Answers

Undefined variable error

I am getting the error undefined variable even after following these steps #read name abcd #echo $name na: undefined variable (6 Replies)
Discussion started by: Vishawdeep
6 Replies

2. Homework & Coursework Questions

Legal and illegal bash variable names?

list of legal and illegal bash variable names and wht each is either illegal and ligal? 4. Seneca college, Toronto , Canada, peter wheeler, tech 154: (5 Replies)
Discussion started by: renegade755
5 Replies

3. Ubuntu

error LD: undefined variable while changing shell from bash to csh

Hi, i am a beginner in ubuntu. my default shell is bash. everytime i try to change the shell with command "csh", i get a message (probably an error message). after i get into c-shell, when i try to execute a c shellscript, then it showed the same message. any idea about what is this about or any... (1 Reply)
Discussion started by: Avinash Nayak
1 Replies

4. Emergency UNIX and Linux Support

Csh script with Undefined variable error

hi there I have this C shell script that was migrated from AIX to Linux, could someone please help me, I checked the syntax numerous times but I can't find out where the error is. The script is meant to find files older than 27 days and delete it #!/usr/bin/csh # ... (22 Replies)
Discussion started by: hedkandi
22 Replies

5. Shell Programming and Scripting

Undefined variable and command not found

Below script cuts date part from the date entered by the user. #!/bin/csh echo 'Enter date in the format dd/mm/yyyy' read DATE DD=`echo $DATE | cut -c1-2` echo $DD; when debug with -x option , it works perfectly but without -x doesnot.:confused: $ sh -x unix_12.sh + echo Enter... (2 Replies)
Discussion started by: hiten.r.chauhan
2 Replies

6. Shell Programming and Scripting

Undefined variable error in csh script

Below csh script gives error: Undefined variable:confused: #!/bin/csh $QUERY="netscape"; COUNT_NETSCAPE=${ps | grep -c $QUERY}; echo $COUNT_NETSCAPE; when run gives error adroit:/home/seo/hitendra 64 ] ./unix_6.sh QUERY: Undefined variable. What is the root cause of the... (3 Replies)
Discussion started by: hiten.r.chauhan
3 Replies

7. Shell Programming and Scripting

Undefined variable in mv script

Hello, #this script renames schematic file for model year change #my = model year prefix my="lsd" for i in 'ls lsb*' do old=$i new='echo $i | cut - c4 - c30' mv $i $my$new end i: Undefined variable What am I missing or doing wrong? (6 Replies)
Discussion started by: dtrescott
6 Replies

8. Shell Programming and Scripting

cat in the command line doesn't match cat in the script

Hello, So I sorted my file as I was supposed to: sort -n -r -k 2 -k 1 file1 | uniq > file2 and when I wrote > cat file2 in the command line, I got what I was expecting, but in the script itself ... sort -n -r -k 2 -k 1 averages | uniq > temp cat file2 It wrote a whole... (21 Replies)
Discussion started by: shira
21 Replies

9. Shell Programming and Scripting

undefined variable error

Hi all, Im using a script which contains read command.. the script works perfectly but when I alias the script it gave "undifined variable" after I enter the read command input (variable)... Does any one know why ? (4 Replies)
Discussion started by: yahyaaa
4 Replies

10. UNIX for Dummies Questions & Answers

Prompting for Input - Getting Undefined Variable

#!/bin/csh -f echo "Enter MEUPS User Id :-" read UID echo "You entered $UID" --------------------------------------- Whn executed, I get an error message "UID: Undefined variable" (1 Reply)
Discussion started by: Kartheg
1 Replies
Login or Register to Ask a Question