Shell Programming and Scripting

I am facing a problem in passing a variable to grep inside a small script

The script(grepcp) is listed below

#!/usr/bin/ksh
DATE=$2
CELLNO=$1
test="REPT:CELL "$CELLNO" CP FAILURE"
echo $test
test1=" /omp-data/logs/OMPROP1/"$DATE.APX
echo $test1
#test2=$test
test2='"'$test'"'
test3="$test2$test1"
#echo "Date :" + $DATE
#echo "Cell :" + $CELLNO
#echo $test
#echo $test1
#echo $test2
echo $test3
grep $test3

the system response is as below
=========================
omp_lucknow2 rchakra> ./grepcp 108 041115
REPT:CELL 108 CP FAILURE
/omp-data/logs/OMPROP1/041115.APX
"REPT:CELL 108 CP FAILURE" /omp-data/logs/OMPROP1/041115.APX
grep: can't open 108
grep: can't open CP
grep: can't open FAILURE"

the command works perfectly when run from shell prompt as seen below
==============

omp_lucknow2 rchakra> grep "REPT:CELL 108 CP FAILURE" /omp-data/logs/OMPROP1/041115.APX|more
A 59 REPT:CELL 108 CP FAILURE, ANSWERED ORIGINATION
A 00 REPT:CELL 108 CP FAILURE, UNANSWERED ORIGINATION
A 00 REPT:CELL 108 CP FAILURE, ANSWERED ORIGINATION
A 06 REPT:CELL 108 CP FAILURE, ANSWERED ORIGINATION
A 08 REPT:CELL 108 CP FAILURE, UNANSWERED TERMINATION

Pl advice

Remove the "internal" quotes from this line, so it reads
test="REPT:CELL $CELLNO CP FAILURE"

Your quoting is having the effect of grepping for REPT:CELL within the files $CELLNO (i.e. what it evaluates to - 108), CP and FAILURE.

Cheers
ZB

I followed ur suggstn and now my code looks like

#!/usr/bin/ksh
DATE=$2
CELLNO=$1
test="REPT:CELL $CELLNO CP FAILURE"
echo $test
test1=" /omp-data/logs/OMPROP1/"$DATE.APX
echo $test1
#test2=$test
test2='"'$test'"'
test3="$test2$test1"
#echo "Date :" + $DATE
#echo "Cell :" + $CELLNO
#echo $test
#echo $test1
#echo $test2
echo $test3
grep $test3
========

and the response is the same as earlier

omp_lucknow2 rchakra> ./grepcp 108 041115
REPT:CELL 108 CP FAILURE
/omp-data/logs/OMPROP1/041115.APX
"REPT:CELL 108 CP FAILURE" /omp-data/logs/OMPROP1/041115.APX
grep: can't open 108
grep: can't open CP
grep: can't open FAILURE"


====

what is happening.??????

The spaces are being passed to the grep unquoted. Your code contains a ton of redundancy. Streamline to:

Code:

#!/usr/bin/ksh
DATE=$2
CELLNO=$1
grep "REPT:CELL $CELLNO CP FAILURE" /omp-data/logs/OMPROP1/$DATE.APX

Cheers
ZB

thanks that worked....