Shell Programming and Scripting

I am not sure where exactly the problem is, but i see at a glance that the script is poorly written:

1) instead of using "&&" and "||" to perform if-statements write them out. It is much easier to read (as well as to debug) that way.

Instead of

Code:

 [some condition] && { command1 ; command2 ; .... ; } || { command3 ; ... ; }

or something similar you should write it this way:

Code:

if [ some_condition ] ; then
     command1
     command2
     ....
else
     command3
     command4
     ....
fi

If you want to do yourself a favour and make it extra readable, document the more complicated branches by verbosely comment what the branches do. For instance:

Code:

if [ some_very_complicated_condition_about $FILE ] ; then     # if the file is a x-y type file
     command1
     command2
fi

2) When you use single quotes in strings make sure they are not misinterpreted as single-quoted strings:

Code:

"some str'ing"

might probably be misinterpreted as a single-quoted string 'ing' with just the closing single quote missing. You have used the single-quotes in "doesn't" several times. Write "does not" instead or - this may work, i haven't tested it - use escaping to mask the single-quotes. for instance:

Code:

x="string with a \' in it"

I hope this helps.

bakunin

this script is maded for some stupid manager, and i don't want that it can be readed easily. So no comment and no easier way. )