Login or Register to Ask a Question and Join Our Community


Shell Programming and Scripting

File not recognized when passed as argument

Login to Discuss or Reply to this Discussion in Our Community

 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting File not recognized when passed as argument
# 1  
Old 08-12-2010
File not recognized when passed as argument
I have the below script in file read_file.ksh
Code:
if [[ $# -ne 1 ]] || [[ $# -gt 1 ]]
then

echo "Required one input file"
echo "Enter a file to get char count:"
read $FILE_NAME
if [[ -f $FILE_NAME ]]
        then
         echo "valid file"
        else
        echo "Not a valid file."
fi

When run as read_file.ksh detail.csv or read_file.ksh ~/ded/incoming/detail.csv it works fine. But when i run the script alone w/out the argument as
Quote:
read_file.ksh
as given in the script it prompts as
Quote:
Required one input file
Enter a file to get char count:
and when i enter the file along with the full path, its not recognized as a file.
Quote:
~/ded/incoming/detail.csv
Not a valid file
Pls throw some light.
# 2  
Old 08-12-2010
  • I think it makes no sense to check if there is not exactly 1 parameter or more than 1. More than 1 is also not equal 1.
  • When using read into a variable, leave out the leading $.

Your script could look like:
Code:
if [[ $# -ne 1 ]]; then
        echo "Required one input file"
        exit 1
fi

echo "Enter a file to get char count:"
read FILE_NAME

if [[ -f $FILE_NAME ]]; then
        echo "valid file"
else
        echo "Not a valid file."
fi

exit 0

# 3  
Old 08-12-2010
Remove "$" while readign input
Code:
read FILE_NAME

# 4  
Old 08-12-2010
Your concern is correct. The requirement here is the user need to enter only one file as argument. If he enters more than one file or none it prompts for a input file.
Actually if he enters one file as read_file.ksh detail.csv it works fine - as i have kept this check in diff part of the script which i have not included in the original post. Below is the full script.

Code:
if [[ $# -ne 1 ]] || [[ $# -gt 1 ]]
then

echo "Required one input file"
echo "Enter a file to get char count:"
read FILE_NAME
if [[ -f $FILE_NAME ]]
        then
         echo "valid file"
        else
        echo "Not a valid file."
else
        FILE_NAME=$1
        if [[ -f $1 ]]
        then
        echo "valid file to get char count"
        else
        echo "Not a valid file to get char count."
fi

@pravin27: sorry that $FILE_NAME is a typo.
# 5  
Old 08-12-2010
Idea using case. Having just read your last post, my version will through a "usage" error if there is more than one parameter.

Code:
script_name=`basename $0`
param_count=$#
case ${param_count}
in
        0)      echo "Enter a file to get char count:"
                read FILE_NAME
                ;;
        1)      FILE_NAME="$1"
                continue
                ;;
        *)      echo "Usage: ${script_name} filename"
                exit 1
                ;;
esac

if [ -f "${FILE_NAME}" ]
then
        echo "valid file : ${FILE_NAME}"
else
        echo "Not a valid file : ${FILE_NAME}"
fi

# 6  
Old 08-12-2010
Thanks! But im getting the same error. i.e when the param_count=0 the script prompts for the input file and when it's given as full path
Quote:
~/ded/incoming/detail.csv
it does not recognize the *.csv file and echo's "Not a valid file ..."
No issues when given as detail.csv (without the full path.)

---------- Post updated at 07:50 PM ---------- Previous update was at 06:46 PM ----------

Guess the shell does not expand the variable when given in full path
Quote:
~/ded/incoming/detail.csv
# 7  
Old 08-12-2010
Interesting you are correct. When the filename is entered into the read statement rather than on the command line it does indeed not expand the ~username.

Fix highlighted in script below.

Code:
script_name=`basename $0`
param_count=$#
case ${param_count}
in
        0)
                echo "Enter a file to get char count:"
                read FILE_NAME
                ;;
        1)      FILE_NAME="$1"
                continue
                ;;
        *)      echo "Usage: ${script_name} filename"
                exit 1
                ;;
esac

FILE_NAME=`eval echo "${FILE_NAME}"`

if [ -f "${FILE_NAME}" ]
then
        echo "valid file : ${FILE_NAME}"
else
        echo "Not a valid file : ${FILE_NAME}"
fi
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Getting number of argument passed to a shell script

Hi Experts, I have been trying to work on a simple shell script that will just add the two argument passed to it. Here is what i tried : #!/bin/bash welcome(){ echo "Welcome to this Progg. which will accept two parameter" } main_logic(){ arg=$# echo "Number of argument passed is... (4 Replies)
Discussion started by: mukulverma2408
4 Replies

2. How to Post in the The UNIX and Linux Forums

Read a json file passed as cmd line argument

usage: myscript.sh config.json config.json: { "HOST":"abc", "DB_NM":"xyz", "USR_NM":"asd", "PWD":"xxx", ......... ......... ......... ........ } myscript.sh: (2 Replies)
Discussion started by: RGRT
2 Replies

3. Shell Programming and Scripting

Perl Code to change file delimiter (passed as argument) to bar delimiter

Hi, Extremely new to Perl scripting, but need a quick fix without using TEXT::CSV I need to read in a file, pass any delimiter as an argument, and convert it to bar delimited on the output. In addition, enclose fields within double quotes in case of any embedded delimiters. Any help would... (2 Replies)
Discussion started by: JPB1977
2 Replies

4. Shell Programming and Scripting

Variable passed as argument

I have a script. #!/bin/sh cur_$1_modify_time=Hello echo "cur_$1_modify_time" When I run like sh /root/script1 jj I expect value "Hello" being assigned to variable "cur_jj_modify_time" and output being "Hello" ie echoing $cur_jj_modify_time But the output comes as # sh... (3 Replies)
Discussion started by: anil510
3 Replies

5. Shell Programming and Scripting

Shell script that check the argument passed to it and prints error if test condition is not met

I want to make a script that check for the argument passed to it and generates an error in case any character/string argument passed to it. I am using below code, but its not working. can anyone help. #!/bin/bash if ]; then echo 'An integer argument is passed to the script hence... (3 Replies)
Discussion started by: mukulverma2408
3 Replies

6. Shell Programming and Scripting

$1 argument not being recognized

I am working on AIX 6.1 issuing #!/bin/sh at the beginning of the script. I don't understand why $1 is not working as expected. I expect it to hold the value for the first argument coming from the command line consistently - and it is not. At the beginning of the script starting I do this:... (4 Replies)
Discussion started by: Feliz
4 Replies

7. Shell Programming and Scripting

shell script for ftp files passed in command line argument

i want to write a shell script function that will ftp the files passed in the command line . i have written a shell script for ftp but how will it do for all files passed in command line argument , i am passing 4 files as argument ./ftp.sh file1 file2 file3 file4 code written by me... (5 Replies)
Discussion started by: rateeshkumar
5 Replies

8. Shell Programming and Scripting

how to print all argument passed

like i have script with which i have passed arg list :eg: i/p: scriopt1 arg1 arg2 arg3 .... argn o/p: arg1 arg2 arg3 .... argn (2 Replies)
Discussion started by: RahulJoshi
2 Replies

9. Shell Programming and Scripting

Argument not recognized as integer

I need to accept a number of arguments at command line and print it in reverse order i use eval `echo x=$1` to capture the argument #! /bin/sh counter=0 while do eval `echo x=$1` arg$counter=$x counter=`expr $counter + 1` shift done but the error keeps... (1 Reply)
Discussion started by: scmay
1 Replies

10. Shell Programming and Scripting

Check if argument passed is an integers

How do I check if the argument passed to a script is an integer? I am writting a script that will take to integers and want to be able to check before I go on. I am using bourne shell. Thanks in advance (13 Replies)
Discussion started by: elchalateco
13 Replies
Login or Register to Ask a Question