Shell Programming and Scripting

Hello Guys
I need some help with my script
I'm not very good at this, hope you can point me in the right direction.
My idea, to write a file with some router commands and use it on a script for me to run on a demand basis, ( or added to the cron, if I get it to work).

The below script works, but the output is being multiply by the number of commands, for example:

cat files/commands
sh ver
sh hard
sh env

SCRIPT
~~~~~~~~~~~~~~~~~~~

#!/usr/bin/ksh

sed -n '1p' files/commands > files/temp1
sed -n '2p' files/commands > files/temp2
sed -n '3p' files/commands > files/temp3
sed -n '4p' files/commands > files/temp4
sed -n '5p' files/commands > files/temp5
sed -n '6p' files/commands > files/temp6
sed -n '7p' files/commands > files/temp7
sed -n '8p' files/commands > files/temp8
sed -n '9p' files/commands > files/temp9
sed -n '10p' files/commands > files/temp10

comm1=$(cat files/temp1)
comm2=$(cat files/temp2)
comm3=$(cat files/temp3)
comm4=$(cat files/temp4)
comm5=$(cat files/temp5)
comm6=$(cat files/temp6)
comm7=$(cat files/temp7)
comm8=$(cat files/temp8)
comm9=$(cat files/temp9)
comm10=$(cat files/temp10)

for router in user@metis
do
print
echo router $router
(sleep 5
echo password
echo $comm1
sleep 5
echo $comm2
sleep 5
echo $comm3
sleep 5
echo $comm4
sleep 5
echo $comm5
sleep 5
echo $comm6
sleep 5
echo $comm7
sleep 5
echo $comm8
sleep 5
echo $comm9
sleep 5
echo $comm10
sleep 5
echo exit
echo exit
sleep 5 ) | ssh $router >> ~/s/files/Router.commands
done

mailx -s "Router Output Requested" mymail@mail.com < ~/s/files/Router.commands

rm ~/s/files/Router.commands

# END
~~~~~~~~~~~~~~~~~~~
Output:

router metis
sh ver
sh hard
sh env

router metis
sh ver
sh hard
sh env

router metis
sh ver
sh hard
sh env

Thank you
Tony

use a for loop to get rid of all that repetition.

Code:

sed -n '1p' files/commands > files/temp1
sed -n '2p' files/commands > files/temp2
sed -n '3p' files/commands > files/temp3
sed -n '4p' files/commands > files/temp4
sed -n '5p' files/commands > files/temp5
sed -n '6p' files/commands > files/temp6
sed -n '7p' files/commands > files/temp7
sed -n '8p' files/commands > files/temp8
sed -n '9p' files/commands > files/temp9
sed -n '10p' files/commands > files/temp10

becomes:

Code:

for (i = 1; i <= 10; i++)
{
    sed -n '$i'p' files/commands > files/temp$i
}

watch the syntax with the variable placement i have there, i dont know ksh.

you see how that works? it counds from 1 to 10 and stores that numbe in "i" each time. so when you use that variable it is just like having it there each time like you did before, except in a nice neat little loop.

you can use that for everytyhing that is repeated like that in your script.

Unfortunately, that type of for construct will only work in c based shells and bash.

In ksh, you'll have to use the traditional

Code:

for i in 1 2 3 4 5 6 7 8 9 10
do
   # blah
done

or if you have the seq command,

Code:

for i in $(seq 1 10)
do
    #blah
done

You'll also need the sed command changed slightly to:

Code:

sed -n "${i}p" files/commands > files/temp${i}

Notice the double quotes - this allows the value of i to be evaluated.

Cheers
ZB

I wouldn't even use all those temp files...

Code:

#!/usr/bin/ksh

export infile=files/commands
export outfile=~/s/files/Router.commands

for router in user@metis
do
  print
  echo router $router
  ( sleep 5
    echo password
    while read comm
    do
      echo $comm
      sleep 5
    done < $infile
    echo exit
    echo exit
    sleep 5 ) | ssh $router
done > $outfile 2>&1

mailx -s "Router Output Requested" mymail@mail.com < $outfile

rm $outfile

# END

It works great

Thank you all
Tony