Shell Programming and Scripting

Code:

while read ip;do mount -t cifs //${ip}/share /mnt/share -o username =hiro;done < ipfile

Yes the share mounts perfectly with that command with the ip address in it and the text file does contain the correct ip address but when i tried your code i got the errors listed in my last post. There is something just a little wrong with the syntax of that code or i have copied it out incorrectly. Can you see any mistakes anywhere either in the original code or in mine? The code i posted is cut and paste directly from my script so that is exactly as it is there.
Thanks for persevering, Hiro.

---------- Post updated at 06:23 PM ---------- Previous update was at 07:12 AM ----------

I've done a bit more playing and come up with this:

Code:

#ip=${awk '{print $1}' /home/hiro/Documents/ipaddress}
ip=$1192.168.1.2
echo $ip
sudo mount -t cifs //$ip/music /mnt/music -o username=hiro

As you can see i have commented out the line i thought was troublesome and told ip to have the ip address as it's value. For some reason, presumably the syntax i used it ignored the first character so i just banged another one in there and that gave me a print on the screen of the ip address i wanted. I had the last line commented out at that point as i didn't think it was the problem and as soon as i uncommented it the share mounted.
I think this proves that the first line is to blame? Can anyone shed any light?

Danmero, i am a little, make that a lot confused by your code, is that to replace both of the original lines or just the second one? I ran it on it's own and got an "Unexpected end of file error" but i think maybe it needs the first line to set the variable "$ip"? Is this right? If so it won't work now as the first lines seems to be at fault.

hiro,
what are the results of following two commands:

Code:

cat /home/hiro/Documents/ipaddress

Code:

awk '{print $1}' /home/hiro/Documents/ipaddress

The output should be the same, namely the ip address from the ipaddress file.
In this case you can assign this ip address to a variable called ip like this:

Code:

ip=$(awk '{print $1}' /home/hiro/Documents/ipaddress)

If you want to assign the ip address to a variable called ip:

Code:

ip="192.168.1.2"

This is how I tested that:

Code:

$ cat ipaddress
192.168.1.2
$ awk '{print $1}' ipaddress
192.168.1.2
$ ip=$(awk '{print $1}' ipaddress)
$ echo $ip
192.168.1.2
$ ip="10.14.7.1"
$ echo $ip
10.14.7.1
$

HTH

Success at last! Unfortunately i had made another silly mistake, remember how i had plain brackets when i first typed the code in and i then changed them to curly brackets? Well i changes both pairs but your latest post with the colour coding soon put me right and it now works a treat. All i need to do now is neaten the script up a bit and my first ever attempt at scripting will be a useful tool for me.
I couldn't have done it without your help so thank you very much for your patience, Hiro.