C, sh, perl, system(): Can't transfer a return code appropriately: help, pls


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting C, sh, perl, system(): Can't transfer a return code appropriately: help, pls
# 1  
Old 04-12-2010
C, sh, perl, system(): Can't transfer a return code appropriately: help, pls

I am using a perl-script from C-code, executing it by the 'system(..)' comand.

The problem is to return the perl-return code to the C correctly.

Default the 'system()' shell is Bourne: sh

My try: (perl_src.c_pl - the perl script; t_sys - C-program with system() call (I will show it after this block.))
Code:
> perl_src.c_pl ${fl} || { echo "$?, wrong;"; }
Can't use an undefined value as a symbol reference at ./perl_src.c_pl line 254, <$sdx> line 1013.
2, wrong;
>
>   # now execute the same command by the C-with system();
> t_sys "perl_src.c_pl ${fl} || { echo \"$?, wrong;\"; } "
Can't use an undefined value as a symbol reference at perl_src.c_pl line 254, <$sdx> line 1013.
0, wrong;

 executed command: perl_src.c_pl ../data/sdx4-1K.dat || { echo "0, wrong;"; }
 RETURN: 0
>

(the t_sys.c is:
Code:
> cat t_sys.c
#include <stdio.h>
main ( int argc, char* argv[] )
{
  char *cmd=argv[1];
  int rt=system(cmd);
  printf ("\n executed command: %s\n RETURN: %d\n", cmd, rt);
}
>

)

The problem is in the '$?' that is not correct in system() after the perl script is processed.

What I am doing wrong?
How I can transfer the correct perl return code to the C code?

Thnks!
# 2  
Old 04-12-2010
To have a perl script return a certain error code to the system, do
Code:
exit 5;

in the perl script or the like.

But your perl script has bigger problems already, like the error message says. It may be returning unexpected errors due to the syntax problems in your script.
# 3  
Old 04-12-2010
The system() function will exec a sh and return its exit status. The exit status of "perl_src.c_pl ${fl} || { echo \"$?, wrong;\"; }" will always be 0, unless the echo fails (which is very unlikely).

Code:
$ sh -c 'perl -e "exit 5" || echo perl exit status $?'
perl exit status 5
$ echo sh exit status $?
sh exit status 0

Something along the lines of the following is probably want you want:
Code:
sh -c 'perl ....; pexit=$?; [ $pexit -ne 0 ] && echo $pexit; exit $pexit'

Although, personally, I don't see the point of echoing from the shell pipeline (unless that was part of your troubleshooting process). You can check the exit status in the C code and generate the appropriate message there.

Regards,
Alister

Last edited by alister; 04-12-2010 at 04:33 PM..
# 4  
Old 04-13-2010
I think, I am not clear enough.
Corona688 - I do not have a problem with the perl-script. The error is found and corrected.
I need to be sure that any perl-script problem (script could be changed) will be propagaited into C program and correctly ends the program!

alister - you are right, I am 'echo'ing the result to see that value now, when I debuging the situation.
The main intention is to 'exit $?' - expecting to have in C the same value as it was returned by the perl-script.
By now I exiting with hardwired '2' - as it returned currently by the perl (but it could be different!)

Anyway, by your ansvers, guys, I have realised one point: in the line
Code:
t_sys "perl_src.c_pl ${fl} || { echo \"$?, wrong;\"; } "

the '$?' is substituted by shell BEFORE starting the 't_sys' - because the 'double quotes'! Smilie
My mistake here!

But, alister -
- your point is correct and understood, but the problem is not in the overwriting the return code by echo, but in comming out after the system() - now I see that I had it passed in wrong way.
Anyway, in correct passing way it still comming through the system() changed:
Code:
> sh -c 'perl -e "exit 5;" || exit $? ' ; echo $?
5
> t_sys 'perl -e "exit 5;" || exit $? ' ; echo $?

 executed command: perl -e "exit 5;" || exit $?
 RETURN: 1280
2
>

??? Now it even more unclear: Still system() returns something weird: 1280 instead of 5; but the program some why exiting with 2!!!
What is wrong??

Thank you for your attention!
# 5  
Old 04-14-2010
Quote:
Originally Posted by alex_5161
Anyway, in correct passing way it still comming through the system() changed:
Code:
> sh -c 'perl -e "exit 5;" || exit $? ' ; echo $?
5
> t_sys 'perl -e "exit 5;" || exit $? ' ; echo $?

 executed command: perl -e "exit 5;" || exit $?
 RETURN: 1280
2
>

??? Now it even more unclear: Still system() returns something weird: 1280 instead of 5; but the program some why exiting with 2!!!
What is wrong??

Thank you for your attention!
First, you need to read the man page on system(3). The return value is of the format returned by wait(2). Thus, you need to feed that into the WEXITSTATUS macro to get the actual return value.

Second, you are not returning a value from your main function. The 2 is just a value left over on the stack.

Here's a quick cut at correcting your program (I'm not at a Linux system at the moment so I can't check it):

Code:
#include <stdio.h>
main ( int argc, char* argv[] )
{
  char *cmd=argv[1];
  int rt=system(cmd);
  int actual_exit = -1, actual_signal = -1;
  if (WIFEXITED(rt)) actual_exit = WEXITSTATUS(rt);
  else actual_signal = WTERMSIG(rt);
  printf ("\n executed command: %s\n RETURN: %d or SIGNAL: %d\n", 
    cmd, actual_exit, actual_signal);
  return actual_exit;
}

I took care of handling the case where the child process gets a signal though the program exit status won't reflect it correctly.

See if that helps.
This User Gave Thanks to DoxieLvr For This Post:
# 6  
Old 04-14-2010
There are a few things wrong.

You aren't declaring main() to return an int, although the compiler is probably taking care of this for you.

main() is not returning a value.

rt is not the simple integer exit status that you think it is. rt contains other information regarding how the process exited (for example, if by a signal, which sig). You need to read the waitpid() man page for the details (which include macros to extract the actual exit status from system's return value).

system
wait

You omitted the stdlib.h include for system() and the wait-related macros required to work with its return value.


Code:
#include <stdio.h>
#include <stdlib.h>

int
main(int argc, char *argv[])
{
    char *cmd=argv[1];
    int rt=system(cmd);
    if (WIFEXITED(rt)) {
        rt=WEXITSTATUS(rt);
        printf ("\n executed command: %s\n RETURN: %d\n", cmd, rt);
    }
    else
        rt=128;
    return rt;
}


Sample run:
Code:
$ ./a.out 'perl -e "exit 5"'; echo $?

 executed command: perl -e "exit 5"
 RETURN: 5
5

Regards,
Alister

Last edited by alister; 04-14-2010 at 02:38 AM..
This User Gave Thanks to alister For This Post:
# 7  
Old 04-14-2010
Wow!
Thank you, guis, it is new for me, never come across of that WIFEXITED.
Sure, I should check the man for system().

Big thanks for expalanation!!
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

[solved] awk: return code from system() always 0 ??

Hi all, I currently have the following problem: In an awk script, I am calling a predifend function from the END{} and handing over a command string. This string arrives flawless and is executed like this: function send_msg( cmd_str ) { ... (7 Replies)
Discussion started by: zaxxon
7 Replies

2. Shell Programming and Scripting

Transfer file from UNIX to MFT system

Hello , I need to write a script that by using scp transfer a csv file from UNIX to a MFT system (MFT is similar to a winscp) with the help of a private/public key. problem is we are not suppose to generate a private key that will be provided to use by an Application team. Can anybody help me... (0 Replies)
Discussion started by: Monika08
0 Replies

3. Shell Programming and Scripting

How to get the return code of subroutines executed as standalone as command line in Perl ?

How to do I get the return code of a subroutine in a perl module if invoke the subroutine as standalone, I have an module say TestExit.pm and in that i have a subroutine say myTest() which is returns 12, if i were to call the subroutine from command line like CASE:1 ( Without an explict... (2 Replies)
Discussion started by: ennstate
2 Replies

4. Shell Programming and Scripting

How to delete already existing data in a file using perl? Pls help me!!

Dear Friends, I need urgent help from u.. I have two files,file1 & file 2.. file1 have a existing data of file2.So i want to delete those existing datas from file1 (which contain the data from file1) My file1 like this rs39348 1 1045729 A G 0.1791 0.2054 0.84 ... (3 Replies)
Discussion started by: sureshraj
3 Replies

5. Shell Programming and Scripting

Assistance pls - pipe error: Too many open files in system

When I run a bash script in the customer system, it throws the warning and script exits Exec '/root/sample.sh' @ hostname-- OK (warn) /root/sample.sh: pipe error: Too many open files in system /root/sample.sh: n + : syntax error: operand expected (error token is " ") Exec... (5 Replies)
Discussion started by: vidhyamirra
5 Replies

6. UNIX for Dummies Questions & Answers

to pick up the Return Code ( RC) from the mailx command and return it to SAS uisng 's

Hi All, Can anyone please let me know the syntax / how to pick up the Return Code ( RC) from the mailx command and return it to SAS uisng 'system()' function and '${?}'. I am in a process to send the mail automatically with an attachment to bulk users. I have used 'Mailx' and 'Unencode'... (0 Replies)
Discussion started by: manas6
0 Replies

7. UNIX for Dummies Questions & Answers

Pls guide me in learning in Perl Module and packages

Hi, It is very urgent. Pls guide me in learning Perl Module and the Packages. Eventhough i tried in the google, I didnt get upto my expectations. Pls guide me how to create , build Module and the package. Many Thanks. (3 Replies)
Discussion started by: Yamini Thoppen
3 Replies

8. Programming

Return code from system()

Hi, Can any one help me in knowing how can I get the return codes/Error codes when using the system() command to fork a command? Regards, MK (1 Reply)
Discussion started by: mradulkaushik
1 Replies

9. Solaris

transfer data to a remote system from the tape

i need to retrieve the data from tape on to a remote system.how should i go about it can anyone please help.......its urgent (1 Reply)
Discussion started by: jack123
1 Replies

10. Shell Programming and Scripting

perl "system" cmd return values..

perl 5.6.1: when i try a "system" command(with if loops for $?), i get this: child exited with value 1 what is meant by this $? values and what does it meant if it returns 1?.. (0 Replies)
Discussion started by: sekar sundaram
0 Replies
Login or Register to Ask a Question