Shell Programming and Scripting

I am using the code below to list all the Errors files from the directory in the for loop. When the number of files are less then 6000 then it's works fine but if it more than that then for loop fails.

Code:

for file in `ls $ERR_DIR/PPL_Prov_Engine_Error_*`
do
memrecno=`cut -f2 -d'|' $file` || checkReturn $STEP $LINENO $?
done

Please suggest.

Use:

Code:

for file in "$ERR_DIR"/PPL_Prov_Engine_Error_*

Not only will it not choke on a command line length limit, it will properly handle pathnames with IFS characters (by default, space/tab/newline).

Regards,
Alister

Hi Alister,

Your code will put all the files in $file variable and actully I want to read one file at a time and do some processing on that file and read second file so on.

So if the loop run 100 times then my file variable should have 100 value in it.

Please suggest.

Did you even try it?

yes I have tried it .

You seem to be under the impression that my code somehow dumps all filenames into $file and iterates once; that's mistaken. It iterates over each filename, one at a time. If that's not what occured when you used it, then you are doing something wrong. If you'd like some help with it, post the code that you tried and any errors generated.

The for loop I shared above is the simplest, safest, most efficient solution to your problem (using ls to generate a list of filenames in a directory is never needed, can generate erroneous results after field splitting occurs, and is constrained by system command line length limits).

Thanks it is working now.
I have done syntax error.