Shell Programming and Scripting

Hi.

I need help with a little script that will be used to move some files to their parent directory, delete the directory, rename one file in the parent directory and delete another, then continue to the next.

Here's an example:

/var/media/Music/Genesis/1970 album - Trespass (2008 Box - 1970-1975) [GIR - FLAC - 2008 remaster]/split/ contains these files:

01.00 - (HTOA).flac
01 - Looking for Someone.flac
02 - White Mountain.flac
03 - Visions of Angels.flac
04 - Stagnation.flac
05 - Dusk.flac
06 - The Knife.flac
folder.jpg
Trespass-split.cue

The parent directory, /var/media/Music/Genesis/1970 album - Trespass (2008 Box - 1970-1975) [GIR - FLAC - 2008 remaster]/, contains these files:

split (subdirectory)
folder.jpg
Trespass.cue
Trespass.flac

I want the script to move *.flac from the "split" directory to it's parent. After the move, the "split" directory should be deleted, together with any files remaining in it.
Then, in this example, the script should rename "Trespass.cue" to "Trespass.cue.singlefile", and delete Trespass.flac.

After that, it should move on to the next directory that contains a subdirectory named "split". Any directory that doesn't contain a subdirectory named "split" should be ignored.

The uppermost directory for this operation is /var/media/Music/.

I have some knowledge of PHP, but I guess that isn't the most efficient language for this operation.

Could anyone please help me out here? Would save me several weeks of tedious manual moving of files =)

My system is running Debian 5.0.3.

Thanks, that looks like just the right thing :-)

But, how do I execute it?

I've saved it as split.sh, added #!/bin/bash at the beginning and chmod'ed it 777, then tried to run it (both as normal user and as root) with ./split.sh, but I only get bash: ./split.sh: Permission denied or bash: ./split.sh: /bin/bash: bad interpreter: Permission denied

I've also tried to run it without the #!/bin/bash, but it won't run.


edit: I just ran it from the commandline now, and it seems to be working, kinda. I ran it in a directory I made for testing, and it seems like it fails when it tries to cd "$splitdir".

If I change the command to echo "$splitdir", I get this output: ./Iron Maiden/1980 Album - Iron Maiden [GIR - FLAC - 1998 remaster]/split. I guess the problem here is that spaces needs to be escaped. Any input on that?

All the FLAC-files in my test directory were deleted however, so I guess it was wise to test it first, hehe. I also have a backup of everything else, in case something goes wrong when the script is ready to do it's job

Not a good idea. Files should rarely, if ever, have world write permissions. Usually 755 is enough.

Did you write the file on a Windows box? If so, you need to remove the carriage returns.

Spaces in a directory name (as repugnant as they are) will not affect the script as the variable is quoted.

For testing, it is common practice to precede rm with echo.

Hi. There was indeed an error in the script, but you were right about the " around $splitdir, they did the job.

The problem was that in your version, you deleted *.flac in the parent directory AFTER moving the *.flac from the split directory.

In my version, I delete *.flac from ../ BEFORE I move the *.flac.

I'm running it on my data now (have backup of course), and things seem to work as planned.

Thanks for the help :-)

Code:

 
find . -type d -name split |
  while IFS= read -r splitdir
  do
    (
      cd "$splitdir" || continue
      rm -f ../*.flac
      mv -f *.flac ..
      cd .. || continue
      rm -rf split
      for cue in *.cue
      do
        mv "$cue" "$cue.singlefile"
      done
      echo moved "$splitdir"
    )
  done