While read line loop


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting While read line loop
# 1  
Old 01-19-2010
While read line loop

Hi I'm writing a bash script which will read an input file and look for occurrences of the current user ($USER) executing the script. When i find the occurrence of the username I take that line and append it to a file with a line number and bracket display next to line.

The input file has been called yy and contains env data.

the output file should contain output in the following form:

1) PWD=/home/users/bund.bash
2) USER=bund.bash
3) MAIL=/mail/bund.bash
4)..... etc etc etc


I have written the code but cant seem to get it to run....I believe there is an error with the syntax in the while loop. Many thanks in advance for any help.

Code:
 
#!/bin/bash
yy=$1
count=1
 
inputfile=$(grep $USER $yy)
 
while $inputfile | read line
do
 
        count=$((count+1))
        echo $count")" $line >> filesave
 
done


should the done end with done <yy perhaps??
# 2  
Old 01-19-2010
I didn't understand you correctly, but still some questions

Do you want to search for $USER in the yy file?
inputfile is a variable in your case not a file.

perhaps, you could try:

Code:
while read line
do
        found=$(grep $USER $line)
        if [ "$found" ]; then
          echo $count")" $line >> filesave
        fi
        count=$((count+1))
         
done < $yy

# 3  
Old 01-19-2010
@ anchal

yes i want to search for every time $USER is in the yy file and write output in the form:

1) data
2) data
3) data

etc

I see what you have done and I understand the code but when i try and run the script i get the error: $yy: ambiguous redirect
# 4  
Old 01-19-2010
what are you passing as $1? A filename with absolute path or if only filename then it must exists in the current dir.

can you show us the messages?
# 5  
Old 01-19-2010
yy=$1 and yes its in the current directory. Here is the complete code:

Code:

#!/bin/bash

yy=$1
count=1



while read line
do

        found=$(grep $USER $line)
        if [ "$found" ]; then

        echo $count")" $line >> filesave
        fi
        count=$((count+1))


done < $yy

filesave is also in the current directory and is an empty file but it has been created
# 6  
Old 01-19-2010
sorry,I did a mistake, dont you get grep error also?
try this
Code:
count=1



while read line
do

        found=$(echo $line | grep "$USER")
        if [ "$found" ]; then

        echo $count")" $line >> filesave
        fi
        count=$((count+1))


done < $1

# 7  
Old 01-19-2010
Post your input file between code tags.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

While read line loop

Based on text file: PATH:/media/hdd/Media/Video/title1 FILE:/media/cache/281662-14.jpg PATH:/media/hdd/Media/Video/title2 FILE:/media/cache/281662-15.jpg PATH:/media/hdd/Media/Video/title3 FILE:/media/cache/281662-16.jpg PATH:/media/hdd/Media/Video/title4 FILE:/media/cache/281662-17.jpg... (12 Replies)
Discussion started by: TiedCone
12 Replies

2. Shell Programming and Scripting

Do While Loop + Read From File + assign line to a variable

Hello, I am using below code for reading from a file and assigning the values to a variable , but it is loosing the value after the loop , please suggest to retain the value of the variable after the loop , while IFS=: read -r line do set $dsc=$line echo 'printing line variable ' $line... (1 Reply)
Discussion started by: ParthThakkar
1 Replies

3. Shell Programming and Scripting

IF awk in a while read line-loop

Hi As a newbe in scripting, i struggle hard with my first script. What i want to do is, bringing data of two files together. file1: .... 05/14/12-04:00:00 41253 4259 5135 5604 5812 5372 05/14/12-04:10:00 53408 5501 6592 7402 7354 6639 05/14/12-04:20:00 58748 6037 7292 8223... (13 Replies)
Discussion started by: IMPe
13 Replies

4. Shell Programming and Scripting

Simple while read line loop question

#!/bin/bash count=1 while read line do if (($count > 4)); then awk -v var1="$count" '{printf "%3s%8s%11s%11s%11s\n",var1,$2,$3,$4,$5}' else echo $line fi count=$((count+1)) done < posre_sub.itp > test cat test INPUT: ; position restraints for... (3 Replies)
Discussion started by: origamisven
3 Replies

5. Shell Programming and Scripting

Read file using while loop not reading last line

I have written a script to read the file line by line. It is reading and printing the lines. But it is coming out of loop before reading last line. So I am not able to print last line. How do I solve it. (6 Replies)
Discussion started by: dgmm
6 Replies

6. Shell Programming and Scripting

While loop read line not working

Hi, I am trying to read a file line by line inside of a while loop. This while loop is part of a here document. while read line do ssh -t $2@$remotehost <<REMOTE ls path/to/dir > $path_to_dir while read line1 do echo "LINE --- $line" done... (4 Replies)
Discussion started by: mnanavati
4 Replies

7. Shell Programming and Scripting

While loop read line Issue

Hi I am using while loop, below, to read lines from a very large file, around 400,000 rows. The script works fine until around line 300k but then starts giving incorrect result. I have tried running the script with a smaller data set and it works fine. I made sure to include the line where... (2 Replies)
Discussion started by: saurabhkumar198
2 Replies

8. Shell Programming and Scripting

read line in a for loop

Hi All, How can we use read line using the index value of a FOR loop? eg: pt_mstr,pt_status,8 pt_mstr,pt_buyer,8 pt_mstr,pt_sfty_stk,8 pt_mstr,pt_ord_pol,3 pt_mstr,pt_capacity,8 pt_mstr,pt_plan_ord,3 pt_mstr,pt_ord_mult,8 From this file i want to read the line2, 3 and 4 only using a FOR... (3 Replies)
Discussion started by: balajim
3 Replies

9. UNIX for Dummies Questions & Answers

Alternative for a while read line loop

HELLO all :), I have been trying to use a simple while loop to read a file " templist", line by line and perform an action. See the code below. The reason for not using a while read line loop is the for the use of the if condition that wouldn't work. I would appreciate some ideas as this has... (2 Replies)
Discussion started by: kabs
2 Replies

10. Shell Programming and Scripting

Nested while read line loop

Hi, Can anyone please help me: i'm trying to read a file with directory-names , then go to that directory and read another (output) file to perform some tasks per line (second read line in the part of script below). The problem is that after the nested while loop has finished, the first while... (7 Replies)
Discussion started by: Rakker
7 Replies
Login or Register to Ask a Question