Error with the following script


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Error with the following script
# 1  
Old 11-30-2009
Error with the following script

Greetings again.
I made a program that tells the size of a dictionary and stores it into a temp.txt file.
Code:
temp="temp.txt"

if [ $# -ne 1 ]; then
      echo "Wrong parameter"
 else
      if [ -d "$1" ]; then
             rm "$temp"                        #Delete any previous temp file
             find "./$1" -maxdepth 1 -type f >> "$temp"           
             #save the found files to the temp file

IFS="           #set for breaking characters
"
size=0
files=`cat "$temp"`     #read the temp file
rm "$temp"                 
#delete the temp file (making sure its size wont be read)

#size counting
for i in $files; do
   if [ -f $i ]; then
      size=$(expr $size + $(stat -c%s "$i"))
   fi
done

echo "The directory's size is : $size"
else 
echo "A non directory parameter was given"
fi
fi

the problem is the script doesn't create the temp.txt file. if i create one then it deletes it so the deleting part is okay.
the script - as it is at the moment - also tells the correct size of the dictionary, so that part seems to be okay aswell.
i just cannot fix it:/
Thanks in advance!
# 2  
Old 11-30-2009
My impression is that you are posting homework in the main forums.

To post homework, you must follow homework posting rules in the proper forum.

Also, you need to write more descriptive subjects.

Here is a link to the rules. Please read them and follow them. Thanks!

The UNIX and Linux Forums - Forum Rules
# 3  
Old 12-01-2009
The script deletes temp.txt after creating and reading back reading the file.

Quote:
files=`cat "$temp"` #read the temp file
rm "$temp"
#delete the temp file (making sure its size wont be read)
This causes temp.txt to be not present the next time the script is run and then this "rm" line will fail:

Quote:
if [ -d "$1" ]; then
rm "$temp" #Delete any previous temp file
Actually the "Delete any previous temp file" line is not needed.
Consider replacing ">>" with ">" in the "find" line such that it creates the file if it does not exist or overwrites the file if it does exist.

Code:
find "./$1" -maxdepth 1 -type f > "$temp"


Last edited by methyl; 12-01-2009 at 11:36 AM.. Reason: typo
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Shell script with sql script error

Hi All when I execute from psql prompt, I get the result, when I try to automate using a shell script, the query is not working # `/usr/bin/psql -U postgres -d coba1 -c "select name from users where "Date" > current_date - 30;"` ERROR: column "Date" does not exist LINE 1: select... (2 Replies)
Discussion started by: srilinux09
2 Replies

2. Shell Programming and Scripting

Calling shell script within awk script throws error

I am getting the following error while passing parameter to a shell script called within awk script. Any idea what's causing this issue and how to ix it ? Thanks sh: -c: line 0: syntax error near unexpected token `newline' sh: -c: line 0: `./billdatecalc.sh ... (10 Replies)
Discussion started by: Sudhakar333
10 Replies

3. Shell Programming and Scripting

Help with FTP Script which is causing "syntax error: unexpected end of file" Error

Hi All, Please hav a look at the below peice of script and let me know if there are any syntax errors. i found that the below peice of Script is causing issue. when i use SFTP its working fine, but there is a demand to use FTP only. please find below code and explain if anything is wrong... (1 Reply)
Discussion started by: mahi_mayu069
1 Replies

4. Shell Programming and Scripting

Error in calling a shell script from another script

HI, We are using two shell scripts, script.sh,env.sh, where env.sh will be called inside script.sh. The variable inside env.sh is used as $var in script.sh.But while running the script its not identifying that variable. Is there any permission needed to call a script inside another script. ... (3 Replies)
Discussion started by: banupriyat
3 Replies

5. UNIX for Dummies Questions & Answers

Re: Script Error [syntax error at line]

Hi , I Have Written A Simple Script To Check Greatest Of '2' Number When Execuating The Script I Am Getting The Below Error SP11: if:not found SP11: line 4:syntax error at line 5:'then' unexpexted And The Program I Have Wrriten For This #!bin/ksh echo "Enter Two Numbers"... (3 Replies)
Discussion started by: anudeepkumar123
3 Replies

6. Shell Programming and Scripting

Syntax error calling TCL script from shell script

hello everyone i am beginner on shell scripting .and i am working on my project work on ad hoc network i wrote a batch (.sh) to do a looping and execute a tcl script i wrote before in each iteration ..but i got this problem " syntax error near unexpected token `('... (1 Reply)
Discussion started by: marcoss90
1 Replies

7. Shell Programming and Scripting

How to grep sql error in shell script and exit the script?

I need help in the following script. I want to grep the sql errors insert into the error table and exit the shell script if there is any error, otherwise keep running the scripts. Here is my script #!/bin/csh -f source .orapass set user = $USER set pass = $PASS cd /opt/data/scripts echo... (2 Replies)
Discussion started by: allinshell99
2 Replies

8. Windows & DOS: Issues & Discussions

Error opening script file - location error

Hello, I know nothing about UNIX, ftp, etc. I am building an excel VBA macro which calls a .bat file. I've taken a pre-existing batch file and am trying to modify it to fit my purposes. I would be very grateful for some assistance. Here is my .bat file: echo off set... (9 Replies)
Discussion started by: starcraftbud
9 Replies

9. Shell Programming and Scripting

Script with error output but continuation in script?

I have written a basic fetching script. The script logs into an FTP site, downloads a .zip file, then unzips and moves the files to the necessary folders, then deletes them, etc. The problem I have is if one of the files no longer exists on the FTP site or another part of the script fails, then... (3 Replies)
Discussion started by: daem0n
3 Replies

10. UNIX for Dummies Questions & Answers

awk Shell Script error : "Syntax Error : `Split' unexpected

hi there i write one awk script file in shell programing the code is related to dd/mm/yy to month, day year format but i get an error please can anybody help me out in this problem ?????? i give my code here including error awk ` # date-month -- convert mm/dd/yy to month day,... (2 Replies)
Discussion started by: Herry
2 Replies
Login or Register to Ask a Question