How to clean this script?


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting How to clean this script?
# 1  
Old 11-30-2009
Problems getting files date on script

Hello guys,
this script partially works but it's still pretty ugly and, moreover, if the month is jan/feb/mar... it doesn't work at all.

Could anyone say me how to correct, cut and clean a little bit?

Code:
#!/usr/bin/ksh
[...]
egrep -v -e "^\s*#" /file/permission | awk '{ print $1 }' | sort | uniq | while read USER

do
LASTMONTH=`date "+%m"
let FIRSTMONTH=$LASTMONTH-3
let i=$FIRSTMONTH

 while [ $i -eq $LASTMONTH ]
  do
   n=`printf "%02d\n" $i`
   egrep $USER /var/log/access.2009$n >/dev/null || echo $USER >> $FILE
   let i=$i+1
  done
done

Best Regards

Last edited by gogol_bordello; 11-30-2009 at 10:55 AM..
# 2  
Old 11-30-2009
first thing i see is a missing ` at the end of the LASTMONTH line. next is the $LASTMONTH-3 should not work... should be something like "FIRSTMONTH=$(expr $LASTMONTH - 3)".
this isn't tested and so only a guess...
# 3  
Old 11-30-2009
Not sure what you're trying to achieve, maybe you can do the whole stuff with one awk command.
# 4  
Old 11-30-2009
for ` it was just a digit error.

I'm trying to verify if I could find a specific string ($USER) on last three months logs.
My logs files are like:
Code:
/var/log/access.200901
/var/log/access.200902
/var/log/access.200903
/var/log/access.200904

etc...


I've year problem too... I means, what will happen with my scripts on jan 2010? :-/
tnks
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

UNIX Script to clean files

Hello All, I need a script that would delete files which are more than "X" number of days old, also if there can be a log file of the deleted files for reference. I am from windows background hence finding it difficult. Any help is much appreciated Regards Wert (4 Replies)
Discussion started by: wert468
4 Replies

2. UNIX for Dummies Questions & Answers

'awk' help for script to clean out wireless.

I've been working on a script to clean out the wireless connections on my MAC. I know the terminal command to do this (that part is not rocket science ;) ) So I thought I would have a go at automating this but I'm having trouble with the 'awk' command & the correct context. My code is := ... (7 Replies)
Discussion started by: Lord Lien
7 Replies

3. Shell Programming and Scripting

Clean up UNIX mail box using script

Hi, I would like to clean up by unix mail mail box thru some script command.. I do know how to delete from mail box ... e.g. $ mail ? d* ? quit But I need to clean up thru some command which I can use in my script before sending any email.. Thanks in advance! (1 Reply)
Discussion started by: pareshkp
1 Replies

4. Shell Programming and Scripting

[SOLVED] help clean up file movement script

Hello Group, Once again another script hacked together from a few sources to try and suit my needs. This is to go through a /temp directory and for each ls entry ask which Dir of three I want it sorted. The script works but there are a few behaviors that are odd so I figured I'd ask for help... (2 Replies)
Discussion started by: dpreviti
2 Replies

5. Shell Programming and Scripting

Need a shell script to clean data

Hi, Appreciated if anyone can throw some hint I have a file format like this: old(1): PRCNCP 1 old(2): PRSKU ... (6 Replies)
Discussion started by: netbanker
6 Replies

6. Shell Programming and Scripting

Script to FTP,clean up and email

Hi i need a unix script to do the following tasks. My folder structure is /home/MSTR/test and will have the following folder within it Cache Lookup Source Target 1. On the Source & Target folder i have to take a copy of files older than 5 days and move(FTP) it into local machines C:\Backup... (1 Reply)
Discussion started by: Codesearcher
1 Replies

7. Shell Programming and Scripting

Script to clean nmon logs on AIX

I use NMON (Nigels Monitoring) in AIX. It creates a daily nmon log with the naming conventions of: hostname_YYMMDD_0000.nmon or myserver_080902_0000.nmon What I am interested in doing is creating a script that is executed on the first of each month to clean up last months *nmon files. .... (4 Replies)
Discussion started by: outtacontrol
4 Replies

8. OS X (Apple)

Startup script to clean out trash can

I need to know how I would be able to clean out the trash can of a single "dumb" user every time the MAC is turned on. Back ground. OS 10.3x G3 Mac Two users configured... 1) Root or Admin (superuser) 2) student (Simple no access to anything but shared folder for files etc.) The problem... (4 Replies)
Discussion started by: Andrek
4 Replies

9. Shell Programming and Scripting

clean up script

I have a script which would monitor a given directory and delete any files which are older than 10 days. I was going to set the 10 crob jobs to perform this operation for 10 different directories (some are actually sub-directories), but my boss doesn't like that idea, so I need to do that in one... (1 Reply)
Discussion started by: mpang_
1 Replies

10. Shell Programming and Scripting

writing script to clean up a directory

I have to do a directory clean up on several machines. The task is as follows: go to a particular directory (cd /xxx) 1. create a directory ' SCRIPTCLEANUP ' ( i KNOW IT) loop through 2. List the directory 3. if directory and start with 'DQA' leave it, 4. if directory or file move it to... (0 Replies)
Discussion started by: ajaya
0 Replies
Login or Register to Ask a Question