Shell Programming and Scripting

Hello, I wanted to delete all files which are placed 14 days back. Here is my below script. My script works very well and it deletes all files 14 days back.

I wanted to display message incase if the delete script is not successful. The below script returns always successful. But the directory /ods/apps/report/download/archive/archive/xxx is wrong one. How can i trap if there is any failure...

Code:

find /ods/apps/report/download/archive/archive/xxx -name "*txt*" -mtime +13 -exec rm -f {} \;
find /ods/apps/report/download/archive/archive/ -name "*TXT*" -mtime +13 -exec rm -f {} \;
if [ $? -ne 0 ];
then
echo "NOT SUCCESSFUL"
else
echo "SUCCESSFUL"
fi

To keep the forums high quality for all users, please take the time to format your posts correctly.

First of all, use Code Tags when you post any code or data samples so others can easily read your code. You can easily do this by highlighting your code and then clicking on the # in the editing menu. (You can also type code tags [code] and [/code] by hand.)

Second, avoid adding color or different fonts and font size to your posts. Selective use of color to highlight a single word or phrase can be useful at times, but using color, in general, makes the forums harder to read, especially bright colors like red.

Third, be careful when you cut-and-paste, edit any odd characters and make sure all links are working property.

Thank You.

The UNIX and Linux Forums

Hello, I am sorry about not following guidelines. I will follow for future posting.
I am sorry for inconvenience. I would appreciate if any one can help me on this.

You have to check the $? everytime, and not at the end.

Say if you want to check the first find execution status, do it immediately after the first find execution. Not at the end...

I got it. Thank you very much.

Here is another possible solution:

Code:

set -e   # the script will exit immediately if one
           # of the following commands will return
           # a non-zero status (be cautious using it in other scripts)

trap "echo FAILED >&2" ERR # will print the word 'FAILED' to /dev/stderr
                                      # if the script will exit with an error

...your find commands ...

echo "SUCCESSFULL" >&2   # print 'SUCCESSFULL' to /dev/stderr
                                     # if we managed to reach the end of the script

Here you don't need to repeat exit status check after each invocation of 'find' command.

Thank you.