Shell Programming and Scripting

Have you exported the variable? If not, child processes will not see it.

In .bash_profile:

Code:

export INSTALL_BASEPATH

Have you exported the variable? If not, child processes will not see it.

In .bash_profile:

Code:

export INSTALL_BASEPATH

Hi cfajohnson

Yes I have already entried in .bash_profile as
export INSTALL_BASEPATH=/vol2/RAORV_HOME

and I check it if I print the value from shell script it works well in cp command it's not working



This is my shell script
When I run it it gives the error in cp ${URL[j]} $distributionName/$dirstructure line

Code:

tempURL=`cat PropertiesFileURL_unix.txt|tr '\n' ' '|tr -d '\r'`
urlCount=(`echo "$tempURL" | sed 's/[^ ]//g' | wc -c` ) 
urlCount=`expr $urlCount - 1`
echo "urlCount------------->"$urlCount
URL=( $tempURL )
distributionName=`echo $INSTALL_BASEPATH|awk -F "/" '{print $NF}'`
ratingdirName=`echo $INSTALL_RATPATH|awk -F "/" '{print $NF}'`

for(( j =0; j< $urlCount ; j++ ))
do
    echo -e "{URL[$j]}------------->"${URL[j]}
    serverName=`echo ${URL[$j]}|awk -F "/" '{print $2}'|tr -d ' ' `
    echo "serverName---------------->"$serverName
    
    if [ $serverName == "abc-5.0" ] 
    then
    dirstructure=`echo ${URL[$j]} | awk -F"/" 'BEGIN{ OFS="/" } {$1="";$NF=""; print $0 }'`
    `mkdir -p $distributionName$dirstructure`
    echo ${URL[j]}
    cp ${URL[j]} $distributionName/$dirstructure
    
    elif [ $serverName == "abcra-5.0" ] 
    then
    dirstructure=`echo ${URL[$j]} | awk -F"/" 'BEGIN{ OFS="/" } {$1="";$NF=""; print $0 }'`
    `mkdir -p $distributionName/$dirstructure`
    
    elif [ $serverName == "abctl-5.0" ]
    then
    dirstructure=`echo ${URL[$j]} | awk -F"/" 'BEGIN{ OFS="/" } {$1="";$NF=""; print $0 }'`
    `mkdir -p $distributionName/$dirstructure`
    elif [ $serverName == "abcbill-5.0" ]
    then
    dirstructure=`echo ${URL[$j]} | awk -F"/" 'BEGIN{ OFS="/" } {$1="";$NF=""; print $0 }'`
    `mkdir -p $ratingdirName/$dirstructure`
    else
    echo "Unknown"
    fi
done

Please help me.......................

When you post code, please wrap it in [code] tags.

tempURL=`cat PropertiesFileURL_unix.txt|tr '\n' ' '|tr -d '\r'`
urlCount=(`echo "$tempURL" | sed 's/[^ ]//g' | wc -c` ) 
urlCount=`expr $urlCount - 1`

You have six external commands in three lines. You need no more than 2. (You never need expr; the shell can do integer arithmetic.)

It's not clear exactly what you are counting, so it's hard to recommend any code.

echo "urlCount------------->"$urlCount
URL=( $tempURL )

Ah!

I think everything up to this point can be replaced with:

Code:

oIFS=$IFS
IFS='
'
URL=( $(tr -d '\r' < PropertiesFileURL_unix.txt) )
IFS=$oOFS
urlCount=${#URL[@]}

See? One external command!

distributionName=`echo $INSTALL_BASEPATH|awk -F "/" '{print $NF}'`
ratingdirName=`echo $INSTALL_RATPATH|awk -F "/" '{print $NF}'`

You don't need awk:

Code:

distributionName=${INSTALL_BASEPATH##*/}
ratingdirName=${INSTALL_RATPATH##*/}

for(( j =0; j< $urlCount ; j++ ))
do
    echo -e "{URL[$j]}------------->"${URL[j]}
    serverName=`echo ${URL[$j]}|awk -F "/" '{print $2}'|tr -d ' ' `
    echo "serverName---------------->"$serverName
    
    if [ $serverName == "abc-5.0" ] 
    then
    dirstructure=`echo ${URL[$j]} | awk -F"/" 'BEGIN{ OFS="/" } {$1="";$NF=""; print $0 }'`

You don't need awk:

Code:

dirstructure=${URL[$j]#*/}
dirstructure=/${dirstructure%/*}/

    `mkdir -p $distributionName$dirstructure`

Why do you have that in backticks?

And are you sure that $distributionName ends with a slash?

    echo ${URL[j]}
    cp ${URL[j]} $distributionName/$dirstructure

Does $distributionName/$dirstructure exist?

    
    elif [ $serverName == "abcra-5.0" ] 
    then
    dirstructure=`echo ${URL[$j]} | awk -F"/" 'BEGIN{ OFS="/" } {$1="";$NF=""; print $0 }'`
    `mkdir -p $distributionName/$dirstructure`
    
    elif [ $serverName == "abctl-5.0" ]
    then
    dirstructure=`echo ${URL[$j]} | awk -F"/" 'BEGIN{ OFS="/" } {$1="";$NF=""; print $0 }'`
    `mkdir -p $distributionName/$dirstructure`
    elif [ $serverName == "abcbill-5.0" ]
    then
    dirstructure=`echo ${URL[$j]} | awk -F"/" 'BEGIN{ OFS="/" } {$1="";$NF=""; print $0 }'`
    `mkdir -p $ratingdirName/$dirstructure`
    else
    echo "Unknown"
    fi
done

This is not HTML; why are you using HTML tags?

Now my parameter file test.txt contain
$INSTALL_BASEPATH/uninstall.sh

and my test script contain following (test.sh)

The previous line is not code; why is it inside code tags?

dir=`cat test.txt|tr -d '\n'`

Why are you using cat? It's an unnecessary external command.

Code:

dir=$( tr -d '\n' < test.txt )

But, since there's only one line in the file, you don't need any external command:

Code:

read dir < test.txt

Why are you calling the variable dir when the file contains a filename, not a directory?

echo "dir============"$dir
mkdir -p resources

You should check that mkdir was successful.

Code:

if ! mkdir resources
then
  printf "could not create directory %s\n" "resources" >$2
  exit 1
fi

You should check it in the script.

Code:

if ! [ -e "$dir" ]
then
  printf "%s\n" "$dir does not exist" >&2
  exit 1
fi

[raorv@qcldb2 test]$ ./test.sh 
dir============$INSTALL_BASEPATH/uninstall.sh
cp: cannot stat `$INSTALL_BASEPATH/uninstall.sh': No such file or directory

In this script, your problem is that $dir will contain a literal '$INSTALL_BASEPATH/uninstall.sh'. The variable is not expanded.

Fix that with:

Code:

eval "dir=$dir"

You probably had the same problem in the original script, but you didn't tell us what was in the file, so we couldn't help you.