Shell Programming and Scripting

Hello,

I'm new to shell scripting so I don't really understand what I'm doing wrong.
The script I'm trying to do saves all the files (*.c) on the current dir to a list and, one by one, copies them to a new one called Backup. The thing is, if there are already other versions of the files I'm copying it changes their names to 'file_name'_000 or 001, and so on...

For instance, if I copy the file aaa.c to the Backup dir and there is already one aaa.c in it, the script changes the name of the copied file to aaa.c_001!

Here's the script...

if [ $# -eq 0 ]

then
lista_actual=*.c

for h in $lista_actual
do

nome_actual=$h
if [ ! -e Backup/$nome_actual_001 ]
then
cp $nome_actual Backup/$nome_actual_001

else

y=Backup/$nome_actual*
i=1
for j in $y
do i=$(($i + 1))
done
x1=$((i/100))
aux=$((x1%100))
x2=$((aux/10))
cp $nome_actual Backup/$nome_actual_$x1$x2$i
fi
done

fi

So... can you help me out? :P

Just a snippet:

Code:

for file in *.c
 do if [ -e backdir/$file ]
 then 
  mv "$file" backdir/"$file"_001; 
 else 
  mv "$file" backdir/"$file"
 fi; 
done

cheers,
Devaraj Takhellambam

A simple suggestion for your for loop is:

Code:

for nome_actual in ${lista_actual}; do

  nome_number=1
  while [ -e Backup/${nome_actual}_${nome_number} ]; do
    nome_number=`expr ${nome_number} + 1`
  done
  cp ${nome_actual} Backup/${nome_actual}_${nome_number}
    
done

It does not give you the leading zeros you were using and all the backup files will have a number suffix but otherwise fits the bill and keeps things simple.

Thank you both, particularly you Tony!

One thing, on my script if I do echo $nome_actual_$x1$x2$i * it only prints $x1$x2$i (the numbers), but if I do like you suggested echo ${nome_actual}_$x1$x2$i ** it prints both the file name and the numbers...

* the result would be, in example, 002.

** in this case it shows xx.c_002 like it is supposed to!

Why? What's the purpose of the { ... }?

The braces { and } denote that what is inside them is the variable name, it is good practice to always use them for variables in shell scripts.

Ah! I thought the $ did that already... Thanks once again! :P

You are correct, I did not make myself clear, the dollar says here follows a variable, the braces show the start and end of the variable name.