sh syntax error unexpected token done


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting sh syntax error unexpected token done
# 1  
Old 04-30-2009
sh syntax error unexpected token done

I'm getting the following error:

Code:
line 21: syntax error near unexpected token `done`
line 21: `done`

and I haven't been able to figure out why.

Here is my code

Code:
#!/bin/sh
if [ $# -lt 2 ]; then
	echo 'Usage: rename getexp/replStr[list-of-files]'
	exit 0
fi
arg = $1
shift
while [ $# -ge 1 ]; do
	if [ -w $1 ]; then
		newFile=$1 | sed "s/$arg/"
		mv $1 $newFile
	else
		echo "$1 does not exist as a writable file"
		exit 0
	fi
	shift
done

Sorry if there is some obvious mistake in my code, this is more or less my first shell script.
# 2  
Old 04-30-2009
Code:
newFile=$1 | sed "s/$arg/"

I am not sure what exactly you are trying to do here but this is wrong.

perhapes you wanted to do
Code:
cat $1 | sed 's/$arg/replace/g'

cheers,
Devaraj Takhellambam
# 3  
Old 04-30-2009
Quote:
arg = $1
Also remove the spaces either side of the "=".

Code:
arg=$1

# 4  
Old 04-30-2009
Quote:
while [ $# -ge 1 ]; do
Should be

Code:
while [[ $# -ge 1 ]]; do

# 5  
Old 04-30-2009
Quote:
Originally Posted by methyl
Should be

Code:
while [[ $# -ge 1 ]]; do

why is that?
# 6  
Old 04-30-2009
In this context we just want to stop the while loop when a condition is reached. In this context either syntax would work. However using [[ ... ]] with while is a good habit because in some old shells any variables created within a [ ... ] loop are not available after the loop finishes.

The syntax within the brackets is governed by different rules (see man sh).
Coincidentally the syntax for some test commands is the same as the syntax for some conditional expressions (including -ge ).

Code:
[[ conditional expression ]]

[ test ]

Qualification: I have just tried both with an ancient /bin/sh and the my [[ .. -ge .. ]] syntax does not work at all!
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Ubuntu

Syntax error near unexpected token `('

detect_mouse_mvt.sh /home/andy/bin/detect_mouse_mvt.sh: line 4: syntax error near unexpected token `(' /home/andy/bin/detect_mouse_mvt.sh: line 4: `fh = file('/dev/input/mice')' #!/bin/bash # # fh = file('/dev/input/mice') while True: fh.read(3) print 'Mouse... (15 Replies)
Discussion started by: drew77
15 Replies

2. UNIX for Beginners Questions & Answers

Syntax error near unexpected token

Dears, While executing the below script im getting the error at line 30. Please let me know what changes to be done to fix this. test.sh: line 30: syntax error near unexpected token `done' test.sh: line 30: ` done ' #!/bin/sh # Rev. PA1 # author: eillops # date: 26-04-2018 # #... (1 Reply)
Discussion started by: Kamesh G
1 Replies

3. How to Post in the The UNIX and Linux Forums

Syntax error near unexpected token `('

I have 2 files like a.txt and b.txt and the content is as below cat a.txt 810750125 117780 /BSCSQAT4A/bscsqat4a/lib/jar/wclt_common.jar 1803152428 13300 /BSCSQAT4A/bscsqat4a/lib/jar/WFMSSupportTool.jar 2663502779 67049 /BSCSQAT4A/bscsqat4a/lib/jar/wma.jar 687942896 665272... (1 Reply)
Discussion started by: ranabhavish
1 Replies

4. Shell Programming and Scripting

Syntax error near unexpected token

Hi all, I have a simple script that doesn't work somehow. I can't seem to be spotting the cause of the malfunction. count=$((1)) for item in `cat test1.txt` printf %s `sed -n $((count))p test2.txt` > test3.txt count=$((count+1)) do something done I get ; ./why.sh: line 3:... (14 Replies)
Discussion started by: y33t
14 Replies

5. Shell Programming and Scripting

Syntax error near unexpected token '('

I tried to execute the code but I got this error ./Array.c: line 9: syntax error near unexpected token '(' ./Array.c: line 9: ' nvals = get_data(a,MAXARRAY);' and #include<stdio.h> #define MAXARRAY 1000 main() { int a, nvals; nvals =... (7 Replies)
Discussion started by: sgradywhite
7 Replies

6. Shell Programming and Scripting

Syntax error near unexpected token `else'

Hi, I am trying to read the session log through script. But it keeps showing me some error near. I have tried everything. Even tried converting the script using sed command to remove the hidden characters(\r).But nothing seems to be working.Below is the script : #!/bin/bash cd... (6 Replies)
Discussion started by: Aryan12345
6 Replies

7. Shell Programming and Scripting

Syntax error near unexpected token `('

What do I do here? #!/bin/bash payload=-1 AND 1=IF(21,BENCHMARK(5000000,MD5(CHAR(115,113,108,109,97,112))),0)# hash=`echo -n $payload md5sum tr -d 'n' sed 'ss-sg' md5sum tr -d 'n' sed 'ss-sg'` curl --data cs2=chronopay&cs1=$payload&cs3=$hash&transaction_type=rebill... (2 Replies)
Discussion started by: iiiiiiiiiii
2 Replies

8. Shell Programming and Scripting

syntax error near unexpected token `='

Hi all, This is a script which converts hex to bin. However am finding an error while executing syntax error near unexpected token `=' `($hexfile, $binfile) = @ARGV;' I am running using ./fil.pl <hexfile> <binfile> ################################################### # # this script... (3 Replies)
Discussion started by: jaango123
3 Replies

9. UNIX for Advanced & Expert Users

syntax error near unexpected token '{

Hi, I am running the following script through cygwin and getting below mentioned error. ******************************************* #!/bin/sh # constants WORK_DIR="deploy" INFOFILE="deploy.info" INTROFILE="Intro.sh" CMGMT_PKG="com.kintana.cmgmt.deploy" DEPLOY_PREFIX="mitg" ... (2 Replies)
Discussion started by: MandyR
2 Replies

10. Shell Programming and Scripting

Syntax error near unexpected token `('

Guys , This is an output of my script errored out for "Syntax error near unexpected token `(' " Can someone tell me whats wrong with my script. Below is my original script pasted. #!/bin/bash Script Creation Date 01/21/2010 Author baraghun ... (7 Replies)
Discussion started by: raghunsi
7 Replies
Login or Register to Ask a Question

Featured Tech Videos