Shell Programming and Scripting

It has been asked for "I've a lot of file with an hyphen on filename, "

yes, so have you actually tested your command out.? create some files with hyphens as well as spaces in their filename (and in different directories since you are using find). then run your command and see if it turns out well?

See my friend, the request is not for replacing filenames with spaces to "-".
The problem here is to replace "-" to "_".Please read the first post.

I have tested my script for this purpose and it works fine.


Thanks.

i know. what i am saying is, IF he has files like these:

Code:

# ls -ltr
total 4
-rw-r--r-- 1 root root    0 Apr  4 10:32 file1 - test.txt
drwxr-xr-x 2 root root 4096 Apr  4 10:34 test

# ls -1R *
file1 - test.txt

test:
file - file1 - sdfdf.txt
file2-text.txt

# find . -name "*-*" |awk '{ src=$0; gsub(/-/,"_",$0); system("mv "src" "$0); }'
mv: target `test.txt' is not a directory
mv: target `sdfdf.txt' is not a directory

see what i mean?

Version to deal with spaces in filenames and an unknown number of files.

#!/bin/ksh
find . -name \*\-\* -type f -print | while read FILENAME
do
NEW_FILENAME=`echo "${FILENAME}"|sed -e "s/-/_/g"`
# Remove echoes only if you are tested and happy
echo "OLD FILENAME: ${FILENAME}"
echo "NEW FILENAME: ${NEW_FILENAME}"
echo mv "${FILENAME}" "${NEW_FILENAME}"
done

thanks