Correct, those values are of (E4, G4, F4). But with "row_no += 1", shouldnt it pick up the values from the next row ?
...
...
No, it should not.
It will not.
No programming language will do that for you.
Golden rule of programming => a programming language will only do what you tell it to do. It will not do anything on its own.
Quote:
Originally Posted by nans
...
I thought this while loop meant 'go to row 4, if the row matches the score from the dictionary, print the value or else print unknown and then go on to the next row and do the same'
...
The "while" loop is only for repeating a "set of actions" while a "condition" is true.
The repetitive "set of actions" is:
1) going to next row
2) determining pos value, alt value, ref value for the row we reached
3) constructing the cpos value from the 3 values determined in the step above
4) checking if this cpos value is in the dictionary dict_pos
5) setting the value of "score" cell in the row that we are now
Since 1) through 5) are repetitive, we work on the entire spreadsheet, but one row at a time.
Inside a "while" loop, we are only working on one row - the current row.
The "condition" is: either pos value is non-empty or alt value is non-empty or ref value is non-empty.
As you can see, the structure of a "while" loop is very generic (repeat a set of actions while a condition is true), so it can be used in a wide variety of situations in any programming language.
Quote:
Originally Posted by nans
...
...
How would I recalculate the values in a loop for all rows ?
Code:
while row_no <=10:
if (dict_pos.has_key(cpos)):
NG = dict_pos[cpos]
#print dict_pos[cpos]
else:
NG = 'Unknown_' + datetime.now().strftime("%B") + datetime.now().strftime("%Y")
row_no += 1
print row_no
cpos = Scores(POS=cell_pos.value, ALT=cell_alt.value, REF=cell_ref.value)
print cpos
wb.save(sheet_xl_file)
...
...
Old proverb: "How to eat an elephant? One bite at a time."
As I mentioned earlier, inside a loop, you only have to calculate the pos, alt and ref values for one row - the current row, the row you are on.
Now, for row_no = 4, you had a few statements that calculated cell_pos, cell_alt and cell_ref. Then you calculated "cpos" from those cell_pos, cell_alt and cell_ref values.
You need those statements inside the "while" loop.
So once the row_no is incremented inside the loop, you:
1) determine the cell_pos, cell_alt and cell_ref
2) next you calculate the cpos using cell_pos, cell_alt and cell_ref
This will be your "cpos" - only for the current row.
When printed, you will see different values of cpos - printed one at a time from within your "while" loop.
(The output that I showed in my earlier post was not printed in one shot - it was printed during each iteration of the loop - one line printed per iteration.)
Last edited by durden_tyler; 07-03-2017 at 01:05 PM..
This User Gave Thanks to durden_tyler For This Post:
okay, I'm getting there now slowly! But why isn't it saving the results to the excel sheet ?
...
Yes, much better.
Now you are able to capture the values of E,G,F columns of every row you are going through.
As for saving the results, here are a few things you need to know about "openpyxl" module.
It has classes like "Workbook", "Worksheet", "Cell" etc. in it.
If "ws" is a "worksheet" object, then:
Code:
ws['V4']
is the cell object 'V4' in the worksheet.
The cell object has many attributes like "value", "fill", "comment" etc.
If you want to make changes to a cell, you set its attributes.
So, to set the cell's value, you set its "value" attribute. For example:
Code:
ws['V4'].value = 'Hello, World!'
will set the value of the cell 'V4' to 'Hello, World!'
assigns the value of the cell object 'V4' to variable NG. Edit: Sorry, this should read: "assigns the cell object 'V4' to variable NG."
However, this line:
Code:
NG = dict_pos[cpos]
sets the cell, not the cell's value.
Another thing => you need to recalculate "NG" inside the loop every time "row_no" increases.
Also => remove the second "if .. else" statement inside the "while" loop.
Last edited by durden_tyler; 07-04-2017 at 07:37 PM..
Reason: Incorrect statement about assignment. Edited statement is in red.
This User Gave Thanks to durden_tyler For This Post:
if (dict_pos.has_key(cpos)):
NG.value = dict_pos[cpos]
else:
NG.value = 'Unknown_' + datetime.now().strftime("%B") + datetime.now().strftime("%Y")
print NG
One last question, right now the code is reading rows which don't have values and ends up in a loop. For now I have the rows limited to 'while row_no <=10:' but different excel sheets have different row limits, some have 50, some have 100, how can I amend this ?
if (dict_pos.has_key(cpos)):
NG.value = dict_pos[cpos]
else:
NG.value = 'Unknown_' + datetime.now().strftime("%B") + datetime.now().strftime("%Y")
print NG
One last question, right now the code is reading rows which don't have values and ends up in a loop. For now I have the rows limited to 'while row_no <=10:' but different excel sheets have different row limits, some have 50, some have 100, how can I amend this ?
Awesome!
So the final step is just some tweaking in the "while <condition>" clause.
I had suggested the condition: "while row_no <= 10" so that you could see the "cpos" value for the first few rows (7 rows actually: row_no 4 through 10).
Otherwise, the "infinite loop" was printing lines too fast and it can be difficult to understand what's happening in that case.
The "infinite loop" problem still remains. The "row_no <= 10" was just a temporary patch.
Now, if you look at post # 36 in this thread, I had mentioned the working of a "while" statement.
The "while" statement repeats a set of actions while a condition is true.
So ask yourself this: in any worksheet, until when should I keep looking at the values of E, G, F cells and form the key and check against "dict_pos"?
If you were to update your worksheet manually, then up to what point would you go? When would you stop?
The answer to that question will decide what you want to put in the "while" condition.
If you ask me, I would do it manually until one of the cells E, G or F is empty. The moment one or more of them is empty, I would stop.
But I don't know what your requirements are.
Maybe you want to go until all the cells E, G, and F are empty.
So your condition will differ from mine.
Either way, you will have to work with using cell values in the while condition.
Have a look at post # 4 of this thread where I posted the first program.
In that program, I test the cell value in the while condition.
Use it to form your "while" condition.
Post your attempt or ask a question if you find it difficult to continue.
This User Gave Thanks to durden_tyler For This Post:
Great. I've changed it to 'while cell_pos.value:' and this works just perfect for my script.
Out of curiosity if I wanted to say go until all the cells E, G, and F are empty, how would I go about that ?
I really appreciate how tolerant you have been and extremely helpful since the past couple of weeks following up on my issues and helping me out with tutorials. Thank you, thank you very much and good luck and best wishes! :-)
Great. I've changed it to 'while cell_pos.value:' and this works just perfect for my script.
Out of curiosity if I wanted to say go until all the cells E, G, and F are empty, how would I go about that ?
...
Congratulations!
Code:
while cell_pos.value:
will run the "while" loop as long as cell_pos.value is True that is, it is non-empty.
In order to check "all of cells E, G, F are empty" we use the logical operator "and" to combine the three cell values:
1) cell_pos.value
2) cell_alt.value
3) cell_ref.value
Such a condition is called a "compound" condition.
So:
Code:
while cell_pos.value and cell_alt.value and cell_ref.value:
will enter the "while" loop as long as all of cells E, G, F are non-empty i.e. they have some value in them. The moment any one of the cells E, G, F is empty, the loop stops.
and
Code:
while cell_pos.value or cell_alt.value or cell_ref.value:
will enter the "while" loop as long as any one of cells E, G, F is non-empty. The moment all of cells E, G, F are empty, the loop stops.
Your program will loop through the rows checking only pos value.
So if, in a row, the pos value is non-empty but alt and/or ref values are empty, it will still form the key and try to check if the key exists in the dictionary dict_pos.
This may or may not work, depending on how the dictionary was formed from "scores.txt" text file.
Here's the complete program for your reference:
Code:
#!/usr/bin/python
import os
import csv
from openpyxl import load_workbook
from datetime import datetime
from collections import namedtuple
# Variables
sheet_directory = '<absolute_path_till_sheet_directory>'
txt_file = '<absolute_path_till_text_directory>/scores.txt'
def process_xl_sheets():
# Process the text file and form the dictionary of positions
dict_pos = {}
Scores = namedtuple("Scores", ["POS", "ALT", "REF"])
first_line = True
with open(txt_file) as txt_filename:
for line in txt_filename:
if not line.strip(): # Skip empty lines
continue
if first_line: # Skip the header
first_line = False
continue
line = line.rstrip('\n')
x = line.split('\t')
cpos = Scores(POS=x[0], ALT=x[2], REF=x[1])
dict_pos[cpos] = x[3]
# Now process all Excel files
pos_col_no = 'E'
alt_col_no = 'G'
ref_col_no = 'F'
score_col_no = 'V'
row_no = 4
for sheet_root, sheet_dirs, sheet_files in os.walk(sheet_directory):
for sheet_file in sheet_files:
if sheet_file.endswith('.xlsx'):
sheet_xl_file = os.path.join(sheet_root, sheet_file)
wb = load_workbook(sheet_xl_file, data_only=True)
ws = wb.get_sheet_by_name('raw_data')
pos = ws[pos_col_no + str(row_no)].value
alt = ws[alt_col_no + str(row_no)].value
ref = ws[ref_col_no + str(row_no)].value
while pos or alt or ref:
cpos = Scores(POS=str(pos), ALT=alt, REF=ref)
if cpos in dict_pos:
ws[score_col_no + str(row_no)].value = dict_pos[cpos]
else:
ws[score_col_no + str(row_no)].value = 'Unknown_' + datetime.now().strftime("%B") + datetime.now().strftime("%Y")
row_no += 1
pos = ws[pos_col_no + str(row_no)].value
alt = ws[alt_col_no + str(row_no)].value
ref = ws[ref_col_no + str(row_no)].value
wb.save(sheet_xl_file)
# Main section
process_xl_sheets()
Last edited by durden_tyler; 07-05-2017 at 01:10 PM..
Reason: You learn about the gaps in your thinking by reviewing what you wrote earlier... :)
This User Gave Thanks to durden_tyler For This Post:
Source Code of the original script is down below please run the script and try to solve this problem
this is my data and I want it column wise
2019-03-20 13:00:00:000
2019-03-20 15:00:00:000
1
Operating System
LAB
0
1
1
1
1
1
1
1
1
1
0
1 (5 Replies)
Hi experts -
I'm relatively new to python, but I have an requirement to automate getting a file from a WebLib server using an API.
The file I'm requesting from this sever is an excel spreadsheet (.xlsx).
I get a valid response back via an xml doc from the server.
In this xml file I get... (8 Replies)
Hi,
I have a requirement to append = in particular row in csv file. Data in csv is as follow:
row1,a,a,a
row2,b,b,b
row3,c,c,c
row4,d,d,d
csv should be modified at row3 and no. of columns are not fixed but rows are. output should be as:
row1,a,a,a
row2,b,b,b
row3,=c,=c,=c... (2 Replies)
Hi All,
Input.txt
KGO
Id "003"
..........
..........
Par "CPara"
BIN RECGET
Name "DIR_PATH"
Prompt "DIR_PATH"
END RECGET
KGO
............
..........
...............
KGO
Id "077"
..........
.......... (7 Replies)
I have a text file where I want to append a column of numbers in ascending orders.
Input:
57 abc
25 def
32 ghi
54 jkl
Output:57 abc
57 abc 1
25 def 2
32 ghi 3
54 jkl 4
How do I go about doing that? Thanks! (11 Replies)
Hi, i want to add another column to existing files containing strings and need to have the final output as a csv file. i have quite a number of files, each with varying number of rows and i need to append the string "test" for all the valid rows for each file. my sample raw files looks like this... (8 Replies)
Hi ,
I have a file with a running sequence number. I need to append a date value mmdd format on to the first column.
for e.g.: The file contains records as
001 abc
002 cde
003 edf
004 fgh
005 hik
The output should be
1111001 abc
1111002 cde
1111003 edf
1111004 ... (1 Reply)
Hi all,
I have two files with the same number of lines
the first file is a.dat and looks like
0.000 1.000
1.000 2.000
...
the fields are tab separated
the second file is b.dat and looks like
1.2347 0.546
2.3564 0.321
...
the fields are tab separated
I would like to have a file c.dat... (4 Replies)
Hi , I have the below file with 6 columns.I want to append 'File1' as the 1 column to the file. i have the sample code .It is not working . can u please correct this or make new one .....
awk 'print {'File1',$1,$2,$3,$4,$5,$6}' Source_File> Result_File
Source_File:... (6 Replies)
It appears that this has been asked and answered in similar fashions previously, but I am still unsure how to approach this.
I have two files containing user information:
fileA
ttim:/home/ttim:Tiny Tim:632
ppinto:/home/ppinto:Pam Pinto:633
fileB
ttim:xkfgjkd*&#^jhdfh... (3 Replies)