unable to send a char parameter from main to a function


 
Thread Tools Search this Thread
Top Forums Programming unable to send a char parameter from main to a function
# 1  
Old 10-13-2011
unable to send a char parameter from main to a function

why does this not work?

Code:
#include <stdio.h>
#include <stdlib.h>


char getFileMode(char charChanger) {

  char filetype; /*var to hold the value to be returned*/ 
  filetype = charSetter; /*set filetype to "l" if it is a symlink*/
 
return filetype;

}

int main(void){

char type = 0;

char     dir = 'd', 
        file = 'f', 
        slink = 'l', 
        charChanger=0;
        
        charChanger =  file;
        
    getFileMode(charChanger);
    
    printf("type is %c\n", type);
    
return 0;
}


Last edited by bluetxxth; 10-13-2011 at 09:15 AM.. Reason: simplified version
# 2  
Old 10-13-2011
charSetter is undefined for starters.

However, please define does not work. What EXACTLY are you trying to do?
Hint: it looks like you need to call stat() against an actual filename
Code:
#include <sys/stat.h>
char charSetter(char *filename)
{
     struct stat st;
     char retval='';
     if(stat(filename, &st ) == -1)
     {
             fprintf(stderr, "Cannot stat %s\n", filename);
             perror("");
             exit(1);
      }
      if (S_ISLNK(st.st_mode) )
          retval='l';
      return retval;
}

# 3  
Old 10-13-2011
Hi Jim thank you for your reply!
I actually thought that what I had done was the problem but I think it is actually getopt() I will try to explain:
this first code takes care of a var that is set to either d,f or l (dir, file, or slink) the desired option in getopt().

Code:
char getFileMode(char charSetter) {
    char fileType = 0; /*var to hold the value to be returned*/ 
    charSetter=0;
    fileType = charSetter;    
    return fileType; /*end function */
}

Then I have a function where I do all the tests to see if I can open a dir do lstat and then test for S_ISDIR, S_ISREG and S_ISLNK.

All seems to work fine in it.

This is the prototype of the funcion.

Code:
void dirTreeWalker(char fileType, char *dirName, char charSetter);

This is what it does
Code:
1.1 open dir
   1.2  if dp == NULL print ERROR
 2.1 else while dp != NULL 
    2.2 if  not ".." and  not "."  lstat
    2.3 if  lstat(path, &info) < 0) print error
    2.4 if ((S_ISDIR(info.st_mode))&&(fileType == 'd')) print path
         else if ((S_ISREG(info.st_mode))&&( fileType == 'f')) print path
         else if ((S_ISLNK(info.st_mode))&&(fileType == 'l')) print path
    2.5 else print all thre options
    2.6 closedir

So long for that function, I have tested it on its own and it works.

However, and here is the problem I think...

When I use getopt like I do as follows I don't get to see the directories nor the files. It is as if charSetter does not get assigned any value.

Code:
    /*this set of vars for getopt*/
    int c;
    char *options = "t::dfl";
    extern char *optarg;
    extern int optind, optopt, opterr;
    char dir = 'd', 
        file = 'f', 
        slink = 'l', 
        charSetter = 0;

    /*this set of vars for the traversal and the test*/
    char fileType = 0;
    char *dirName = argv[argc-1];
    /* char *fileName =  */

while ((c = getopt(argc, argv, options)) != -1) {
    switch (c) {
        case 't':
            optarg = options;
            printf("Type is set: %c\n", charSetter);
            printf("option: %c\n",c);
            break;
            
        case 'd':
            printf("d is set\n");
            charSetter = dir;
            break;

        case 'f':
            printf("f is set\n");
            charSetter = file;
            printf("\ntype of file is f %c\n", fileType); /*test to be removed*/
            break;

        case 'l':
            printf("l is set\n");
            charSetter = slink;
            printf("\ntype of file is l %c\n", fileType); /*test to be removed*/
            break;

        case ':':
            printf("-%c without type\n", optopt);
            break;

        case '?':
            printf("unknown arg %c\n", optopt);
            fprintf(stderr, "Unrecognized option: -%c\n", optopt);
    }

}
    int i;
    for(i=1;i<argc;i++){
    printf("argv: %s\n",argv[i]);
    }

    for (; optind < argc; optind++) {
     fileType = getFileMode(charSetter);
     dirTreeWalker(fileType, dirName, charSetter);
    }


Last edited by bluetxxth; 10-13-2011 at 11:50 AM.. Reason: error
# 4  
Old 10-13-2011
We can't see your computer from here, you need to post the function contents too.

We don't even know what any of those global variables you're setting are.

It's a very bad idea to have a function that exists to do nothing but set global variables. Usually that means your programming model is a bit off somewhere. Honestly, this makes me suspect your other code as well, tested or not.

Code:
    charSetter=0;
    fileType = charSetter;

Why do you bother passing charSetter if the very first thing you do is set it to zero? You'll never get anything but zero out of it.
# 5  
Old 10-13-2011
Thank you all for the reply!

Sorry I copied that from my notepad in the wrong order... however, where I am having my problem is right here. When I run this part getopt() I don't get the return variable.
Code:
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <string.h>
#include <sys/stat.h>
#include <sys/types.h>
#include <dirent.h>
#include <errno.h>
#include <ctype.h>
#include <stdbool.h>

char getFileMode(char charSetter) {

    char fileType = 0; /*var to hold the value to be returned*/ 
    
    fileType = charSetter;
    
    return fileType; /*end function */
}

int main(int argc, char *argv[]) {

    /*this set of vars for getopt*/
    int c;
    char *options = "t::dfl";
    extern char *optarg;
    extern int optind, optopt, opterr;
    char dir = 'd', 
        file = 'f', 
        slink = 'l', 
        charSetter = 0;
    
    /*this set of vars for the traversal and the test*/
    char fileType = 0;
    char *dirName = argv[argc-1];

    if (argc < 2) {
        printf("mfind [-t type] start1 [start2 ...] name \n"); /*usage*/
    }

while ((c = getopt(argc, argv, options)) != -1) {
    switch (c) {
        case 't':
            optarg = options;
            printf("Type is  set to: %c\n", charSetter); /*should be zero*/
            printf("option: %c\n",c);
            break;
            
        case 'd':
            printf("d is set\n");
            charSetter = dir;
            break;

        case 'f':
            printf("f is set\n");
            charSetter = file;
            
            break;

        case 'l':
            printf("l is set\n");
            charSetter = slink;
            
            break;

        case ':':
            printf("-%c without type\n", optopt);
            break;

        case '?':
            printf("unknown arg %c\n", optopt);
            fprintf(stderr, "Unrecognized option: -%c\n", optopt);
    }

}
    int i;
    for(i=1;i<argc;i++){
    printf("argv: %s\n",argv[i]);
    }

    for (; optind < argc; optind++) {
     fileType = getFileMode(charSetter);
        printf("the filetype is %c", fileType);
    }

return (0);
}

I was trying to do something like this but with getopt() in the program below when I set the values for cahrSetter manually it works fine.

Code:
#include <stdio.h>
#include <stdlib.h>


char getFileMode(char charChanger) {

  printf("charChanger has  %c\n", charChanger);
  
  char *filetype; /*var to hold the value to be returned*/ 
  
  filetype = charChanger; /*set filetype to 'l'*/
  
return filetype;

}

int main(void){

char type = 0;

char     dir = 'd', 
        file = 'f', 
        slink = 'l', 
        charChanger=0;
        
    charChanger =  file;
    type = getFileMode(charChanger);
    printf("type is %c\n", type);
    
return 0;
}

---------- Post updated at 11:04 AM ---------- Previous update was at 10:33 AM ----------

Sorry guys for my lack of attention ... it seems that I had not included the library Smilie

Code:
#include <getopt.h>

However, running the program see that the type is set to ^@ which does not make sense if I for example choose -td in which case the type should be 'd'.
# 6  
Old 10-13-2011
I think you're very confused about variables, assignments, and return values, not just how getopt works. I continue to suspect the existence of latent bugs in your treewalker function, whether it works for you right now or not. Please post your entire code, not just the bits you think I need to know.

Your 'dir', 'file', and 'slink' variables are useless, you already know what 'c' is.

You shouldn't be setting optarg, you should be using optarg.

I still cannot fathom the purpose of your getFileMode function. You just return the same value you get, after setting a local variable, which changes nothing outside the function. What is it supposed to be doing?

Code:
switch (c) {
        case 't':
            // c isn't an ASCII 0, it's an ascii NULL.  If you want it to print 0,
            // initialize c to c='0' at the start of main.
            printf("Type is  set to: %c\n", charSetter); /*should be zero*/

            // the option string appears in optarg.
            printf("option:  %s\n", optarg);
            break;
            
        case 'd':
        case 'f':
        case 'l':
            charSetter=c;
            printf("%c is set\n", charSetter);
            break;
        default:
            fprintf(stderr, "Uknown option\n");
            exit(1);
        }

---------- Post updated at 10:58 AM ---------- Previous update was at 10:55 AM ----------

If your variables were an attempt to organize it, I think enums are closer to what you want. They even work in switch statements.

Code:
enum
{
        TYPE_DIR='d',
        TYPE_FILE='f', 
        TYPE_SLINK='l',
        TYPE_T='t',
};

...

switch (c) {
        case TYPE_T:
            // c isn't an ASCII 0, it's an ascii NULL.  If you want it to print 0,
            // initialize c to c='0' at the start of main.
            printf("Type is  set to: %c\n", charSetter); /*should be zero*/

            // the option string appears in optarg.
            printf("option:  %s\n", optarg);
            break;
            
        case TYPE_DIR:
        case TYPE_FILE:
        case TYPE_SLINK:
            charSetter=c;
            printf("%c is set\n", charSetter);
            break;
        default:
            fprintf(stderr, "Uknown option\n");
            exit(1);
        }

# 7  
Old 10-13-2011
Hi Corona,

Thank you much for the explanation... you are right I am very confused and specially with pointers :-/ but hopefully I will some day get there... I think I have partially solved the problem... I did not understand how getopt worked and yes I gues 'c' was the return value.

In any case this is what I wanted to do ... sorry for not posting it before but I really wanted to give it a try before. What it does is it parses options and it prints either dir, file, or slink accordingly.

Last edited by bluetxxth; 10-13-2011 at 02:36 PM..
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

A function that refuses to run anywhere else but main()

Hi. I have some code, that for some reason, I could not post it here in this post. Here's the address for it: #if 0 shc Version 4.0.1, Generic Shell Script Compiler GNU GPL Version 3 Md - Pastebin.com First off, I used "shc" to convert the code from shell script to C. And The... (6 Replies)
Discussion started by: ignatius
6 Replies

2. Programming

A single statement without main function in c

A sample.c file is written with only one single statement. main; Segmentation fault occurred when executed that file. Any statement other than main; is written, for example unix; then it won't compile. why is this behaviour ! (2 Replies)
Discussion started by: techmonk
2 Replies

3. UNIX for Dummies Questions & Answers

[ksh93+] Array fed by function is empty when used in main.

I feel that i am missing something obvious but i can't find what is wrong. I have a script that is launching some functions with "&" and each call is feeding the array with a value. When all calls are finished I just want to retrieve the values of that array. It is looking like that : ... (5 Replies)
Discussion started by: bibou25
5 Replies

4. AIX

Calling functions from main program from dlopened library function

Hello All, I am trying to call a function from the calling main program from a dlopened library function, below is the entire code, when I execute it it crashes with sigill. Can you guys help me out I guess I am missing out on the linker flag or something here. besides I am new to AIX and... (1 Reply)
Discussion started by: syedtoah
1 Replies

5. Programming

Function main returning int?

H friends, As we know, a function returns a value and that value is saved somwhere. like int Sum( int x, int y ) { return x + y; } Total = Sum( 10, 20 ); The value 30 is saved in variable Total. Now the question is, what int value does the function main return, and where is it... (5 Replies)
Discussion started by: gabam
5 Replies

6. Programming

How to access argv[x] from another function other than main???

Hi friends, when I am passing arguments to main, I want another function to be able to have access to that function, the problem is that I am creating athread, which has a function like void *xyz(void *), how can pass the refernce of argv to this function, if you see my program, you will better... (2 Replies)
Discussion started by: gabam
2 Replies

7. Shell Programming and Scripting

Help in separating variables declared in the main function

Hi! I've a C program as shown below.. The line numbers and the statements of the program are separated by a space.. 1 #include<stdio.h> 2 char a,b,c; 3 float x,y,z; 4 int main() 5 { 6 int d,e,f; 7 // further declarations 8 // further declarations 9 /* body*/ 10 } 11 void fun1() 12... (1 Reply)
Discussion started by: abk07
1 Replies

8. Programming

signal handling while in a function other than main

Hi, I have a main loop which calls a sub loop, which finally returns to the main loop itself. The main loop runs when a flag is set. Now, I have a signal handler for SIGINT, which resets the flag and thus stops the main loop. Suppose I send SIGINT while the program is in subloop, I get an error... (1 Reply)
Discussion started by: Theju
1 Replies

9. Programming

main function

Is it possible to execute any function before main() function in C or C++. (6 Replies)
Discussion started by: arun.viswanath
6 Replies

10. Programming

c++ calling main() function

i just finished a project for a c++ class that i wrote at home on my computer, compiled with gcc. when i brought the code into school it would not compile, it would complain that cannot call main() function. at school we use ancient borland c++ from 1995. anyway my program has 20 different... (3 Replies)
Discussion started by: norsk hedensk
3 Replies
Login or Register to Ask a Question