Help with sockets in C


 
Thread Tools Search this Thread
Top Forums Programming Help with sockets in C
# 22  
Old 04-01-2011
Quote:
Originally Posted by omega666
your code is only reading one line (as in stops at a \n), but my data that's being sent, can include more than 0 \n's, could that be causing the problem?
You could use something else to mean end-of-message, how about a carriage return, '\r'?

Code:
int pos=0;
bzero(buffer,MAXDATASIZE);

// Stop once we have an entire single record
while((buffer[pos] != '\r') && (pos < MAXDATASIZE))
{
        // Put new data 'pos' bytes ahead, so we don't overwrite the old
        ssize_t b=read(socket_fd, buffer+pos, 1); 
        if(b > 0) pos+=b;
        else break; // b<=0 means socket closed or socket error, so give up.
}

// Remove the carriage return
buffer[pos-1]='\0';

Quote:
maybe somewhere (not at the end) in the data i send, there is a \0...?
I don't think so. You could compare how many bytes you read() against how many bytes str_len sees, if they disagree a lot there's a NULL or newline in the middle.

Wait! That's it! Your str_len function stops at a newline and some of your messages have a newline in the middle!

You still need to divide it into records somehow though. The code can't be relied on if you don't.
# 23  
Old 04-01-2011
i dont understand, the only times i use that str_len is when the strings have no \n inside...



---------- Post updated at 02:21 PM ---------- Previous update was at 02:15 PM ----------

when the problem happens, it stops reading at the first newline that it finds, how do you make it read past it until it finds a \0 ?
# 24  
Old 04-01-2011
Quote:
Originally Posted by omega666
i dont understand, the only times i use that str_len is when the strings have no \n inside...
That's on the server end. receive_message has no way to tell the client how long it is, so the client receives something and uses str_len, which stops at newlines.
Quote:
when the problem happens, it stops reading at the first newline that it finds, how do you make it read past it until it finds a \0 ?
It's because your str_len function stops at newlines. Just use ordinary strlen(), which doesn't.

And you have to separate your records somehow. You simply cannot depend on receiving things in the same size chunks you sent them. It can work the other way too -- you could do two small sends, and do one big receive.
# 25  
Old 04-01-2011
i just changed all of them to strlen, and the problem still occurs

---------- Post updated at 02:51 PM ---------- Previous update was at 02:34 PM ----------

how is read supposed to work, does it normally skip the \n characters?
# 26  
Old 04-01-2011
Quote:
Originally Posted by omega666
i just changed all of them to strlen, and the problem still occurs
You can't just blindly make the changes without making the other fixes I said too. Your code makes a lot of wrong assumptions about the behavior of sockets. It doesn't operate as expected because sockets don't either.
Quote:
how is read supposed to work, does it normally skip the \n characters?
Now you ask, after I've been trying to point it out for weeks...

read() works completely raw. It alters none of the data that passes through it. It doesn't do anything special to nulls or newlines, and nothing in the data makes it stop early. It might stop early for other reasons though, so you have to check its return value, to see if you read as many bytes as you thought you did. write() is the same. completely raw. But you have to check its return value in case it wrote less than you asked it to.
# 27  
Old 04-01-2011
so this should be able to tell me if it wrote properly?
Code:
void send_message(int client_socket_fd, char *message, int length) {
    size_t bytes = write(client_socket_fd, message, length);
    if (bytes != length) error("ERROR writing to socket");
}

?
# 28  
Old 04-01-2011
It's not an error for it to not send it all. If it returns 0 or -1, it's an error.

Code:
void send_message(int client_socket_fd, char *message, int length) {
    int pos=0;

    while(pos < length)
    {
        size_t bytes = write(client_socket_fd, message+pos, length-pos);
        if(bytes <= 0)
        {
            perror("Socket error");
            return;
        }

        pos += bytes;
    }
}

---------- Post updated at 03:57 PM ---------- Previous update was at 03:55 PM ----------

It's not an error to not receive it all, either. You have to keep reading until you know you're done. You don't know how long the message will actually be unless your server tells you somehow, which is why I suggested using \n or \n to mark the end of a record and showed receiving code that looked for that.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Programming

Any example about sockets in C++?

Hi, i am student, think learning about c++, someone has a example the how establish a conection with sockets :b::b: (1 Reply)
Discussion started by: mmartinez
1 Replies

2. Red Hat

Sockets

hai guys, I'm doing a project in which one server communicates with several clients. How can i do it when i have different port numbers???:confused: (0 Replies)
Discussion started by: rajeshb6
0 Replies

3. Programming

Sockets

Hi,i now moved into a different section where i need to use sockets. i am completely nill in sockets. can some body please provide me what are the requirements for a socket. to use sockets in c. thanks (1 Reply)
Discussion started by: MrUser
1 Replies

4. Programming

need help with sockets

anyone and teach me how to save standard output to a file in a client/server socket. I know how to read them to the screen but i'm not quite sure how to save them to a file. my read to screen file code: memset(line, 0x0, LINE_ARRAY_SIZE); while (recv(connectSocket, line, MAX_MSG, 0) >... (1 Reply)
Discussion started by: crunchyuser
1 Replies

5. IP Networking

sockets and firewall

Is it possible to trace the packages and the statuses of client's and/or server's sockets by the UNIX network administrative tools? Two applications interact via sockets. There is no problem if they stay in the same network segment. If their hosts connected through the firewall then they aren't... (4 Replies)
Discussion started by: gogogo
4 Replies

6. Solaris

Sockets in use

Is there a way to see what sockets are in use? The developers here are getting some defunct processes and they would like to get a socket list. This is on a Solaris 8 machine. Thanks! (1 Reply)
Discussion started by: kjbaumann
1 Replies

7. UNIX for Dummies Questions & Answers

sockets

how do i mointor how many sockets are opened from a particular foriegn address? (2 Replies)
Discussion started by: kirpond
2 Replies

8. Programming

sockets

Hai, How cani declare socket and collect the data in a string varialbe. Since i am new to this i am asking this. Can we connect multiple port. Thank you. (6 Replies)
Discussion started by: arunkumar_mca
6 Replies

9. Programming

Sockets!?!?!?!?!?!

I am looking for a way to have a program listen on a port (example: 8000) for communication I will be sending via that port to it(Linux Kernel machine). Once it recieves an appropiate command I need it to run a .bat file in linux. I know what I need to do but I am running into a few problems:... (8 Replies)
Discussion started by: bigB8210
8 Replies

10. Programming

sockets...

Hi ! I had a verry simple question to ask... In unix when we create pipes.. the unnamed pipes that is... is there any way to access those pipes outside the code ? Another thing.. do sockets have an entry in the inode table ? TIA, Devyani. (1 Reply)
Discussion started by: devy8
1 Replies
Login or Register to Ask a Question