Help with sockets in C


 
Thread Tools Search this Thread
Top Forums Programming Help with sockets in C
# 8  
Old 03-30-2011
Quote:
Originally Posted by omega666
i mean like
in the while loop do i need to redefine all the sockets declarations?
No. If you put the declarations outside, you can keep and reuse them. [quote]

Quote:
say i want exactly 5 connections
does the
listen(soc,5);
go in the while loop?
No, you only have to do listen() once. The thing which actually gives you new connections, accept(), goes into the loop.
# 9  
Old 03-30-2011
So this is my function (server)
Code:
int main(int argc, char **argv) {
    
    // Set Up
    int socket_fd, new_socket_fd, num; // file descriptors, and port number
    socklen_t client_length; // size of client address 
    struct sockaddr_in serv_addr, cli_addr;
    char buffer[MAXDATASIZE]; // input gets put here

    // Set Up Socket
    for(num=0;num<CONSIGNMENT;num++) client_names[num]=NULL;   // set all to Null 
    bzero(buffer,MAXDATASIZE); // Set all to zero
    socket_fd = socket(AF_INET, SOCK_STREAM, 0); // create a listening socket to the internet
    if (socket_fd < 0) error("ERROR opening socket"); // check the socket
    bzero((char *) &serv_addr, sizeof(serv_addr)); // sets all values in the serv_addr to 0
    serv_addr.sin_family = AF_INET; // set up the information for the server
    serv_addr.sin_addr.s_addr = INADDR_ANY;
    serv_addr.sin_port = htons(PORT);
    if (bind(socket_fd, (struct sockaddr *) &serv_addr, sizeof(serv_addr)) < 0) error("ERROR on binding"); // check the bind
    listen(socket_fd,5); // sets it up for listening, max of 5 waiting connections while one is being handled             
    client_length = sizeof(cli_addr);
    
    while(1) {
        new_socket_fd = accept(socket_fd, (struct sockaddr *) &cli_addr, &client_length); // pause process until client connects
        if (new_socket_fd < 0) error("ERROR on accept"); // check new file descriptor

     // server and client talks....


        close(new_socket_fd); 
    }
    
    close(socket_fd); // close connections with client
    return(0); 
}

is the while loop supposed to be like this, the server should be able to connect with any number of clients, and any of the clients should be about to talk to the server at any time...
# 10  
Old 03-31-2011
That will work but the server will only be able to talk to one client at a time. If you want to handle several simultaneous connections, you'll need to fork() like this:

Code:
int maxproc=5; // Max # of simultaneous connections

{
        int newfd=accept(sock);

        // Handle children without blocking
        while(waitpid(-1, NULL, WNOHANG) >= 0)
        {
                maxproc++;
        }

        // If you've exceeded the maximum, actually wait
        if(maxproc <= 0) waitpid(-1, NULL, 0);

        switch(fork())
        {
        case -1: // Error
                perror("Couldn't fork");
                close(newfd);
                break;
        default: // Parent
                maxproc--;
                close(newfd);
                break;
        case 0: // child
                do_stuff();
                exit(0);
                break;        
        }
}

# 11  
Old 04-01-2011
nvm i fixed it.

---------- Post updated at 09:09 PM ---------- Previous update was at 07:46 PM ----------

how does the select function code work? will it achieve a better result than what you proposed?

also

when running my program, i notice that it works usually, but sometimes the output comes out incomplete even when i haven't changed my code...

i think this may have to do with my code for reading and writing from the sockets

this is what i have, are there any errors?

Code:
void send_message(int *client_socket_fd, char *message, int length) {
    if (write(*client_socket_fd, message, length) < 0) error("ERROR writing to socket");
}

void read_message(int *socket_fd, char *buffer, int display) {
    size_t bytes; 
    if((bytes = read(*socket_fd, buffer, MAXDATASIZE)) < 0) error("ERROR reading from socket");    
    if (display) write(1,buffer,bytes);    
}

display is either 0 or 1 depending on if i want it to be printed to stdout
so after reading from the socket, does the all the data form the socket get removed, or is it better if i manually remove it, maybe if i do that it will fix my problem?



Last edited by omega666; 03-31-2011 at 09:27 PM..
# 12  
Old 04-01-2011
Quote:
How does the select function code work? will it achieve a better result than what you proposed?
It essentially keeps a list of file descriptors and lets you know when any of them are ready. Whether it's "better" depends on what you want to do.
Quote:
this is what i have, are there any errors?
How should I know? Post your complete program!
# 13  
Old 04-01-2011
server
Code:
#include "header.h"
int main(int argc, char **argv) {
    char buffer[MAXDATASIZE]; 
    bzero(buffer, sizeof(buffer)); 
    client *client_list=NULL; item *item_list=NULL;
    item_list = add_item("bike", "8", "70", "5", "False", item_list);
    int socket_fd, client_socket_fd; 
    socklen_t client_length; 
    struct sockaddr_in serv_addr, cli_addr;
    client_length = sizeof(cli_addr);
    bzero((char *) &serv_addr, sizeof(serv_addr)); 
    socket_fd = socket(AF_INET, SOCK_STREAM, 0);
    if (socket_fd < 0) error("ERROR opening socket");
    serv_addr.sin_family = AF_INET; 
    serv_addr.sin_addr.s_addr = INADDR_ANY;
    serv_addr.sin_port = htons(PORT);
    if (bind(socket_fd, (struct sockaddr *) &serv_addr, sizeof(serv_addr)) < 0) error("ERROR on binding"); 
    listen(socket_fd,5);          
    client_socket_fd = accept(socket_fd, (struct sockaddr *) &cli_addr, &client_length);
    if (client_socket_fd < 0) error("ERROR on accept"); 
    read_message(client_socket_fd, buffer, 0); 
    if (already_there(client_list, buffer)==0) {      
        client_list = add_client(buffer, client_list, client_socket_fd); 
        send_message(client_socket_fd, "Enter", 5); 
        write(1, buffer, str_len(buffer)); write(1, " connected!\n", 12); 
        read_message(client_socket_fd, buffer, 0); 
        send_items(item_list, client_socket_fd); 
    }
    else {                                       
        send_message(client_socket_fd, "Leave", 5); 
        write(1, "Rejected incoming client - ", 27); write(1, buffer, str_len(buffer)); write(1, "! (User with same name already connected)\n", 42); 
        read_message(client_socket_fd, buffer, 0); 
    }
    close(client_socket_fd); close(socket_fd); 
    return(0); 
}

In this function, this line:
write(1, buffer, str_len(buffer)); write(1, " connected!\n", 12);
is making the client not read everything from the socket
right now, that line is in the right spot to avoid this problem, but if i move that line one line up or 2 lines up, then the client only reads some of the output.

Last edited by omega666; 04-01-2011 at 02:29 PM..
# 14  
Old 04-01-2011
That can't possibly be your complete code. str_len, add_client, send_message, and read_message aren't defined anywhere.

If you don't know what's going wrong, you don't know why it's going wrong, and don't know what I need to see. Chopping bits out of your code just wastes your time and ours.

I won't ask again. Post your complete program!
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Programming

Any example about sockets in C++?

Hi, i am student, think learning about c++, someone has a example the how establish a conection with sockets :b::b: (1 Reply)
Discussion started by: mmartinez
1 Replies

2. Red Hat

Sockets

hai guys, I'm doing a project in which one server communicates with several clients. How can i do it when i have different port numbers???:confused: (0 Replies)
Discussion started by: rajeshb6
0 Replies

3. Programming

Sockets

Hi,i now moved into a different section where i need to use sockets. i am completely nill in sockets. can some body please provide me what are the requirements for a socket. to use sockets in c. thanks (1 Reply)
Discussion started by: MrUser
1 Replies

4. Programming

need help with sockets

anyone and teach me how to save standard output to a file in a client/server socket. I know how to read them to the screen but i'm not quite sure how to save them to a file. my read to screen file code: memset(line, 0x0, LINE_ARRAY_SIZE); while (recv(connectSocket, line, MAX_MSG, 0) >... (1 Reply)
Discussion started by: crunchyuser
1 Replies

5. IP Networking

sockets and firewall

Is it possible to trace the packages and the statuses of client's and/or server's sockets by the UNIX network administrative tools? Two applications interact via sockets. There is no problem if they stay in the same network segment. If their hosts connected through the firewall then they aren't... (4 Replies)
Discussion started by: gogogo
4 Replies

6. Solaris

Sockets in use

Is there a way to see what sockets are in use? The developers here are getting some defunct processes and they would like to get a socket list. This is on a Solaris 8 machine. Thanks! (1 Reply)
Discussion started by: kjbaumann
1 Replies

7. UNIX for Dummies Questions & Answers

sockets

how do i mointor how many sockets are opened from a particular foriegn address? (2 Replies)
Discussion started by: kirpond
2 Replies

8. Programming

sockets

Hai, How cani declare socket and collect the data in a string varialbe. Since i am new to this i am asking this. Can we connect multiple port. Thank you. (6 Replies)
Discussion started by: arunkumar_mca
6 Replies

9. Programming

Sockets!?!?!?!?!?!

I am looking for a way to have a program listen on a port (example: 8000) for communication I will be sending via that port to it(Linux Kernel machine). Once it recieves an appropiate command I need it to run a .bat file in linux. I know what I need to do but I am running into a few problems:... (8 Replies)
Discussion started by: bigB8210
8 Replies

10. Programming

sockets...

Hi ! I had a verry simple question to ask... In unix when we create pipes.. the unnamed pipes that is... is there any way to access those pipes outside the code ? Another thing.. do sockets have an entry in the inode table ? TIA, Devyani. (1 Reply)
Discussion started by: devy8
1 Replies
Login or Register to Ask a Question