Programming

Try fprintf(stdout,...) instead of stderr. We really need to know.

---------- Post updated at 01:55 PM ---------- Previous update was at 01:49 PM ----------

Everything is working again - the segfaults have gone away. For some reason my new code wasn't being used with the batch job. After a reboot and a rebuild, everything is up and running again.

So other than some of the cleanup you've suggested, all is well.
Before I finish up this defect, do you have any suggestions for improving what we've went over? I know you were concerned about using int for the one method. I've corrected that, and have changed all the headers to use 'socktag' instead.

Not just that method -- every method that takes an int st parameter. I know for sure now -- they will all segfault on this platform, for the same reason, because an integer is not large enough to represent a pointer. The compiler probably warned you about 'conversion from pointer to integer' several times, that's what it meant. If you've done that for all methods which took an integer in lieu of a pointer -- gensock_getchar, gensock_put_data, gensock_put_data_buffered, gensock_put_data_flush, and gensock_close -- that's great. I don't have further suggestions unless/until more bugs crop up.

I did.
Thanks for all of your help!

Wowza, that using an int for a pointer is always ready to bite in the worst times! Plus with AIX's 64 bit model not all pointers have 64 bits worth of data (so sometimes it'll crash and sometimes it'll work great). We found out the hard way, pointers in shared memory were always having issues and it was all because we forgot a header and when you do that the compiler assumes all function arguments are int and truncates as appropriate. Plus, it didn't even complain that the function was used but not defined and didn't until we asked it to warn for everything (at which point we found our devs missed a few other headers, lol).

When you are porting code from an ILP32 programming model to an LP64 programming model, every use of a pointer needs to be checked and changed if necessary.