perl::critic::policy::regularexpressions::prohibitfixedstringmat(3) [centos man page]

Perl::Critic::Policy::RegularExpressions::ProhibitFixedSUsergContributed PePerl::Critic::Policy::RegularExpressions::ProhibitFixedStringMatches(3)

NAME

       Perl::Critic::Policy::RegularExpressions::ProhibitFixedStringMatches - Use "eq" or hash instead of fixed-pattern regexps.

AFFILIATION

       This Policy is part of the core Perl::Critic distribution.

DESCRIPTION

       A regular expression that matches just a fixed set of constant strings is wasteful of performance and is hard on maintainers.  It is much
       more readable and often faster to use "eq" or a hash to match such strings.

	   # Bad
	   my $is_file_function = $token =~ m/A (?: open | close | read ) z/xms;

	   # Faster and more readable
	   my $is_file_function = $token eq 'open' ||
				  $token eq 'close' ||
				  $token eq 'read';

       For larger numbers of strings, a hash is superior:

	   # Bad
	   my $is_perl_keyword =
	       $token =~ m/A (?: chomp | chop | chr | crypt | hex | index
				  lc | lcfirst | length | oct | ord | ... ) z/xms;

	   # Better
	   Readonly::Hash my %PERL_KEYWORDS => map {$_ => 1} qw(
	       chomp chop chr crypt hex index lc lcfirst length oct ord ...
	   );
	   my $is_perl_keyword = $PERL_KEYWORD{$token};

       Conway also suggests using "lc()" instead of a case-insensitive match.

   VARIANTS
       This policy detects both grouped and non-grouped strings.  The grouping may or may not be capturing.  The grouped body may or may not be
       alternating.  "A" and "z" are always considered anchoring which "^" and "$" are considered anchoring is the "m" regexp option is not in
       use.  Thus, all of these are violations:

	   m/^foo$/;
	   m/A foo z/x;
	   m/A foo z/xm;
	   m/A(foo)z/;
	   m/A(?:foo)z/;
	   m/A(foo|bar)z/;
	   m/A(?:foo|bar)z/;

       Furthermore, this policy detects violations in "m//", "s///" and "qr//" constructs, as you would expect.

CONFIGURATION

       This Policy is not configurable except for the standard options.

CREDITS

       Initial development of this policy was supported by a grant from the Perl Foundation.

AUTHOR

       Chris Dolan <cdolan@cpan.org>

COPYRIGHT

       Copyright (c) 2007-2011 Chris Dolan.  Many rights reserved.

       This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself.  The full text of this license
       can be found in the LICENSE file included with this module

perl v5.16.3							    2014-06Perl::Critic::Policy::RegularExpressions::ProhibitFixedStringMatches(3)

Perl::Critic::Policy::RegularExpressions::ProhibitUnusedUseruContributed Perl Perl::Critic::Policy::RegularExpressions::ProhibitUnusedCapture(3pm)

NAME

       Perl::Critic::Policy::RegularExpressions::ProhibitUnusedCapture - Only use a capturing group if you plan to use the captured value.

AFFILIATION

       This Policy is part of the core Perl::Critic distribution.

DESCRIPTION

       Perl regular expressions have multiple types of grouping syntax.  The basic parentheses (e.g. "m/(foo)/") captures into the magic variable
       $1.  Non-capturing groups (e.g. "m/(?:foo)/" are useful because they have better runtime performance and do not copy strings to the magic
       global capture variables.

       It's also easier on the maintenance programmer if you consistently use capturing vs. non-capturing groups, because that programmer can tell
       more easily which regexps can be refactored without breaking surrounding code which may use the captured values.

CONFIGURATION

       This Policy is not configurable except for the standard options.

CAVEATS

   "qr//" interpolation
       This policy can be confused by interpolation of "qr//" elements, but those are always false negatives.  For example:

	   my $foo_re = qr/(foo)/;
	   my ($foo) = m/$foo_re (bar)/x;

       A human can tell that this should be a violation because there are two captures but only the first capture is used, not the second.  The
       policy only notices that there is one capture in the regexp and remains happy.

   "@-", "@+", $LAST_MATCH_START and $LAST_MATCH_END
       This policy will only recognize capture groups referred to by these variables if the use is subscripted by a literal integer.

   $^N and $LAST_SUBMATCH_RESULT
       This policy will not recognize capture groups referred to only by these variables, because there is in general no way by static analysis to
       determine which capture group is referred to.  For example,

	   m/ (?: (A[[:alpha:]]+) | (Nd+) ) (?{$foo=$^N}) /smx

       makes use of the first capture group if it matches, or the second capture group if the first does not match but the second does.

CREDITS

       Initial development of this policy was supported by a grant from the Perl Foundation.

AUTHOR

       Chris Dolan <cdolan@cpan.org>

COPYRIGHT

       Copyright (c) 2007-2011 Chris Dolan.  Many rights reserved.

       This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself.  The full text of this license
       can be found in the LICENSE file included with this module

perl v5.14.2							    2012-06-07Perl::Critic::Policy::RegularExpressions::ProhibitUnusedCapture(3pm)