Originally Posted by apmcd47

I was going to say I agree with RudiC, but realise $LINE should be a subset of $1, not the other way round, so Rudi's solution probably won't get the results you want. So let's look at what is wrong with your code:

First line:

Code:

ls -d "/app/scripts"/* | while read LINE

In bash, when you pipe anything into a while loop you create a subshell. While I don't know what kind of performance hit you are getting from that, it does mean that any variables used in the loop are forgotten after the loop finishes. Not important here, but worth remembering. Second, the ls command is pointless here. The shell has expanded the file list for ls; it is printing them according to your whim, which is to print the files one-per-line. This first line would be much better off:

Code:

for LINE in "/app/scripts"/*

Next:

Code:

if echo $1 | grep -q "$LINE"

This is where your performance hit is. Every time you run this line you fork a new process for the grep. Imagine 50 files. 50 invocations of grep! Assuming bash (which I am), this would be much faster:

Code:

if [[ ${1} == *${LINE}* ]]

So this should be faster, unless I got it entirely wrong and Rudo got it right!

Code:

for LINE in "/app/scripts"/*
do
echo "File is:$LINE"
        if [[ ${1} == *${LINE}* ]]
        then
                echo "Match Found for File:$LINE"
        else
                echo "No Match Found"
        fi
done

Andrew