Hello Psy,

I suggest for now to only check if the JSON you want to generate is ok and only after having this 100% correct then go on to build the complete program call.

Regarding the json_object, this should be currently ok:

Example test script:

Code:

mk_json_object() {

        local pairs=""
        for((i=1;i<=$#;i+=2)) ; do
                [ -z "$pairs" ]  || pairs+=","
                pairs+="$(eval echo \'\"\'\$$i\'\"\': \'\"\'\$$(($i+1))\'\"\')"
        done
        echo "{ $pairs }"
}

mk_json_object_one_val() {

        local args=""
        local val="$1"
        shift
        for key in "$@"; do
                args+="$key $val "
        done
        mk_json_object $args # this variable should stay unquoted
}

mk_json_object_one_val myvalue mykey1 mykey2 mykey3

expected output:

Code:

{ "mykey1": "myvalue","mykey2": "myvalue","mykey3": "myvalue" }

You should have the same for the list, to check it's really working as expected.

About your command line:

Code:

bitcoin-cli -testnet sendmany "" {$pairs} 6 Payments [$items] true 6 CONSERVATIVE

If that is the final command line before calling the command, it is wrong, because {$pairs} is not a valid JSON object and [$items] is not a valid JSON Array. If this is not the final command, but the command that is to be executed(and evaluated) it is also most likely wrong, because {$pairs} and [$items] are not quoted and will result in wrong data after shell evaluation. Use "{$pairs}" and "[$items]". Aside from that the so far introduced functions already provide brackets. You probably have double brackets, which is not valid JSON.

Please look at the command and show it like it is executed, like this:

Code:

set -x
bitcoin-cli...

So you get the output from bash on the console how the final command really looks like.

Example:

Code:

object="$(mk_json_object_one_val myvalue mykey1 mykey2 mykey3)"
set -x
bitcoin-cli "$object" "par2 "par3"
set +x

Output:

Code:

[stomp@tu02c7dl log]$ ./testscript

+ bitcoin-cli '{ "mykey1": "myvalue","mykey2": "myvalue","mykey3": "myvalue" }' par2 par3
+ set +x

You see in the output the single quotes where the shell set the parameter boundary. The whole object is one parameter, which is exactly as desired.