Hi Chubler_XL,
Your example works fine for the example you've chosen, but, as mattz40 mentioned in post #4 in this thread, it won't work if one or more of the filenames in the lists in the expansions of $dir1 and $dir2 contain a <space> character.

Hi mattz40,
Maybe you would want to try something more like:

Code:

#!/bin/bash
# Compare file names in source and target directories
# Move duplicates from source to duplicates directory (not yet implemented)
# Move remaining files in source to target directory (not yet implemented)
# Only care about filenames; not checksum, date, time

dir1="/mnt/nas/source"
dir2="/mnt/nas/target"
dir3="/mnt/nas/Duplicates"

for Path1 in "$dir1"/*.*
do	File1="${Path1##*/}"
	found=0
	for Path2 in "$dir2"/*.*
	do	if [ "$File1" = "${Path2##*/}" ]
		then	found=1
			break
		fi
	done
	if [ $found -eq 1 ]
	then	echo "Duplicate: \"$File1\""
	else	echo "Unique: \"$File1\""
	fi
done

Note that the comment line in your sample code:

Code:

# Only care about files names, not upper lower case, checksum, date, time

has been modified because this code does care about case in filenames. You can modify the code if you want to allow case-insensitive matches, but that is not the way normal UNIX/Linux/BSD filesystems work.

If the directory /mnt/nas/source contains the files:

Code:

birds and bees.jpg
flowers.jpg
hive.jpg

and the directory /mnt/nas/target contains the files:

Code:

beehive.jpg
birds and bees.jpg
flowers.jpg

then the above code will produce the output:

Code:

Duplicate: "birds and bees.jpg"
Duplicate: "flowers.jpg"
Unique: "hive.jpg"

Note also that the dir1 and dir2 variables now contain the full pathnames of the source and target directories; not lists of words contained in filenames in those directories. The Path1 and Path2 variables contain absolute pathnames of a file in the source and target directories, respectively and the File1 variable contains the filename of the last component of the pathname in the expansion of $Path1.

Note that bakunin gave an excellent explanation of what was wrong in your if [ ... ] expression. But I have to disagree with one point. The standard test expression and [ expression ] string equality operator is a single <equals-sign>, not the double <equals-sign> that is used in the C Language. Some shells will accept both, some shells will give you a syntax error is you use the double <equals-sign>, and some manual pages for some shells will say that the single <equals-sign> form is deprecated, but that is not what the shell standards say. I don't know of any shells that do not accept the single <equals-sign> form that is required by the standards.

(Some shells also have a [[ expression ]] in which [[ is a shell keyword; not the name of utility used to evaluate expressions. In the shells that understand [[ expression ]], the string equality operator in expression in this form is the double <equals-sign> in all shells that I've used. And some shells accept a single <equal-sign> operator in this form with a similar, but not always identical, meaning.)