Sponsored Content
Top Forums Shell Programming and Scripting Check my Script and Say what Grinds Your Gears Post 303025939 by Corona688 on Thursday 15th of November 2018 12:42:11 PM
Old 11-15-2018
Not everyone has readlink. You can check the SHELL variable instead, it's quite standard.

Use [[ "$VAR1" == "value" ]] as single-equals and single square-braces are now archaic.

Automatically rerunning it with BASH is begging for an infinite loop if anything weird happens. You also didn't check if that exec failed.

Error messages should go to stderr, a la
Code:
echo 'The script is ran by different shell, not Bash shell, be cautious next time.' >&2

Otherwise, people may find big flat error messages in their flatfiles whenever they redirect the output.

You don't need to and probably shouldn't be checking the text output of sudo -- just get its return value. There's also no reason to use a sub-shell, or a sub-sub-shell within that sub-shell. You can put it right into the if-statement as if it belongs there, which it does, with an ! in front to invert the return value.

Code:
if ! sudo -n true </dev/null 2>/dev/null
then
        echo 'This script is required to be ran as root user.' >&2
        echo 'You will be asked for a password.' >&2
fi

You don't need to end lines with ;
 

9 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

script for netmask check

I want develop a script which should also check validity of netmask. e.g. /etc/netmasks 10.15.20.30 255.255.255.224 How can I check which IP adresses are valid for this netmask? I think the best is use logical operations. 224 is 1 1 1 0 0 0 0 0 so is valid from 10.15.20.31... (2 Replies)
Discussion started by: rhacodactylus
2 Replies

2. UNIX for Dummies Questions & Answers

Script to check for a file, check for 2hrs. then quit

I wish to seach a Dir for a specific file, once the file is found i will perform additional logic. If the file is not found within two hours, i would like to exit. Logically, I'm looking for the best way to approach this Thanks for any assistance in advance. Note: I'm using a C shell and... (2 Replies)
Discussion started by: mmarsh
2 Replies

3. Shell Programming and Scripting

check in unix shell script so that no one is able to run the script manually

I want to create an automated script which is called by another maually executed script. The condition is that the no one should be able to manually execute the automated script. The automated script can be on the same machine or it can be on a remote machine. Can any one suggest a check in the... (1 Reply)
Discussion started by: adi_bang76
1 Replies

4. Shell Programming and Scripting

check my first shell script

I have written the below script to determine whether a string is palindrome or not ? But its not working, any help to debug it ? I am new to this forum but when I searched for my question, I found that many people refused to answer this question thinking that its Homework question, Therefore I... (2 Replies)
Discussion started by: gridview
2 Replies

5. Shell Programming and Scripting

please check this script.

please check this script and let me know.wher eis the issue. #!/bin/ksh set -A logs AAA BB CCC DDD EE FFF set -A ltime 7 60 7 7 7 60 set i=1 while } ] do find /home/logs -name "*"\${logs}"\*.log" -mtime ${l time} -type f -ls let i=$i+1 done (3 Replies)
Discussion started by: sab_sree
3 Replies

6. Shell Programming and Scripting

perl script to check if empty files are created and delete them and run a shell script

I have a local linux machine in which the files are dumped by a remote ubuntu server. If the process in remote server has any problem then empty files are created in local machine. Is there any way using perl script to check if the empty files are being created and delete them and then run a shell... (2 Replies)
Discussion started by: hussa1n
2 Replies

7. Shell Programming and Scripting

script to check if another script is running and if so, then sleep for sometime and check again

Hi, I am a unix newbie. I need to write a script to check wheteher another script is still running. If it is, then sleep for 30m and then check again if the script is running. If the script has stopped running then, I need to come out of the loop. I am using RHEL 5.2 (2 Replies)
Discussion started by: mathews
2 Replies

8. Programming

Check This Script

Hi guys, I am sending the script i created..plzzz check it correct if any mistakes...:). Plz reply early by today.. here i want to find the files based on date , if files are avaliable i want to send a mail to the user. here there are a total of 43 files. they are constant. Here is... (0 Replies)
Discussion started by: apple2685
0 Replies

9. Shell Programming and Scripting

Bash shell script to check if script itself is running

hi guys we've had nagios spewing false alarm (for the umpteenth time) and finally the customer had enough so they're starting to question nagios. we had the check interval increased from 5 minutes to 2 minutes, but that's just temporary solution. I'm thinking of implementing a script on the... (8 Replies)
Discussion started by: hedkandi
8 Replies
SH(1)							      General Commands Manual							     SH(1)

NAME
sh, ., break, case, cd, continue, eval, exec, exit, export, for, if, read, readonly, set, shift, trap, umask, wait, while - shell SYNOPSIS
sh [-eiknqstvxu] [-c str] [file] OPTIONS
-c Execute the commands in str -e Quit on error -i Interactive mode; ignore QUIT, TERMINATE, INTERRUPT -k Look for name=value everywhere on command line -n Do not execute commands -q Change qflag from sig_ign to sig_del -s Read commands from standard input -t Exit after reading and executing one command -v Echo input lines as they are read -x Trace -u Unset variables EXAMPLES
sh script # Run a shell script DESCRIPTION
Sh is the shell, which forms the user's main interface with the system. On startup, the shell reads /etc/profile and $HOME/.profile, if they exist, and executes any commands they contain. The Minix shell has most of the features of the V7 (Bourne) shell, including redirect- ion of input and output, pipes, magic characters, background processes, and shell scripts. A brief summary follows, but whole books have been written on shell programming alone. Some of the more common notations are: date # Regular command sort <file # Redirect stdin (standard input) sort <file1 >file2 # Redirect stdin and stdout cc file.c 2>error # Redirect stderr a.out >f 2>&1 # Combine standard output and standard error sort <file1 >>file2 #Append output to file2 sort <file1 >file2 & #Background job (ls -l; a.out) & # Run two background commands sequentially sort <file | wc # Two-process pipeline sort <f | uniq | wc # Three-process pipeline ls -l *.c # List all files ending in .c ls -l [a-c]* # List all files beginning with a, b, or c ls -l ? # List all one-character file names ls ? # List the file whose name is question mark ls '???' # List the file whose name is three question marks v=/usr/ast # Set shell variable v ls -l $v # Use shell variable v PS1='Hi! ' # Change the primary prompt to Hi! PS2='More: ' # Change the secondary prompt to More: ls -l $HOME # List the home directory echo $PATH # Echo the search path echo $? # Echo exit status of previous command in decimal echo $$ # Echo shell's pid in decimal echo $! # Echo PID of last background process echo $# # Echo number of parameters (shell script) echo $2 # Echo second parameter (shell script) echo "$2" # Echo second parameter without expanding spaces echo $* # Echo all parameters (shell script) echo $@ # Echo all parameters (shell script) echo "$@" # Echo all parameters without expanding spaces The shell uses the following variables for specific purposes: SHELL the path of the current shell HOME the default value for the cd(1) command PATH the directories to be searched to find commands IFS the internal field separators for command strings PS1 the primary shell prompt PS2 the secondary shell prompt There are various forms of substitution on the shell command line: `...` Command string between back-quotes is replaced by its output "..." Permits variable substitution between quotes '...' Inhibits variable substitution between quotes $VAR Replaced by contents of variable VAR ${VAR} Delimits variable VAR from any following string The expressions below depend on whether or not VAR has ever been set. If VAR has been set, they give: ${VAR-str} Replace expression by VAR, else by str ${VAR=str} Replace expression by VAR, else by str and set VAR to str ${VAR?str} Replace expression by VAR, else print str and exit shell ${VAR+str} Replace expression by str, else by null string If a colon is placed after VAR, the expressions depend on whether or not VAR is currently set and non-null. The shell has a number of built-in commands: : return true status . fn execute shell script fn on current path break [n] break from a for, until or while loop; exit n levels continue [n] continue a for, until or while loop; resume nth loop cd [dir] change current working directory; move to $HOME eval cmd rescan cmd, performing substitutions eval rescan the current command line exec cmd execute cmd without creating a new process exec <|> with no command name, modify shell I/O exit [n] exit a shell program, with exit value n export [var] export var to shell's children; list exported variables pwd print the name of the current working directory read var read a line from stdin and assign to var readonly [var] make var readonly; list readonly variables set -f set shell flag (+f unsets flag) set str set positional parameter to str set show the current shell variables shift reassign positional parameters (except ${0}) one left times print accumulated user and system times for processes trap arg sigs trap signals sigs and run arg on receipt trap list trapped signals umask [n] set the user file creation mask; show the current umask wait [n] wait for process pid n; wait for all processes The shell also contains a programming language, which has the following operators and flow control statements: # Comment The rest of the line is ignored = Assignment Set a shell variable && Logical AND Execute second command only if first succeeds || Logical OR Execute second command only if first fails (...) Group Execute enclosed commands before continuing for For loop (for ... in ... do ... done) case Case statement ((case ... ) ... ;; ... esac) esac Case statement end while While loop (while ... do ... done) do Do/For/While loop start (do ... until ...) done For/While loop end if Conditional statement (if ... else ... elif ... fi) in For loop selection then Conditional statement start else Conditional statement alternative elif Conditional statement end until Do loop end fi Conditional statement end SEE ALSO
echo(1), expr(1), pwd(1), true(1). SH(1)
All times are GMT -4. The time now is 10:54 AM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy