Login or Register to Ask a Question and Join Our Community

Sponsored Content
Full Discussion: Check my Script and Say what Grinds Your Gears
Top Forums Shell Programming and Scripting Check my Script and Say what Grinds Your Gears Post 303025939 by Corona688 on Thursday 15th of November 2018 12:42:11 PM
Old 11-15-2018
Not everyone has readlink. You can check the SHELL variable instead, it's quite standard.

Use [[ "$VAR1" == "value" ]] as single-equals and single square-braces are now archaic.

Automatically rerunning it with BASH is begging for an infinite loop if anything weird happens. You also didn't check if that exec failed.

Error messages should go to stderr, a la
Code:
echo 'The script is ran by different shell, not Bash shell, be cautious next time.' >&2

Otherwise, people may find big flat error messages in their flatfiles whenever they redirect the output.

You don't need to and probably shouldn't be checking the text output of sudo -- just get its return value. There's also no reason to use a sub-shell, or a sub-sub-shell within that sub-shell. You can put it right into the if-statement as if it belongs there, which it does, with an ! in front to invert the return value.

Code:
if ! sudo -n true </dev/null 2>/dev/null
then
        echo 'This script is required to be ran as root user.' >&2
        echo 'You will be asked for a password.' >&2
fi

You don't need to end lines with ;
 

9 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

script for netmask check

I want develop a script which should also check validity of netmask. e.g. /etc/netmasks 10.15.20.30 255.255.255.224 How can I check which IP adresses are valid for this netmask? I think the best is use logical operations. 224 is 1 1 1 0 0 0 0 0 so is valid from 10.15.20.31... (2 Replies)
Discussion started by: rhacodactylus
2 Replies

2. UNIX for Dummies Questions & Answers

Script to check for a file, check for 2hrs. then quit

I wish to seach a Dir for a specific file, once the file is found i will perform additional logic. If the file is not found within two hours, i would like to exit. Logically, I'm looking for the best way to approach this Thanks for any assistance in advance. Note: I'm using a C shell and... (2 Replies)
Discussion started by: mmarsh
2 Replies

3. Shell Programming and Scripting

check in unix shell script so that no one is able to run the script manually

I want to create an automated script which is called by another maually executed script. The condition is that the no one should be able to manually execute the automated script. The automated script can be on the same machine or it can be on a remote machine. Can any one suggest a check in the... (1 Reply)
Discussion started by: adi_bang76
1 Replies

4. Shell Programming and Scripting

check my first shell script

I have written the below script to determine whether a string is palindrome or not ? But its not working, any help to debug it ? I am new to this forum but when I searched for my question, I found that many people refused to answer this question thinking that its Homework question, Therefore I... (2 Replies)
Discussion started by: gridview
2 Replies

5. Shell Programming and Scripting

please check this script.

please check this script and let me know.wher eis the issue. #!/bin/ksh set -A logs AAA BB CCC DDD EE FFF set -A ltime 7 60 7 7 7 60 set i=1 while } ] do find /home/logs -name "*"\${logs}"\*.log" -mtime ${l time} -type f -ls let i=$i+1 done (3 Replies)
Discussion started by: sab_sree
3 Replies

6. Shell Programming and Scripting

perl script to check if empty files are created and delete them and run a shell script

I have a local linux machine in which the files are dumped by a remote ubuntu server. If the process in remote server has any problem then empty files are created in local machine. Is there any way using perl script to check if the empty files are being created and delete them and then run a shell... (2 Replies)
Discussion started by: hussa1n
2 Replies

7. Shell Programming and Scripting

script to check if another script is running and if so, then sleep for sometime and check again

Hi, I am a unix newbie. I need to write a script to check wheteher another script is still running. If it is, then sleep for 30m and then check again if the script is running. If the script has stopped running then, I need to come out of the loop. I am using RHEL 5.2 (2 Replies)
Discussion started by: mathews
2 Replies

8. Programming

Check This Script

Hi guys, I am sending the script i created..plzzz check it correct if any mistakes...:). Plz reply early by today.. here i want to find the files based on date , if files are avaliable i want to send a mail to the user. here there are a total of 43 files. they are constant. Here is... (0 Replies)
Discussion started by: apple2685
0 Replies

9. Shell Programming and Scripting

Bash shell script to check if script itself is running

hi guys we've had nagios spewing false alarm (for the umpteenth time) and finally the customer had enough so they're starting to question nagios. we had the check interval increased from 5 minutes to 2 minutes, but that's just temporary solution. I'm thinking of implementing a script on the... (8 Replies)
Discussion started by: hedkandi
8 Replies

LEARN ABOUT MOJAVE

test::script

Test::Script(3) 					User Contributed Perl Documentation					   Test::Script(3)

NAME

       Test::Script - Basic cross-platform tests for scripts

DESCRIPTION

       The intent of this module is to provide a series of basic tests for 80% of the testing you will need to do for scripts in the script (or
       bin as is also commonly used) paths of your Perl distribution.

       Further, it aims to provide this functionality with perfect platform-compatibility, and in a way that is as unobtrusive as possible.

       That is, if the program works on a platform, then Test::Script should always work on that platform as well. Anything less than 100% is
       considered unacceptable.

       In doing so, it is hoped that Test::Script can become a module that you can safely make a dependency of all your modules, without risking
       that your module won't on some platform because of the dependency.

       Where a clash exists between wanting more functionality and maintaining platform safety, this module will err on the side of platform
       safety.

FUNCTIONS

   script_compiles
	   script_compiles( 'script/foo.pl', 'Main script compiles' );

       The "script_compiles" test calls the script with "perl -c script.pl", and checks that it returns without error.

       The path it should be passed is a relative unix-format script name. This will be localised when running "perl -c" and if the test fails the
       local name used will be shown in the diagnostic output.

       Note also that the test will be run with the same perl interpreter that is running the test script (and not with the default system perl).
       This will also be shown in the diagnostic output on failure.

   script_runs
	   script_runs( 'script/foo.pl', 'Main script runs' );

       The "script_runs" test executes the script with "perl script.pl" and checks that it returns success.

       The path it should be passed is a relative unix-format script name. This will be localised when running "perl -c" and if the test fails the
       local name used will be shown in the diagnostic output.

       The test will be run with the same perl interpreter that is running the test script (and not with the default system perl). This will also
       be shown in the diagnostic output on failure.

SUPPORT

       All bugs should be filed via the bug tracker at

       <http://rt.cpan.org/NoAuth/ReportBug.html?Queue=Test-Script>

       For other issues, or commercial enhancement and support, contact the author.

AUTHOR

       Adam Kennedy <adamk@cpan.org>

SEE ALSO

       prove, <http://ali.as/>

COPYRIGHT

       Copyright 2006 - 2009 Adam Kennedy.

       This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself.

       The full text of the license can be found in the LICENSE file included with this module.

perl v5.18.2							    2009-11-23							   Test::Script(3)
All times are GMT -4. The time now is 05:28 AM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy