Check my Script and Say what Grinds Your Gears Post: 303025939

Sponsored Content

Top Forums Shell Programming and Scripting Check my Script and Say what Grinds Your Gears Post 303025939 by Corona688 on Thursday 15th of November 2018 12:42:11 PM

11-15-2018

Registered User

Not everyone has readlink. You can check the SHELL variable instead, it's quite standard.

Use [[ "$VAR1" == "value" ]] as single-equals and single square-braces are now archaic.

Automatically rerunning it with BASH is begging for an infinite loop if anything weird happens. You also didn't check if that exec failed.

Error messages should go to stderr, a la

Code:

echo 'The script is ran by different shell, not Bash shell, be cautious next time.' >&2

Otherwise, people may find big flat error messages in their flatfiles whenever they redirect the output.

You don't need to and probably shouldn't be checking the text output of sudo -- just get its return value. There's also no reason to use a sub-shell, or a sub-sub-shell within that sub-shell. You can put it right into the if-statement as if it belongs there, which it does, with an ! in front to invert the return value.

Code:

if ! sudo -n true </dev/null 2>/dev/null
then
        echo 'This script is required to be ran as root user.' >&2
        echo 'You will be asked for a password.' >&2
fi

You don't need to end lines with ;

Corona688

View Public Profile for Corona688

Visit Corona688's homepage!

Find all posts by Corona688

9 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

script for netmask check

I want develop a script which should also check validity of netmask. e.g. /etc/netmasks 10.15.20.30 255.255.255.224 How can I check which IP adresses are valid for this netmask? I think the best is use logical operations. 224 is 1 1 1 0 0 0 0 0 so is valid from 10.15.20.31...

2. UNIX for Dummies Questions & Answers

Script to check for a file, check for 2hrs. then quit

I wish to seach a Dir for a specific file, once the file is found i will perform additional logic. If the file is not found within two hours, i would like to exit. Logically, I'm looking for the best way to approach this Thanks for any assistance in advance. Note: I'm using a C shell and...

3. Shell Programming and Scripting

check in unix shell script so that no one is able to run the script manually

I want to create an automated script which is called by another maually executed script. The condition is that the no one should be able to manually execute the automated script. The automated script can be on the same machine or it can be on a remote machine. Can any one suggest a check in the...

4. Shell Programming and Scripting

check my first shell script

I have written the below script to determine whether a string is palindrome or not ? But its not working, any help to debug it ? I am new to this forum but when I searched for my question, I found that many people refused to answer this question thinking that its Homework question, Therefore I...

5. Shell Programming and Scripting

please check this script.

please check this script and let me know.wher eis the issue. #!/bin/ksh set -A logs AAA BB CCC DDD EE FFF set -A ltime 7 60 7 7 7 60 set i=1 while } ] do find /home/logs -name "*"\${logs}"\*.log" -mtime ${l time} -type f -ls let i=$i+1 done

6. Shell Programming and Scripting

perl script to check if empty files are created and delete them and run a shell script

I have a local linux machine in which the files are dumped by a remote ubuntu server. If the process in remote server has any problem then empty files are created in local machine. Is there any way using perl script to check if the empty files are being created and delete them and then run a shell...

7. Shell Programming and Scripting

script to check if another script is running and if so, then sleep for sometime and check again

Hi, I am a unix newbie. I need to write a script to check wheteher another script is still running. If it is, then sleep for 30m and then check again if the script is running. If the script has stopped running then, I need to come out of the loop. I am using RHEL 5.2

8. Programming

Check This Script

Hi guys, I am sending the script i created..plzzz check it correct if any mistakes...:). Plz reply early by today.. here i want to find the files based on date , if files are avaliable i want to send a mail to the user. here there are a total of 43 files. they are constant. Here is...

9. Shell Programming and Scripting

Bash shell script to check if script itself is running

hi guys we've had nagios spewing false alarm (for the umpteenth time) and finally the customer had enough so they're starting to question nagios. we had the check interval increased from 5 minutes to 2 minutes, but that's just temporary solution. I'm thinking of implementing a script on the...

LEARN ABOUT DEBIAN

installsieve

INSTALLSIEVE(1) 					      General Commands Manual						   INSTALLSIEVE(1)

 *

NAME

       installsieve - user utility for managing sieve scripts

SYNOPSIS

       installsieve

DESCRIPTION

       installsieve is a utility that allows users to manage their sieve scripts kept on the server.

OPTIONS

       -v <name> View script with the given name. The script if retrieved sucessfully is output to standard output.

       -l  List  all  of  the scripts currently on the server. If one of the scripts is active a arrow is printed indicating that it is the active
       script.

       -p <port> Port to connect to. If left off this defaults to "sieve" as defined in /etc/services.

       -i <file> Install a file onto the server. If a script with the same name already exists on the server it is overwritten.  Upon  sucessfully
       putting	the  script on the server the script is set active. If <file> has the extension .script it is chopped when put on the server since
       sieve names may not contain a '.'.

       -a <name> Set <name> as the active script. The list of available names can be obtained from the '-l' option..

       -d <name> Delete the sieve script on the server with <name>.

       -m <mechanism> Force installsieve to use <mechanism> for authentication. If not specified the strongest authentication mechanism is chosen.

       -g <name> Get the sieve script with <name> and save it to disk with a ".script" extension. If a file with that name already  exists  it	is
       overwritten.

       -u <user> Userid/Authname to use for authentication; by default, the current user.

CMU
								   Project Cyrus						   INSTALLSIEVE(1)