Optimizing the Shell Script [Expert Advise Needed] Post: 303007854

Sponsored Content

Top Forums Shell Programming and Scripting Optimizing the Shell Script [Expert Advise Needed] Post 303007854 by MadeInGermany on Wednesday 22nd of November 2017 03:11:45 PM

11-22-2017

Registered User

If the long runtime is caused by the many files that find needs to traverse then there is hardly anything that can be done.
But maybe it is due to a misbehavior of a special character.
The following is a bit safer, and contains some further optimizations, like using a filedescriptor for logging rather than open-append-close each time, and sorting on key field 1 only, ...

Code:

#!/bin/bash
PATH=/bin:/usr/bin:/usr/sbin:/sbin
NOW=$(date +"%F-%H:%M:%S")
LOGFILE="purge_duplicate_log-$NOW.log"
LOGTIME=`date "+%Y-%m-%d %H:%M:%S"`
cd /tmp/sathish/GB/ || exit
mkdir -p dup || exit
echo "$LOGFILE"
exec 3>>"$LOGFILE" # open it once, the shell will close it at exit
echo "Started at $LOGTIME " >&3
echo "Before File Count " >&3
ls | wc -l >&3
dups=$(find . -type f \( -iname "*.xml" \) -printf '%T@ %p\n' | sort -rg -k 1,1 | sed 's/[^ ]* //' | awk -F"_" 'dup[$1]++')
if [ -z "$dups" ]
then
  echo "No Duplicates Identified" >&3
else
  set -f # no wildcard globbing, only word splitting
  for i in $dups
  do
    mv -vf "$i" dup/
  done >&3 2>&1
  set +f
fi
echo "Ended at $LOGTIME " >&3
echo "After File Count " >&3
ls | wc -l >&3

MadeInGermany

View Public Profile for MadeInGermany

Find all posts by MadeInGermany

8 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

shell script help needed

I am trying to query a table having 3 columns, the third column is a field of varchar(1024) with a SQL string in it. I am using cut command to split out the three fields into three variables. I do a db2 command to extract the data into a file. My problem is with the third field having the SQL...

2. Shell Programming and Scripting

mail program on shell script didn't work, please advise.

Hi, everyone: I post a new thread because previous post may sink and I hope the new one can be caught by your eyes. I created a shell script and the script works fine. However, the mail program part on script didn't send email to my email box and it also didn't provide any traceable...

3. Shell Programming and Scripting

Need help optimizing this piece of code (Shell script Busybox)

I am looking for suggestions on how I could possibly optimized that piece of code where most of the time is spend on this script. In a nutshell this is a script that creates an xml file(s) based on certain criteria that will be used by a movie jukebox. Example of data: $SORTEDTMP= it is a...

4. Shell Programming and Scripting

Need some expert advise on running scripts.

We have couple of scripts made for our environment (which is Oracle Virtulisation ) . Each script is assigned a different task . Some of the scripts are meant to run on centralized server for monitoring other Servers resource utilization such as CPU,Storage. While some are meant to run on...

5. UNIX for Advanced & Expert Users

os x hdiutil expert needed

I am writing a script that using the "Total Bytes" field from hdiutil imageinfo -plist <file>. My intention is to get the total mounted size of a compressed dmg. It works for some images, but sometimes it doesn't seem to match up, particularly with larger (over 1 gb) images. Can anybody explain...

6. Shell Programming and Scripting

fgrep command: Perl programming help needed..Kindly advise

Hi, I am novice in PERL enviornment. I have a text files withso many entries in rows and columns. I have to pick up entries named as "Uniprot ID" in the file and create a new text file with list of particular Uniprot ID entries. Can anybody guide regarding this.. I came to know abut fgrep...

7. Shell Programming and Scripting

How to expert Shell Programming ?

Guys, I have been reading the bash books, there are so many command & operators etc. The theory part is so much. Overall I have read some book. Still do not feel I know the bash with confidence. Lots of Jobs for System Admin demand Scripting knowledge as requirement .. I think I should...

8. Shell Programming and Scripting

Portable shell script advise

All, I have a need for a portable shell script for LInux and HPUX. The script has a simple need; Check for local files of a specific name (i.e. filename*), scp them to another system, and archive them to a folder. The script runs via cron. I first wrote the script in Linux (bash with gnu...

LEARN ABOUT SUNOS

shells

shells(4)							   File Formats 							 shells(4)

NAME

       shells - shell database

SYNOPSIS

       /etc/shells

DESCRIPTION

       The shells file contains a list of the shells on the system. Applications use this file to determine whether a shell is valid. See getuser-
       shell(3C). For each shell a single line should be present, consisting of the shell's path, relative to root.

       A hash mark (#) indicates the beginning of a comment; subsequent characters up to the end of the line are not interpreted by  the  routines
       which search the file. Blank lines are also ignored.

       The  following  default	shells are used by utilities: /bin/bash, /bin/csh, /bin/jsh, /bin/ksh, /bin/pfcsh, /bin/pfksh, /bin/pfsh, /bin/sh,
       /bin/tcsh,  /bin/zsh,  /sbin/jsh,  /sbin/sh,  /usr/bin/bash,  /usr/bin/csh,  /usr/bin/jsh,  /usr/bin/ksh,  /usr/bin/pfcsh,  /usr/bin/pfksh,
       /usr/bin/pfsh, and /usr/bin/sh, /usr/bin/tcsh, /usr/bin/zsh. Note that /etc/shells overrides the default list.

       Invalid shells in /etc/shells may cause unexpected behavior (such as being unable to log in by way of ftp(1)).

FILES

       /etc/shells	       lists shells on system

SEE ALSO

       vipw(1B), ftpd(1M), sendmail(1M), getusershell(3C), aliases(4)

SunOS 5.10							    4 Jun 2001								 shells(4)