Improving code Post: 302991069

Sponsored Content

Top Forums Shell Programming and Scripting Improving code Post 302991069 by Corona688 on Monday 6th of February 2017 11:04:03 AM

02-06-2017

Registered User

I'll cut to the chase and be a bit more generous -- you are reprocessing your input files over, and over, and over, and over, and over, and over, and over, when you could have done so just once or twice.

Your code is too big a mess to replace wholesale, especially since we know nothing about your input, but 'filter by conditions' is particularly egregious. You are allowed to put more than one statement in an awk program! You could have done 5 times as much work at once. Here is pseudocode.

Code:

read vpff vpds4a vpds4b vpds4 vpdsss <<EOF
$( awk '
        awk-range1 { count1++ }
        awk-range2 { count2++ }
        awk-range3 { count3++ }
        awk-range4 { count4++ }
        awk-range5 { count5++ }
        END { print count1+0, count2+0, count3+0, count4+0, count5+0; }' tmp4 )
EOF

The idea is to have awk print a line like "5 7 3 9 12" which gets dumped into read and split among its variables.

This User Gave Thanks to Corona688 For This Post:

Corona688

View Public Profile for Corona688

Visit Corona688's homepage!

Find all posts by Corona688

6 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

improving my script

Hi; I want to access our customer database to retreive all clients that have as language index 2 or 3 and take their client number. My input is a file containing all client numbers. i access the data base using a function call "scpshow". The total number of clients i want to scan is 400 000...

2. UNIX for Dummies Questions & Answers

Improving Unix Skills

Kindly any advice to improve my unix skills as electronic books i can download or valuable sites as this one etc...

3. Shell Programming and Scripting

Improving this validate function

Hi guys, I use this function which was provided to me by someone at this site. It works perfectly for validating a users input option against allowed options.. example: validateInput "1" "1 3 4 5" would return 0 (success) function validateInput { input=$1 allowedInput=$2 for...

4. Shell Programming and Scripting

Improving code by using associative arrays

I have the following code, and I am changing it to #!/bin/bash hasArgumentCModInfile=0 hasArgumentSrcsInfile=0 hasArgumentRcvsInfile=0 OLDIFS="$IFS" IFS="|=" # IFS controls splitting. Split on "|" and "=", not whitespace. set -- $* # Set the positional...

5. Shell Programming and Scripting

Basic help improving for in loop

I'm obviously very new to this. I'm trying to write a simple for loop that will read the directory names in /Users and then copy a file into the same subdir in each user directory. I have this, and it works but it isn't great. #!/bin/bash HOMEDIRS=/Users/* for dirs in $HOMEDIRS; do if ];...

6. Shell Programming and Scripting

Need help improving my script.

Thank you for taking the time to look at this and provide input. To start, I am not a linux/unix expert but I muddle through the best I can. I am also in no way shape or form a programmer. Please keep that in mind as you read this script. This script is designed to find all files in a given...

LEARN ABOUT DEBIAN

ra_t8

RA_T8(1)						      General Commands Manual							  RA_T8(1)

NAME

       ra_t8 - convert RADIANCE picture to/from Targa 8-bit image file

SYNOPSIS

       ra_t8 [ -d ][ -b ][ -c ncolors ][ -g gamma ][ -e +/-stops ][ -n sampfac ] input [ output ]
       ra_t8 -r [ -g gamma ][ -e +/-stops ] [ input [ output ] ]

DESCRIPTION

       Ra_t8  converts	between RADIANCE and Targa 8-bit color-mapped image files (type 1 in Targa's documentation).  In the default mode, a RADI-
       ANCE picture is converted to a color-mapped Targa file of the same horizontal and vertical dimensions with 8-bits per pixel.  The -d option
       turns  off  dithering.  The -b option converts the image to black and white.  Only with this option can the input be taken from stdin.  The
       -c option allows fewer than 256 colors.	The -g option specifies the exponent used in gamma correction; the default value is 2.2.  An expo-
       nent  of  1.0 turns gamma correction off.  The -e option specifies an exposure compensation in f-stops (powers of two).	Only integer stops
       are allowed, for efficiency.  The -n option specifies a sampling factor for neural  network  color  quantization.   This  value	should	be
       between	1  and	80,  where  1 takes the longest and produces the best results in small areas of the image.  If no value is given, a faster
       median cut algorithm is used.  The -r option invokes a reverse conversion, from an 8-bit Targa file to a RADIANCE picture.  If  the  output
       file is missing, the standard output is used.

AUTHORS

       Greg Ward
       Anthony Dekker provided the code for neural network color quantization

BUGS

       Run-length encoded files can be read but not written with this program.

SEE ALSO

       pfilt(1), ra_bmp(1), ra_bn(1), ra_ppm(1), ra_pr(1), ra_pr24(1), ra_t16(1), ra_tiff(1), ximage(1)

RADIANCE
							      5/30/95								  RA_T8(1)